Skip to contentSkip to conversation

tools/bpftool: remove warning about PID iterator support

PATCH Applied Andrii Nakryiko 3 participants 3 messages Jul 10, 2020 – Jul 13, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/bpftool: remove warning about PID iterator support

Don't emit warning that bpftool was built without PID iterator support. This error garbles JSON output of otherwise perfectly valid show commands.

---
 tools/bpf/bpftool/pids.c | 1 -
 1 file changed, 1 deletion(-)
tools/bpf/bpftool/pids.c +0 -1
index c0d23ce4a6f4..e3b116325403 100644
@@ -15,7 +15,6 @@
 
 int build_obj_refs_table(struct obj_refs_table *table, enum bpf_obj_type type)
 {
-	p_err("bpftool built without PID iterator support");
 	return -ENOTSUP;
 }
 void delete_obj_refs_table(struct obj_refs_table *table) {}
Signature · 1 line
2.24.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Andrii Nakryiko

Don't emit warning that bpftool was built without PID iterator support. This error garbles JSON output of otherwise perfectly valid show commands.

Thanks for the fix.

Quoted 17 lines
---
  tools/bpf/bpftool/pids.c | 1 -
  1 file changed, 1 deletion(-)
tools/bpf/bpftool/pids.c +0 -1
index c0d23ce4a6f4..e3b116325403 100644
@@ -15,7 +15,6 @@
 
  int build_obj_refs_table(struct obj_refs_table *table, enum bpf_obj_type type)
  {
-	p_err("bpftool built without PID iterator support");
  	return -ENOTSUP;
  }
  void delete_obj_refs_table(struct obj_refs_table *table) {}