Skip to contentSkip to conversation

Fix swupdate build by installing mtd headers as expected

PATCH New Thomas W. 2 participants 5 messages Jul 10, 2020 – Jul 11, 2020

lore
Share & tools
lore
#2 lore raw

PATCH 1/1 Fix swupdate build by installing mtd headers as expected

In reply to Thomas W.

Hello Thomas,

Thanks for your contribution!

Quoted 8 lines · On Fri, 10 Jul 2020 15:41:37 -0400 "Thomas W." <[email protected]>…

swupdate expects libmtd.h and libubi.h to be in the include folder and not in the mtd namespace.
(see also:
https://groups.google.com/forum/#!topic/swupdate/Apv_yRLmgzY
https://groups.google.com/forum/#!topic/swupdate/gd25RIPa00w
https://groups.google.com/forum/#!topic/swupdate/gei0Gc_5j8M)

Which problem is this fixing ? Is there a build issue today ? We have had mtd + swupdate for quite some time. Why suddenly should we change this ?

Quoted 16 lines
package/mtd/mtd.mk +0 -1
index 3477460200..76ede98879 100644
@@ -119,8 +119,8 @@ endef
 # Those libraries are not installed by "make install", but are needed
 # by other packages, such as swupdate.
 define MTD_INSTALL_LIBS
-    $(INSTALL) -D -m 0755 $(@D)/include/libmtd.h

$(STAGING_DIR)/usr/include/mtd/libmtd.h
- $(INSTALL) -D -m 0755 $(@D)/include/libubi.h
$(STAGING_DIR)/usr/include/mtd/libubi.h
+ $(INSTALL) -D -m 0755 $(@D)/include/libmtd.h
$(STAGING_DIR)/usr/include/libmtd.h
+ $(INSTALL) -D -m 0755 $(@D)/include/libubi.h
$(STAGING_DIR)/usr/include/libubi.h

Quoted 4 lines
     $(INSTALL) -D -m 0755 $(@D)/include/mtd/ubi-media.h
$(STAGING_DIR)/usr/include/mtd/ubi-media.h
     $(INSTALL) -D -m 0755 $(@D)/libmtd.a $(STAGING_DIR)/usr/lib/libmtd.a
     $(INSTALL) -D -m 0755 $(@D)/libubi.a $(STAGING_DIR)/usr/lib/libubi.a

Your patch is badly line-wrapped by your e-mail client. Could you send your patches using git send-email ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#3 lore raw

PATCH 1/1 Fix swupdate build by installing mtd headers as expected

Quoted 3 lines

Which problem is this fixing ? Is there a build issue today ? We have had mtd + swupdate for quite some time. Why suddenly should we change this ?

Hello,

There is no issue with the current Buildroot. Swupdate-2019.11 expects MTD headers in /include/mtd folder, and swupdate-2020.4 expects MTD headers in /include folder. I upgraded my swupdate to 2020.4 and found that the MTD header installation must change. I tried sending PR to swupdate to include MTD headers in the original /include/mtd folder but they said it should change in buildroot. I don't know if other projects depend on the mtd headers. If other projects depend on the MTD headers then they might break with this patch unless they are aware of this change.

Quoted 52 lines · Thomas Petazzoni

Hello Thomas,

Thanks for your contribution!

Quoted 8 lines · On Fri, 10 Jul 2020 15:41:37 -0400 "Thomas W." <[email protected]>…

swupdate expects libmtd.h and libubi.h to be in the include folder and not in the mtd namespace.
(see also:
https://groups.google.com/forum/#!topic/swupdate/Apv_yRLmgzY
https://groups.google.com/forum/#!topic/swupdate/gd25RIPa00w
https://groups.google.com/forum/#!topic/swupdate/gei0Gc_5j8M)

Which problem is this fixing ? Is there a build issue today ? We have had mtd + swupdate for quite some time. Why suddenly should we change this ?

Quoted 16 lines
package/mtd/mtd.mk +0 -1
index 3477460200..76ede98879 100644
@@ -119,8 +119,8 @@ endef
 # Those libraries are not installed by "make install", but are needed
 # by other packages, such as swupdate.
 define MTD_INSTALL_LIBS
-    $(INSTALL) -D -m 0755 $(@D)/include/libmtd.h

$(STAGING_DIR)/usr/include/mtd/libmtd.h
- $(INSTALL) -D -m 0755 $(@D)/include/libubi.h
$(STAGING_DIR)/usr/include/mtd/libubi.h
+ $(INSTALL) -D -m 0755 $(@D)/include/libmtd.h
$(STAGING_DIR)/usr/include/libmtd.h
+ $(INSTALL) -D -m 0755 $(@D)/include/libubi.h
$(STAGING_DIR)/usr/include/libubi.h

Quoted 4 lines
     $(INSTALL) -D -m 0755 $(@D)/include/mtd/ubi-media.h
$(STAGING_DIR)/usr/include/mtd/ubi-media.h
     $(INSTALL) -D -m 0755 $(@D)/libmtd.a $(STAGING_DIR)/usr/lib/libmtd.a
     $(INSTALL) -D -m 0755 $(@D)/libubi.a $(STAGING_DIR)/usr/lib/libubi.a

Your patch is badly line-wrapped by your e-mail client. Could you send your patches using git send-email ?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

author
#4 lore raw

PATCH 1/1 Fix swupdate build by installing mtd headers as expected

Quoted 2 lines

Your patch is badly line-wrapped by your e-mail client. Could you send your patches using git send-email ?

Sorry, I will try to send it again if you want to update swupdate (and it is found that other packages will not be broken with this patch).

Quoted 71 lines · Thomas W.
Quoted 4 lines

Which problem is this fixing ? Is there a build issue today ? We have had mtd + swupdate for quite some time. Why suddenly should we change this ?

Hello,

There is no issue with the current Buildroot. Swupdate-2019.11 expects MTD headers in /include/mtd folder, and swupdate-2020.4 expects MTD headers in /include folder. I upgraded my swupdate to 2020.4 and found that the MTD header installation must change. I tried sending PR to swupdate to include MTD headers in the original /include/mtd folder but they said it should change in buildroot. I don't know if other projects depend on the mtd headers. If other projects depend on the MTD headers then they might break with this patch unless they are aware of this change.

Quoted 52 lines · Thomas Petazzoni

Hello Thomas,

Thanks for your contribution!

Quoted 8 lines · On Fri, 10 Jul 2020 15:41:37 -0400 "Thomas W." <[email protected]>…

swupdate expects libmtd.h and libubi.h to be in the include folder and not in the mtd namespace.
(see also:
https://groups.google.com/forum/#!topic/swupdate/Apv_yRLmgzY
https://groups.google.com/forum/#!topic/swupdate/gd25RIPa00w
https://groups.google.com/forum/#!topic/swupdate/gei0Gc_5j8M)

Which problem is this fixing ? Is there a build issue today ? We have had mtd + swupdate for quite some time. Why suddenly should we change this ?

Quoted 16 lines
package/mtd/mtd.mk +0 -1
index 3477460200..76ede98879 100644
@@ -119,8 +119,8 @@ endef
 # Those libraries are not installed by "make install", but are needed
 # by other packages, such as swupdate.
 define MTD_INSTALL_LIBS
-    $(INSTALL) -D -m 0755 $(@D)/include/libmtd.h

$(STAGING_DIR)/usr/include/mtd/libmtd.h
- $(INSTALL) -D -m 0755 $(@D)/include/libubi.h
$(STAGING_DIR)/usr/include/mtd/libubi.h
+ $(INSTALL) -D -m 0755 $(@D)/include/libmtd.h
$(STAGING_DIR)/usr/include/libmtd.h
+ $(INSTALL) -D -m 0755 $(@D)/include/libubi.h
$(STAGING_DIR)/usr/include/libubi.h

Quoted 4 lines
     $(INSTALL) -D -m 0755 $(@D)/include/mtd/ubi-media.h
$(STAGING_DIR)/usr/include/mtd/ubi-media.h
     $(INSTALL) -D -m 0755 $(@D)/libmtd.a $(STAGING_DIR)/usr/lib/libmtd.a
     $(INSTALL) -D -m 0755 $(@D)/libubi.a $(STAGING_DIR)/usr/lib/libubi.a

Your patch is badly line-wrapped by your e-mail client. Could you send your patches using git send-email ?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com