drm/bridge: sil_sii8620: initialize return of sii8620_readb
Subsystems (4)
PATCH 1/1 drm/bridge: sil_sii8620: initialize return of sii8620_readb
From: Tom Rix <[email protected]>
clang static analysis flags this error
sil-sii8620.c:184:2: warning: Undefined or garbage value
returned to caller [core.uninitialized.UndefReturn]
return ret;
^~~~~~~~~~sii8620_readb calls sii8620_read_buf. sii8620_read_buf can return without setting its output pararmeter 'ret'.
So initialize ret.
--- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/sil-sii8620.c +1 -1
@@ -178,7 +178,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len)static u8 sii8620_readb (struct sii8620 *ctx,u16 addr) { -u8 ret; +u8 ret =0 ;sii8620_read_buf (ctx, addr, &ret,1 );return ret;
Signature · 1 line
2.18.1
Hi Tom,
Thank you for the patch.
Quoted 13 lines · On Sun, Jul 12, 2020 at 08:24:53AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
clang static analysis flags this error
sil-sii8620.c:184:2: warning: Undefined or garbage value
returned to caller [core.uninitialized.UndefReturn]return ret; ^~~~~~~~~~
sii8620_readbcallssii8620_read_buf.sii8620_read_bufcan return without setting its output pararmeter 'ret'.
Quoted 5 lines
So initialize ret.
Fixes ce6e153f414a ("drm/bridge: add Silicon Image SiI8620 driver")Signed-off-by Tom Rix <[email protected]>
Quoted 17 lines
--- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/sil-sii8620.c +1
-1@@ -178,7 +178,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len)static u8 sii8620_readb (struct sii8620 *ctx,u16 addr) { -u8 ret; +u8 ret =0 ;sii8620_read_buf (ctx, addr, &ret,1 );return ret;
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 27 lines · On 12.07.2020 17:24, [email protected] wrote:
From: Tom Rix <[email protected]>
clang static analysis flags this error
sil-sii8620.c:184:2: warning: Undefined or garbage value
returned to caller [core.uninitialized.UndefReturn]return ret; ^~~~~~~~~~
sii8620_readbcallssii8620_read_buf.sii8620_read_bufcan return without setting its output pararmeter 'ret'.So initialize ret.
Fixes ce6e153f414a ("drm/bridge: add Silicon Image SiI8620 driver")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/sil-sii8620.c +0
-0
drivers/gpu/drm/bridge/sil-sii8620.c static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len) · line 181
Quoted 5 lines
drivers/gpu/drm/bridge/sil-sii8620.c +1
-1@@ -178,7 +178,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len)static u8 sii8620_readb (struct sii8620 *ctx,u16 addr) { -u8 ret; +u8 ret =0 ;
In theory it shouldn't cause any harm, but this protections makes things simpler.
Regards
Andrzej
Quoted 3 lines
drivers/gpu/drm/bridge/sil-sii8620.c +0
-0sii8620_read_buf (ctx, addr, &ret,1 );return ret;
Hi Tom.
Quoted 13 lines · On Sun, Jul 12, 2020 at 08:24:53AM -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
clang static analysis flags this error
sil-sii8620.c:184:2: warning: Undefined or garbage value
returned to caller [core.uninitialized.UndefReturn]return ret; ^~~~~~~~~~
sii8620_readbcallssii8620_read_buf.sii8620_read_bufcan return without setting its output pararmeter 'ret'.
Quoted 5 lines
So initialize ret.
Fixes ce6e153f414a ("drm/bridge: add Silicon Image SiI8620 driver")Signed-off-by Tom Rix <[email protected]>
Thnaks, applied to drm-misc-next as the fix is not urgent.
Sam
Quoted 24 lines
--- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/bridge/sil-sii8620.c +1
-1@@ -178,7 +178,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len)static u8 sii8620_readb (struct sii8620 *ctx,u16 addr) { -u8 ret; +u8 ret =0 ;sii8620_read_buf (ctx, addr, &ret,1 );return ret;Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel