Skip to contentSkip to conversation

cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION

PATCH New Jagan Teki 3 participants 4 messages Jul 12, 2020 – Aug 6, 2020

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION

SPI_FLASH_PROTECTION config item is never used in anywhere in the U-Boot tree.

Drop it.

---
 cmd/mvebu/bubt.c | 7 -------
 1 file changed, 7 deletions(-)
cmd/mvebu/bubt.c +0 -7
index a27b0df8ae..b3b5844267 100644
@@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
 		return -ENOMEDIUM;
 	}
 
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-	spi_flash_protect(flash, 0);
-#endif
 	erase_bytes = image_size +
 		(flash->erase_size - image_size % flash->erase_size);
 	printf("Erasing %d bytes (%d blocks) at offset 0 ...",
@@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
 	else
 		printf("Done!\n");
 
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-	spi_flash_protect(flash, 1);
-#endif
-
 	return ret;
 }
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION

Quoted 25 lines · Jagan Teki

SPI_FLASH_PROTECTION config item is never used in anywhere in the U-Boot tree.

Drop it.

---
 cmd/mvebu/bubt.c | 7 -------
 1 file changed, 7 deletions(-)
cmd/mvebu/bubt.c +0 -3
index a27b0df8ae..b3b5844267 100644
@@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
 		return -ENOMEDIUM;
 	}
 
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-	spi_flash_protect(flash, 0);
-#endif
 	erase_bytes = image_size +
 		(flash->erase_size - image_size % flash->erase_size);
 	printf("Erasing %d bytes (%d blocks) at offset 0 ...",

cmd/mvebu/bubt.c static int spi_burn_image(size_t image_size) · line 321

Quoted 9 lines
cmd/mvebu/bubt.c +0 -4
@@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
 	else
 		printf("Done!\n");
 
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-	spi_flash_protect(flash, 1);
-#endif
-
 	return ret;
 }

Add maintainers.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200712/3480d5cb/attachment.sig>
#2 lore raw

PATCH 1/1 cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION

In reply to Jagan Teki
Quoted 6 lines · Jagan Teki

SPI_FLASH_PROTECTION config item is never used in anywhere in the U-Boot tree.

Drop it.

Thanks,
Stefan

Quoted 20 lines
---
  cmd/mvebu/bubt.c | 7 -------
  1 file changed, 7 deletions(-)
cmd/mvebu/bubt.c +0 -3
index a27b0df8ae..b3b5844267 100644
@@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
  		return -ENOMEDIUM;
  	}
 
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-	spi_flash_protect(flash, 0);
-#endif
  	erase_bytes = image_size +
  		(flash->erase_size - image_size % flash->erase_size);
  	printf("Erasing %d bytes (%d blocks) at offset 0 ...",

cmd/mvebu/bubt.c static int spi_burn_image(size_t image_size) · line 322

Quoted 10 lines
cmd/mvebu/bubt.c +0 -4
@@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)
  	else
  		printf("Done!\n");
 
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-	spi_flash_protect(flash, 1);
-#endif
-
  	return ret;
  }
 

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
#3 lore raw

PATCH 1/1 cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION

Quoted 9 lines · Stefan Roese
Quoted 6 lines · Jagan Teki

SPI_FLASH_PROTECTION config item is never used in anywhere in the U-Boot tree.

Drop it.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 26 lines

Thanks,
Stefan

Quoted 23 lines

---
? cmd/mvebu/bubt.c | 7 -------
? 1 file changed, 7 deletions(-)

cmd/mvebu/bubt.c +0 -3
index a27b0df8ae..b3b5844267 100644
@@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size)
 ????????? return -ENOMEDIUM;
 ????? }
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-??? spi_flash_protect(flash, 0);
-#endif

????? erase_bytes = image_size +
????????? (flash->erase_size - image_size % flash->erase_size); ????? printf("Erasing %d bytes (%d blocks) at offset 0 ...",

cmd/mvebu/bubt.c +0 -0
@@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size)

????? else
????????? printf("Done!\n");

cmd/mvebu/bubt.c +0 -3
-#ifdef CONFIG_SPI_FLASH_PROTECTION
-??? spi_flash_protect(flash, 1);
-#endif
Quoted 9 lines
Quoted 4 lines

-
????? return ret;
? }

Viele Gr??e,
Stefan

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de