Skip to contentSkip to conversation

app/testpmd: fix display issue in flow query

PATCH In review Chenxu Di 4 participants 6 messages Jul 13, 2020 – Jul 14, 2020

lore
Share & tools
lore

Chenxu Di

author
#0 lore raw

PATCH 1/1 app/testpmd: fix display issue in flow query

This patch fix the error line break in the display info of flow query

Fixes bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
---
 app/test-pmd/config.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
app/test-pmd/config.c +4 -1
index fcbe6b6f7..7b254e484 100644
@@ -1425,7 +1425,10 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
 	if (rss_conf->queue_num == 0)
 		printf("none\n");
 	for (i = 0; i < rss_conf->queue_num; i++)
-		printf("%d\n", rss_conf->queue[i]);
+		if (i == rss_conf->queue_num - 1)
+			printf("%d\n", rss_conf->queue[i]);
+		else
+			printf("%d ", rss_conf->queue[i]);
 
 	printf(" function: ");
 	switch (rss_conf->func) {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 27 lines · Chenxu Di

This patch fix the error line break in the display info of flow query

Fixes bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
---
 app/test-pmd/config.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
app/test-pmd/config.c +4 -2
index fcbe6b6f7..7b254e484 100644
@@ -1425,7 +1425,10 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
        if (rss_conf->queue_num == 0)
                printf("none\n");
        for (i = 0; i < rss_conf->queue_num; i++)
-               printf("%d\n", rss_conf->queue[i]);
+               if (i == rss_conf->queue_num - 1)
+                       printf("%d\n", rss_conf->queue[i]);
+               else
+                       printf("%d ", rss_conf->queue[i]);
 
        printf(" function: ");
        switch (rss_conf->func) {
--
Quoted 2 lines

2.17.1

What do you think of this (untested) alternative?

app/test-pmd/config.c +4 -3
index fcbe6b6f74..30bee33248 100644
@@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
        }
 
        printf("RSS:\n"
-              " queues: ");
+              " queues:");
        if (rss_conf->queue_num == 0)
-               printf("none\n");
+               printf(" none");
        for (i = 0; i < rss_conf->queue_num; i++)
-               printf("%d\n", rss_conf->queue[i]);
+               printf(" %d", rss_conf->queue[i]);
+       printf("\n");
 
 
 
        printf(" function: ");
        switch (rss_conf->func) {
Signature · 1 line
David Marchand
#2 lore raw

Ok, it looks better.
I will update it soon.

Quoted 69 lines

-----Original Message-----
From: David Marchand [mailto:[email protected]]
Sent: Monday, July 13, 2020 4:16 PM
To: Di, ChenxuX <[email protected]>
Cc: dev <[email protected]>; Xing, Beilei <[email protected]>; Lu, Wenzhuo <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix display issue in flow query

app/test-pmd/config.c rss_config_display(struct rte_flow_action_rss

Quoted 15 lines · Chenxu Di

This patch fix the error line break in the display info of flow query

Fixes bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
---
 app/test-pmd/config.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
app/test-pmd/config.c index renamed from app/test-pmd/config.c +0 -0

fcbe6b6f7..7b254e484 100644

app/test-pmd/config.c +0 -0
@@ -1425,7 +1425,10 @@ rss_config_display(struct rte_flow_action_rss

*rss_conf)

Quoted 12 lines
app/test-pmd/config.c +4 -2
        if (rss_conf->queue_num == 0)
                printf("none\n");
        for (i = 0; i < rss_conf->queue_num; i++)
-               printf("%d\n", rss_conf->queue[i]);
+               if (i == rss_conf->queue_num - 1)
+                       printf("%d\n", rss_conf->queue[i]);
+               else
+                       printf("%d ", rss_conf->queue[i]);
 
        printf(" function: ");
        switch (rss_conf->func) {
--
Quoted 2 lines

2.17.1

What do you think of this (untested) alternative?

app/test-pmd/config.c index renamed from app/test-pmd/config.c +0 -0

fcbe6b6f74..30bee33248 100644

app/test-pmd/config.c +4 -3
@@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss
 *rss_conf)
        }
 
        printf("RSS:\n"
-              " queues: ");
+              " queues:");
        if (rss_conf->queue_num == 0)
-               printf("none\n");
+               printf(" none");
        for (i = 0; i < rss_conf->queue_num; i++)
-               printf("%d\n", rss_conf->queue[i]);
+               printf(" %d", rss_conf->queue[i]);
+       printf("\n");
 
 
        printf(" function: ");
        switch (rss_conf->func) {

--
David Marchand

author
#3 lore raw

PATCH v2 1/1 app/testpmd: fix incorrect output format in flow query

In reply to Chenxu Di

This patch fix the error line break in the output format of flow query

Fixes bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
---
 app/test-pmd/config.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
app/test-pmd/config.c +4 -3
index fcbe6b6f7..30bee3324 100644
@@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
 	}
 
 	printf("RSS:\n"
-	       " queues: ");
+	       " queues:");
 	if (rss_conf->queue_num == 0)
-		printf("none\n");
+		printf(" none");
 	for (i = 0; i < rss_conf->queue_num; i++)
-		printf("%d\n", rss_conf->queue[i]);
+		printf(" %d", rss_conf->queue[i]);
+	printf("\n");
 
 	printf(" function: ");
 	switch (rss_conf->func) {
Signature · 1 line
2.17.1
Tested-by on v2 1/1
#4 lore raw

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in flow query

Quoted 9 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Chenxu Di
Sent: Tuesday, July 14, 2020 9:37 AM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; Chenxu Di <[email protected]>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in flow query

Quoted 5 lines

This patch fix the error line break in the output format of flow query

Fixes bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
Quoted 27 lines
---
 app/test-pmd/config.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
app/test-pmd/config.c +4 -3
index fcbe6b6f7..30bee3324 100644
@@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss
 *rss_conf)
 	}
 
 	printf("RSS:\n"
-	       " queues: ");
+	       " queues:");
 	if (rss_conf->queue_num == 0)
-		printf("none\n");
+		printf(" none");
 	for (i = 0; i < rss_conf->queue_num; i++)
-		printf("%d\n", rss_conf->queue[i]);
+		printf(" %d", rss_conf->queue[i]);
+	printf("\n");
 
 	printf(" function: ");

switch (rss_conf->func) {
--
2.17.1

Reviewed-by
#5 lore raw

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in flow query

Quoted 9 lines · Phil Yang
Quoted 9 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Chenxu Di
Sent: Tuesday, July 14, 2020 9:37 AM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; Chenxu Di <[email protected]>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in flow query

Quoted 9 lines
Quoted 5 lines

This patch fix the error line break in the output format of flow query

Fixes bdb1d61690f7 ("app/testpmd: support RSS config in flow query")