Skip to contentSkip to conversation

Staging: vc04_services: Fix code indent error

PATCH In review Baidyanath Kundu 3 participants 3 messages Jul 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: vc04_services: Fix code indent error

This patch fixes the checkpatch.pl error:

ERROR: code indent should use tabs where possible

---
 .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +7 -7
index a075cd63da7f..86c00b68f099 100644
@@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
 	/* queue the bulk submission */
 	vchiq_use_service(instance->service_handle);
 	ret = vchiq_bulk_receive(instance->service_handle,
-				 msg_context->u.bulk.buffer->buffer,
-			         /* Actual receive needs to be a multiple
-			          * of 4 bytes
-			          */
-			         (len + 3) & ~3,
-			         msg_context,
-			         VCHIQ_BULK_MODE_CALLBACK);
+				msg_context->u.bulk.buffer->buffer,
+				/* Actual receive needs to be a multiple
+				 * of 4 bytes
+				 */
+				(len + 3) & ~3,
+				msg_context,
+				VCHIQ_BULK_MODE_CALLBACK);
 
 	vchiq_release_service(instance->service_handle);
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 21 lines · Baidyanath Kundu

This patch fixes the checkpatch.pl error:

ERROR: code indent should use tabs where possible

---
 .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +0 -4
index a075cd63da7f..86c00b68f099 100644
@@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
 	/* queue the bulk submission */
 	vchiq_use_service(instance->service_handle);
 	ret = vchiq_bulk_receive(instance->service_handle,
-				 msg_context->u.bulk.buffer->buffer,
-			         /* Actual receive needs to be a multiple
-			          * of 4 bytes
-			          */

drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c static void buffer_to_host_work_cb(struct work_struct *work) · line 303

Quoted 10 lines
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +7 -3
-			         (len + 3) & ~3,
-			         msg_context,
-			         VCHIQ_BULK_MODE_CALLBACK);
+				msg_context->u.bulk.buffer->buffer,
+				/* Actual receive needs to be a multiple
+				 * of 4 bytes
+				 */
+				(len + 3) & ~3,
+				msg_context,
+				VCHIQ_BULK_MODE_CALLBACK);

Close, you need one more space for these lines, right?

thanks,

greg k-h

#2 lore raw
Quoted 26 lines · Greg Kroah-Hartman
Quoted 25 lines · Baidyanath Kundu

This patch fixes the checkpatch.pl error:

ERROR: code indent should use tabs where possible

---
 .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +1 -7
index a075cd63da7f..86c00b68f099 100644
@@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
 	/* queue the bulk submission */
 	vchiq_use_service(instance->service_handle);
 	ret = vchiq_bulk_receive(instance->service_handle,
-				 msg_context->u.bulk.buffer->buffer,
-			         /* Actual receive needs to be a multiple
-			          * of 4 bytes
-			          */
-			         (len + 3) & ~3,
-			         msg_context,
-			         VCHIQ_BULK_MODE_CALLBACK);
+				msg_context->u.bulk.buffer->buffer,
Quoted 9 lines

drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c static void buffer_to_host_work_cb(struct work_struct *work) · line 303

Quoted 6 lines
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +6 -0
+				/* Actual receive needs to be a multiple
+				 * of 4 bytes
+				 */
+				(len + 3) & ~3,
+				msg_context,
+				VCHIQ_BULK_MODE_CALLBACK);

Close, you need one more space for these lines, right?

Yeah. The original has the space and looks correct.

regards,
dan carpenter