common/qat: support GEN2 device C34xx
PATCH 1/1 common/qat: support GEN2 device C34xx
This adds pci detection and documentation for Intel GEN2 QuickAssist device C34xx (PF Did 0x18ee, VF Did 0x18ef).
--- doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++++++-- doc/guides/rel_notes/release_20_08.rst | 5 +++++ drivers/common/qat/qat_device.c | 6 +++++- 4 files changed, 18 insertions(+), 4 deletions(-)
doc/guides/compressdevs/qat_comp.rst +2 -1
@@ -1,5 +1,5 @@ .. SPDX-License-Identifier: BSD-3-Clause - Copyright(c) 2018 Intel Corporation. + Copyright(c) 2018-2020 Intel Corporation. Intel(R) QuickAssist (QAT) Compression Poll Mode Driver =======================================================
@@ -9,6 +9,7 @@ support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology C34xx`` * ``Intel QuickAssist Technology DH895x``
doc/guides/cryptodevs/qat.rst +6 -2
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology C34xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology P5xxx``
@@ -154,6 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology C34xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology P5xxx``
@@ -383,6 +385,8 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | Yes | Yes | " | " | 01.org/4.2.0+ | " | " | " | " | " | " | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ + | Yes | Yes | Yes | 2 | C34xx | p | qat_c34xx | c34xx | 18ee | 1 | 18ef | 16 | + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | p | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 3 | P5xxx | p | qat_p5xxx | p5xxx | 18a0 | 1 | 18a1 | 128 |
@@ -609,8 +613,8 @@ adjust the unbind command below:: done; \ done -For Intel(R) QuickAssist Technology C3xxx or D15xx device -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +For Intel(R) QuickAssist Technology C3xxx or C34xx or D15xx device +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your VFs are different adjust the unbind command below::
doc/guides/rel_notes/release_20_08.rst +5 -0
@@ -56,6 +56,11 @@ New Features Also, make sure to start the actual text at the margin. ========================================================= +* **Added support for GEN2 device C34xx to Intel QAT driver.** + + Added support for Intel GEN2 QuickAssist device C34xx + (PF Did 0x18ee, VF Did 0x18ef). + Removed Items -------------
drivers/common/qat/qat_device.c +5 -1
@@ -1,5 +1,5 @@/* SPDX-License-Identifier: BSD-3-Clause -* Copyright(c) 2018 Intel Corporation +* Copyright(c) 2018-2020 Intel Corporation */ #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = { {RTE_PCI_DEVICE (0x8086 ,0x6f55 ), }, + { +RTE_PCI_DEVICE (0x8086 ,0x18ef ), + }, { RTE_PCI_DEVICE(0x8086, 0x18a1), },
@@ -199,6 +202,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,case 0x37c9 :case 0x19e3 :case 0x6f55 : +case 0x18ef : qat_dev->qat_dev_gen =QAT_GEN2 ;break ;case 0x18a1 :
Signature · 1 line
2.25.1
v2 cover common/qat: support GEN2 QAT device 200xx
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
--
v2:
* update the marketing name
Adam Dybkowski (1):
common/qat: support GEN2 QAT device 200xx
doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++++++-- doc/guides/rel_notes/release_20_08.rst | 5 +++++ drivers/common/qat/qat_device.c | 6 +++++- 4 files changed, 18 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/1 common/qat: support GEN2 QAT device 200xx
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
--- doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++++++-- doc/guides/rel_notes/release_20_08.rst | 5 +++++ drivers/common/qat/qat_device.c | 6 +++++- 4 files changed, 18 insertions(+), 4 deletions(-)
doc/guides/compressdevs/qat_comp.rst +2 -1
@@ -1,5 +1,5 @@ .. SPDX-License-Identifier: BSD-3-Clause - Copyright(c) 2018 Intel Corporation. + Copyright(c) 2018-2020 Intel Corporation. Intel(R) QuickAssist (QAT) Compression Poll Mode Driver =======================================================
@@ -9,6 +9,7 @@ support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology DH895x``
doc/guides/cryptodevs/qat.rst +6 -2
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology P5xxx``
@@ -162,6 +163,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology P5xxx``
@@ -391,6 +393,8 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | Yes | Yes | " | " | 01.org/4.2.0+ | " | " | " | " | " | " | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ + | Yes | Yes | Yes | 2 | 200xx | p | qat_200xx | 200xx | 18ee | 1 | 18ef | 16 | + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | p | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 3 | P5xxx | p | qat_p5xxx | p5xxx | 18a0 | 1 | 18a1 | 128 |
@@ -617,8 +621,8 @@ adjust the unbind command below:: done; \ done -For Intel(R) QuickAssist Technology C3xxx or D15xx device -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your VFs are different adjust the unbind command below::
doc/guides/rel_notes/release_20_08.rst +5 -0
@@ -225,6 +225,11 @@ New Features See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more details of this parameter usage. +* **Added support for GEN2 device 200xx to Intel QAT driver.** + + Added support for Intel GEN2 QuickAssist device 200xx + (PF Did 0x18ee, VF Did 0x18ef). + Removed Items -------------
drivers/common/qat/qat_device.c +5 -1
@@ -1,5 +1,5 @@/* SPDX-License-Identifier: BSD-3-Clause -* Copyright(c) 2018 Intel Corporation +* Copyright(c) 2018-2020 Intel Corporation */ #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = { {RTE_PCI_DEVICE (0x8086 ,0x6f55 ), }, + { +RTE_PCI_DEVICE (0x8086 ,0x18ef ), + }, { RTE_PCI_DEVICE(0x8086, 0x18a1), },
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,case 0x37c9 :case 0x19e3 :case 0x6f55 : +case 0x18ef : qat_dev->qat_dev_gen =QAT_GEN2 ;break ;case 0x18a1 :
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 1/1] common/qat: support GEN2 QAT device 200xx
Hi Adam,
Quoted 60 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Monday, July 13, 2020 12:10 PM
To: Trahe, Fiona <[email protected]>; [email protected]; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH v2 1/1] common/qat: support GEN2 QAT device 200xxThis adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did
0x18ee, VF Did0x18ef).Signed-off-by Adam Dybkowski <[email protected]>--- doc/guides/compressdevs/qat_comp.rst | 3 ++- doc/guides/cryptodevs/qat.rst | 8 ++++++-- doc/guides/rel_notes/release_20_08.rst | 5 +++++ drivers/common/qat/qat_device.c | 6 +++++- 4 files changed, 18 insertions(+), 4 deletions(-)doc/guides/compressdevs/qat_comp.rst +2
-1@@ -1,5 +1,5 @@ .. SPDX-License-Identifier: BSD-3-Clause - Copyright(c) 2018 Intel Corporation. + Copyright(c) 2018-2020 Intel Corporation. Intel(R) QuickAssist (QAT) Compression Poll Mode Driver =======================================================@@ -9,6 +9,7 @@ support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology DH895x``doc/guides/cryptodevs/qat.rst +2
-0@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology P5xxx``@@ -162,6 +163,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology P5xxx``
doc/guides/cryptodevs/qat.rst to see the full table) · line 397
Quoted 5 lines
doc/guides/cryptodevs/qat.rst +2
-0@@ -391,6 +393,8 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | Yes | Yes | " | " | 01.org/4.2.0+ | " | " | " | " | " | " | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ + | Yes | Yes | Yes | 2 | 200xx | p | qat_200xx | 200xx | 18ee | 1 | 18ef | 16 | + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
[Fiona] For 20.08 this device should only be enabled for sym crypto - the rest will be enabled later.
v3 cover common/qat: support GEN2 QAT device 200xx
In reply to Adam DybkowskiThis adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
Adam Dybkowski (2):
common/qat: support GEN2 QAT device 200xx
doc: update QAT PMD release notes
doc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 12 +++++++++++- drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 21 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
PATCH v3 1/2 common/qat: support GEN2 QAT device 200xx
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
--- doc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 2 ++ drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 12 insertions(+), 3 deletions(-)
doc/guides/cryptodevs/qat.rst +5 -2
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology C4xxx``
@@ -391,6 +392,8 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | Yes | Yes | " | " | 01.org/4.2.0+ | " | " | " | " | " | " | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ + | Yes | No | No | 2 | 200xx | p | qat_200xx | 200xx | 18ee | 1 | 18ef | 16 | + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | p | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 3 | C4xxx | p | qat_c4xxx | c4xxx | 18a0 | 1 | 18a1 | 128 |
@@ -617,8 +620,8 @@ adjust the unbind command below:: done; \ done -For Intel(R) QuickAssist Technology C3xxx or D15xx device -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your VFs are different adjust the unbind command below::
doc/guides/rel_notes/release_20_08.rst +2 -0
@@ -191,6 +191,8 @@ New Features ``rte_security`` API. * Added Chacha20-Poly1305 AEAD algorithm. * Improved handling of multi process in QAT crypto and compression PMDs. + * Added support for Intel GEN2 QuickAssist device 200xx + (PF Did 0x18ee, VF Did 0x18ef). * **Updated the OCTEON TX2 crypto PMD.**
drivers/common/qat/qat_device.c +5 -1
@@ -1,5 +1,5 @@/* SPDX-License-Identifier: BSD-3-Clause -* Copyright(c) 2018 Intel Corporation +* Copyright(c) 2018-2020 Intel Corporation */ #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = { {RTE_PCI_DEVICE (0x8086 ,0x6f55 ), }, + { +RTE_PCI_DEVICE (0x8086 ,0x18ef ), + }, { RTE_PCI_DEVICE(0x8086, 0x18a1), },
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,case 0x37c9 :case 0x19e3 :case 0x6f55 : +case 0x18ef : qat_dev->qat_dev_gen =QAT_GEN2 ;break ;case 0x18a1 :
Signature · 1 line
2.25.1
PATCH v3 2/2 doc: update QAT PMD release notes
In reply to Adam DybkowskiThis patch separates QAT PMD paragraphs in the release notes into three parts, for QAT Symmetric Crypto PMD, QAT Asymmetric Crypto PMD and QAT Compression PMD.
--- doc/guides/rel_notes/release_20_08.rst | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
doc/guides/rel_notes/release_20_08.rst +9 -1
@@ -185,7 +185,7 @@ New Features Added support for lookaside protocol offload for DOCSIS through the ``rte_security`` API. -* **Updated the QuickAssist Technology (QAT) PMD.** +* **Updated the QuickAssist Technology (QAT) Symmetric Crypto PMD.** * Added support for lookaside protocol offload for DOCSIS through the ``rte_security`` API.
@@ -194,6 +194,14 @@ New Features * Added support for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef). +* **Updated the QuickAssist Technology (QAT) Asymmetric Crypto PMD.** + + * Improved handling of multi process in QAT crypto and compression PMDs. + +* **Updated the QuickAssist Technology (QAT) Compression PMD.** + + * Improved handling of multi process in QAT crypto and compression PMDs. + * **Updated the OCTEON TX2 crypto PMD.** Added Chacha20-Poly1305 AEAD algorithm support in OCTEON TX2 crypto PMD.
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3 2/2] doc: update QAT PMD release notes
Hi Adam,
Quoted 26 lines
This patch separates QAT PMD paragraphs in the release notes into three parts, for QAT Symmetric Crypto PMD, QAT Asymmetric Crypto PMD and QAT Compression PMD.
Signed-off-by Adam Dybkowski <[email protected]>--- doc/guides/rel_notes/release_20_08.rst | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)doc/guides/rel_notes/release_20_08.rst +1
-1@@ -185,7 +185,7 @@ New Features Added support for lookaside protocol offload for DOCSIS through the ``rte_security`` API. -* **Updated the QuickAssist Technology (QAT) PMD.** +* **Updated the QuickAssist Technology (QAT) Symmetric Crypto PMD.** * Added support for lookaside protocol offload for DOCSIS through the ``rte_security`` API.@@ -194,6 +194,14 @@ New Features * Added support for Intel GEN2 QuickAssist device 200xx
doc/guides/rel_notes/release_20_08.rst New Features · line 204
Quoted 10 lines
doc/guides/rel_notes/release_20_08.rst +8
-0(PF Did 0x18ee, VF Did 0x18ef). +* **Updated the QuickAssist Technology (QAT) Asymmetric Crypto PMD.** + + * Improved handling of multi process in QAT crypto and compression PMDs. + +* **Updated the QuickAssist Technology (QAT) Compression PMD.** + + * Improved handling of multi process in QAT crypto and compression PMDs. +
I don't think these changes are required.
It is already updated as a bullet in QAT release notes for both crypto and compression PMD. And I believe you do not need to sym and asym separately in the release notes.
v4 cover common/qat: support GEN2 QAT device 200xx
In reply to Adam DybkowskiThis adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
v2:
* rename the device
v3:
* improve release notes
v4:
* simplify release notes
Adam Dybkowski (1):
common/qat: support GEN2 QAT device 200xx
doc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 8 +++++--- drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 15 insertions(+), 6 deletions(-)
Signature · 1 line
2.25.1
PATCH v4 1/1 common/qat: support GEN2 QAT device 200xx
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
--- doc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 8 +++++--- drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 15 insertions(+), 6 deletions(-)
doc/guides/cryptodevs/qat.rst +5 -2
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology C4xxx``
@@ -393,6 +394,8 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | Yes | Yes | " | " | 01.org/4.2.0+ | " | " | " | " | " | " | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ + | Yes | No | No | 2 | 200xx | p | qat_200xx | 200xx | 18ee | 1 | 18ef | 16 | + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | 01.org/4.2.0+ | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 3 | C4xxx | p | qat_c4xxx | c4xxx | 18a0 | 1 | 18a1 | 128 |
@@ -619,8 +622,8 @@ adjust the unbind command below:: done; \ done -For Intel(R) QuickAssist Technology C3xxx or D15xx device -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your VFs are different adjust the unbind command below::
doc/guides/rel_notes/release_20_08.rst +5 -3
@@ -187,10 +187,12 @@ New Features * **Updated the QuickAssist Technology (QAT) PMD.** - * Added support for lookaside protocol offload for DOCSIS through the - ``rte_security`` API. - * Added Chacha20-Poly1305 AEAD algorithm. + * Added support for lookaside protocol offload in QAT crypto PMD + for DOCSIS through the ``rte_security`` API. + * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD. * Improved handling of multi process in QAT crypto and compression PMDs. + * Added support for Intel GEN2 QuickAssist device 200xx + (PF Did 0x18ee, VF Did 0x18ef). * **Updated the OCTEON TX2 crypto PMD.**
drivers/common/qat/qat_device.c +5 -1
@@ -1,5 +1,5 @@/* SPDX-License-Identifier: BSD-3-Clause -* Copyright(c) 2018 Intel Corporation +* Copyright(c) 2018-2020 Intel Corporation */ #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = { {RTE_PCI_DEVICE (0x8086 ,0x6f55 ), }, + { +RTE_PCI_DEVICE (0x8086 ,0x18ef ), + }, { RTE_PCI_DEVICE(0x8086, 0x18a1), },
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,case 0x37c9 :case 0x19e3 :case 0x6f55 : +case 0x18ef : qat_dev->qat_dev_gen =QAT_GEN2 ;break ;case 0x18a1 :
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx
Quoted 9 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Wednesday, July 22, 2020 9:07 AM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx
Quoted 4 lines
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did
0x18ee, VF Did0x18ef).Signed-off-by Adam Dybkowski <[email protected]>
Re: [dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx
In reply to Adam DybkowskiHi Adam,
Quoted 8 lines
doc/guides/rel_notes/release_20_08.rst +0
-0@@ -187,10 +187,12 @@ New Features * **Updated the QuickAssist Technology (QAT) PMD.**
doc/guides/rel_notes/release_20_08.rst New Features · line 195
Quoted 10 lines
doc/guides/rel_notes/release_20_08.rst +5
-3- * Added support for lookaside protocol offload for DOCSIS through the - ``rte_security`` API. - * Added Chacha20-Poly1305 AEAD algorithm. + * Added support for lookaside protocol offload in QAT crypto PMD + for DOCSIS through the ``rte_security`` API. + * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD. * Improved handling of multi process in QAT crypto and compression PMDs. + * Added support for Intel GEN2 QuickAssist device 200xx + (PF Did 0x18ee, VF Did 0x18ef).
Please split these release notes in 2 patches.
For " Added support for Intel GEN2 QuickAssist device 200xx ", it should be part of this patch.
And for other updates, add a new patch with Fixes tag to the original patch which introduced this change so that feature patch can be tracked from release notes using git blame.
v5 cover common/qat: support GEN2 QAT device 200xx
In reply to Adam DybkowskiThis adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
v2:
* rename the device
v3:
* improve release notes
v4:
* simplify release notes
v5:
* split actual implementation patch and additional release notes update
Adam Dybkowski (2):
common/qat: support GEN2 QAT device 200xx
doc: update QAT PMD release notes
doc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 8 +++++--- drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 15 insertions(+), 6 deletions(-)
Signature · 1 line
2.25.1
PATCH v5 1/2 common/qat: support GEN2 QAT device 200xx
This adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
--- doc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 2 ++ drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 12 insertions(+), 3 deletions(-)
doc/guides/cryptodevs/qat.rst +5 -2
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology DH895xCC`` * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` +* ``Intel QuickAssist Technology 200xx`` * ``Intel QuickAssist Technology D15xx`` * ``Intel QuickAssist Technology C4xxx``
@@ -393,6 +394,8 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | Yes | Yes | " | " | 01.org/4.2.0+ | " | " | " | " | " | " | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ + | Yes | No | No | 2 | 200xx | p | qat_200xx | 200xx | 18ee | 1 | 18ef | 16 | + +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | 01.org/4.2.0+ | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 3 | C4xxx | p | qat_c4xxx | c4xxx | 18a0 | 1 | 18a1 | 128 |
@@ -619,8 +622,8 @@ adjust the unbind command below:: done; \ done -For Intel(R) QuickAssist Technology C3xxx or D15xx device -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your VFs are different adjust the unbind command below::
doc/guides/rel_notes/release_20_08.rst +2 -0
@@ -200,6 +200,8 @@ New Features ``rte_security`` API. * Added Chacha20-Poly1305 AEAD algorithm. * Improved handling of multi process in QAT crypto and compression PMDs. + * Added support for Intel GEN2 QuickAssist device 200xx + (PF Did 0x18ee, VF Did 0x18ef). * **Updated the OCTEON TX2 crypto PMD.**
drivers/common/qat/qat_device.c +5 -1
@@ -1,5 +1,5 @@/* SPDX-License-Identifier: BSD-3-Clause -* Copyright(c) 2018 Intel Corporation +* Copyright(c) 2018-2020 Intel Corporation */ #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = { {RTE_PCI_DEVICE (0x8086 ,0x6f55 ), }, + { +RTE_PCI_DEVICE (0x8086 ,0x18ef ), + }, { RTE_PCI_DEVICE(0x8086, 0x18a1), },
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,case 0x37c9 :case 0x19e3 :case 0x6f55 : +case 0x18ef : qat_dev->qat_dev_gen =QAT_GEN2 ;break ;case 0x18a1 :
Signature · 1 line
2.25.1
PATCH v5 2/2 doc: update QAT PMD release notes
In reply to Adam DybkowskiThis patch updates 20.08 release notes inside the part that describe changes in Intel QuickAssist PMD.
--- doc/guides/rel_notes/release_20_08.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
doc/guides/rel_notes/release_20_08.rst +3 -3
@@ -196,9 +196,9 @@ New Features * **Updated the QuickAssist Technology (QAT) PMD.** - * Added support for lookaside protocol offload for DOCSIS through the - ``rte_security`` API. - * Added Chacha20-Poly1305 AEAD algorithm. + * Added support for lookaside protocol offload in QAT crypto PMD + for DOCSIS through the ``rte_security`` API. + * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD. * Improved handling of multi process in QAT crypto and compression PMDs. * Added support for Intel GEN2 QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v5 2/2] doc: update QAT PMD release notes
27/07/2020 12:14, Adam Dybkowski:
Quoted 17 lines
This patch updates 20.08 release notes inside the part that describe changes in Intel QuickAssist PMD.
Fixes faa57df0b458 ("crypto/qat: support ChaCha20-Poly1305")Fixes 9904ff684981 ("common/qat: improve multi-process handling")Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fiona Trahe <[email protected]>--- doc/guides/rel_notes/release_20_08.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)doc/guides/rel_notes/release_20_08.rst +0
-0
doc/guides/rel_notes/release_20_08.rst New Features · line 201
Quoted 9 lines
doc/guides/rel_notes/release_20_08.rst +3
-3@@ -196,9 +196,9 @@ New Features * **Updated the QuickAssist Technology (QAT) PMD.** - * Added support for lookaside protocol offload for DOCSIS through the - ``rte_security`` API. - * Added Chacha20-Poly1305 AEAD algorithm. + * Added support for lookaside protocol offload in QAT crypto PMD + for DOCSIS through the ``rte_security`` API. + * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD.
I don't see the need for this patch.
Isn't it obvious that DOCSIS and ChachaPoly are related to crypto? If you specify "QAT crypto PMD" or "QAT compress PMD" in each item of QAT features, it will become not pleasant to read.
Akhil Goyal
AppliedRe: [dpdk-dev] [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xx
In reply to Adam DybkowskiQuoted 21 lines
-----Original Message-----
From: Adam Dybkowski <[email protected]>
Sent: Monday, July 27, 2020 3:44 PM
To: [email protected]; [email protected]; Akhil Goyal <[email protected]>
Cc: Adam Dybkowski <[email protected]>
Subject: [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xxThis adds pci detection and documentation for Intel GEN2 QuickAssist device 200xx (PF Did
0x18ee, VF Did0x18ef).v2:
* rename the device
v3:
* improve release notes
v4:
* simplify release notes
v5:
* split actual implementation patch and additional release notes update
Quoted 9 lines
Adam Dybkowski (2):
common/qat: support GEN2 QAT device 200xx
doc: update QAT PMD release notesdoc/guides/cryptodevs/qat.rst | 7 +++++-- doc/guides/rel_notes/release_20_08.rst | 8 +++++--- drivers/common/qat/qat_device.c | 6 +++++- 3 files changed, 15 insertions(+), 6 deletions(-)
Applied to dpdk-next-crypto
Thanks.