compress/qat: revert change in GEN3 marketing name
PATCH 1/1 compress/qat: revert change in GEN3 marketing name
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
--- doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
doc/guides/cryptodevs/qat.rst +3 -3
@@ -23,7 +23,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` * ``Intel QuickAssist Technology D15xx`` -* ``Intel QuickAssist Technology P5xxx`` +* ``Intel QuickAssist Technology C4xxx`` Features
@@ -155,7 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` * ``Intel QuickAssist Technology D15xx`` -* ``Intel QuickAssist Technology P5xxx`` +* ``Intel QuickAssist Technology C4xxx`` The QAT ASYM PMD has support for:
@@ -385,7 +385,7 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | p | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ - | Yes | No | No | 3 | P5xxx | p | qat_p5xxx | p5xxx | 18a0 | 1 | 18a1 | 128 | + | Yes | No | No | 3 | C4xxx | p | qat_c4xxx | c4xxx | 18a0 | 1 | 18a1 | 128 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with 01.org driver version 4.9.0+
drivers/compress/qat/qat_comp_pmd.c +1 -1
@@ -656,7 +656,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev, {int i =0 ;if (qat_pci_dev->qat_dev_gen ==QAT_GEN3 ) { -QAT_LOG (ERR ,"Compression PMD not supported on QAT P5xxx" ); +QAT_LOG (ERR ,"Compression PMD not supported on QAT c4xxx" );return 0 ; }
Signature · 1 line
2.25.1
Quoted 9 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Monday, June 8, 2020 3:42 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
Quoted 3 lines
This reverts commit
9cd9d3e702fba4700539c1a2eddac13dd14ecf70.Signed-off-by Adam Dybkowski <[email protected]>
Hi Adam/Fiona,
Please mention a reason why this patch need to be reverted.
We cannot keep on changing a marketing name in every release.
If this patch is needed, then we should also queue it for stable backporting.
Regards,
Akhil
Quoted 12 lines
Quoted 4 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Monday, June 8, 2020 3:42 PM
To: [email protected]; Trahe, Fiona <[email protected]>;Quoted 6 lines
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] compress/qat: revert change in GEN3 marketing nameThis reverts commit
9cd9d3e702fba4700539c1a2eddac13dd14ecf70.Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fiona Trahe <[email protected]>
Akhil,
This doesn't have to be backported as the original patch was withdrawn from the stable before the release, thanks to Fiona's prompt action. That's why this commit revert patch affects only the dev branch.
Adam
Quoted 27 lines
-----Original Message-----
From: Akhil Goyal <[email protected]>
Sent: Wednesday, 24 June, 2020 16:50
To: Trahe, Fiona <[email protected]>; Dybkowski, AdamX <[email protected]>; [email protected]
Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing nameHi Adam/Fiona,
Please mention a reason why this patch need to be reverted.
We cannot keep on changing a marketing name in every release.
If this patch is needed, then we should also queue it for stable backporting.Regards,
AkhilQuoted 12 lines
Quoted 4 lines
-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Monday, June 8, 2020 3:42 PM
To: [email protected]; Trahe, Fiona <[email protected]>;Quoted 6 lines
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH] compress/qat: revert change in GEN3 marketing nameThis reverts commit
9cd9d3e702fba4700539c1a2eddac13dd14ecf70.Signed-off-by Adam Dybkowski <[email protected]>Acked-by Fiona Trahe <[email protected]>
Quoted 8 lines
Akhil,
This doesn't have to be backported as the original patch was withdrawn from the stable before the release, thanks to Fiona's prompt action. That's why this commit revert patch affects only the dev branch.
Ok send a v2 with proper description why this need to be reverted.
Hi Akhil,
Sorry about the confusion.
This was a simple internal miscommunication - there was a decision made to change the name, so we did promptly.
The decision was reversed pretty soon after due to an impact on other projects, but I was out-of-the loop on it - I just discovered it recently.
Do you still need a v2? I'm not sure how much of that is worth putting in a commit message.
Fiona
Quoted 17 lines
-----Original Message-----
From: Akhil Goyal <[email protected]>
Sent: Wednesday, June 24, 2020 3:55 PM
To: Dybkowski, AdamX <[email protected]>; Trahe, Fiona <[email protected]>; [email protected]
Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing nameQuoted 7 lines
Akhil,
This doesn't have to be backported as the original patch was withdrawn from the stable before the release, thanks to Fiona's prompt action. That's why this commit revert patch affects only the dev branch.
Ok send a v2 with proper description why this need to be reverted.
Hi Fiona,
Quoted 12 lines
Hi Akhil,
Sorry about the confusion.
This was a simple internal miscommunication - there was a decision made to change the name, so we did promptly.
The decision was reversed pretty soon after due to an impact on other projects, but I was out-of-the loop on it - I just discovered it recently.Do you still need a v2? I'm not sure how much of that is worth putting in a commit message.
We should not leave the description blank.
Probably it can be written that the marketing name was reverted back as it was Impacting other projects.
Or something of that sort.
Regards,
Akhil
v2 cover compress/qat: revert change in GEN3 marketing name
In reply to Adam DybkowskiThe patch reverts the commit that updated Intel QuickAssist GEN3 marketing name. The change was not backported and has to be withdrawn.
v2:
* add cover letter with more explanation
Adam Dybkowski (1):
compress/qat: revert change in GEN3 marketing name
doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/1 compress/qat: revert change in GEN3 marketing name
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
--- doc/guides/cryptodevs/qat.rst | 6 +++--- drivers/compress/qat/qat_comp_pmd.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
doc/guides/cryptodevs/qat.rst +3 -3
@@ -23,7 +23,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` * ``Intel QuickAssist Technology D15xx`` -* ``Intel QuickAssist Technology P5xxx`` +* ``Intel QuickAssist Technology C4xxx`` Features
@@ -155,7 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices: * ``Intel QuickAssist Technology C62x`` * ``Intel QuickAssist Technology C3xxx`` * ``Intel QuickAssist Technology D15xx`` -* ``Intel QuickAssist Technology P5xxx`` +* ``Intel QuickAssist Technology C4xxx`` The QAT ASYM PMD has support for:
@@ -385,7 +385,7 @@ to see the full table) +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ | Yes | No | No | 2 | D15xx | p | qat_d15xx | d15xx | 6f54 | 1 | 6f55 | 16 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ - | Yes | No | No | 3 | P5xxx | p | qat_p5xxx | p5xxx | 18a0 | 1 | 18a1 | 128 | + | Yes | No | No | 3 | C4xxx | p | qat_c4xxx | c4xxx | 18a0 | 1 | 18a1 | 128 | +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+ * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with 01.org driver version 4.9.0+
drivers/compress/qat/qat_comp_pmd.c +1 -1
@@ -656,7 +656,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev, {int i =0 ;if (qat_pci_dev->qat_dev_gen ==QAT_GEN3 ) { -QAT_LOG (ERR ,"Compression PMD not supported on QAT P5xxx" ); +QAT_LOG (ERR ,"Compression PMD not supported on QAT c4xxx" );return 0 ; }
Signature · 1 line
2.25.1
Akhil Goyal
AppliedQuoted 4 lines
This reverts commit
9cd9d3e702fba4700539c1a2eddac13dd14ecf70.Signed-off-by Adam Dybkowski <[email protected]>---
Applied to dpdk-next-crypto
Thanks.