ARM: dts: imx6q-tbs2910: Add an mdio node
Subsystems (2)
Fabio Estevam
reviewerPATCH v3 1/2 ARM: dts: imx6q-tbs2910: Add an mdio node
imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4.
The AR8035 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin.
Improve the Ethernet representation by adding an mdio node with such information.
This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now expects the 'qca,clk-out-frequency' property to be passed via device tree.
---
Changes since v2:
- None. Only reorded the patches.
arch/arm/boot/dts/imx6q-tbs2910.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx6q-tbs2910.dts +11 -0
@@ -100,7 +100,18 @@ pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + phy-handle = <&phy>; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + phy: ethernet-phy@4 { + reg = <4>; + qca,clk-out-frequency = <125000000>; + }; + }; }; &hdmi {
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerPATCH v3 2/2 ARM: dts: imx6q-tbs2910: Pass reset-assert-us
According to the AR8035 datasheet:
"When using crystal, the clock is generated internally after power is stable. For a reliable power on reset, suggest to keep asserting the reset low long enough (10ms) to ensure the clock is stable and clock-to-reset 1ms requirement is satisfied."
Pass the 'reset-assert-us' property to describe such requirement.
While at it, use the 'reset-gpios' property inside the the mdio node instead of the deprecated usage of 'phy-reset-gpios'.
---
Changes since v2:
- Use reset-gpios and reset-assert-us inside the mdio node instead of the deprecated usage of phy-reset-gpios (Soeren)
arch/arm/boot/dts/imx6q-tbs2910.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6q-tbs2910.dts +2 -1
@@ -99,7 +99,6 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; - phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; phy-handle = <&phy>; status = "okay";
@@ -110,6 +109,8 @@ phy: ethernet-phy@4 { reg = <4>; qca,clk-out-frequency = <125000000>; + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + reset-assert-us = <10000>; }; }; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v3 2/2] ARM: dts: imx6q-tbs2910: Pass reset-assert-us
Quoted 7 lines · Fabio Estevam
According to the AR8035 datasheet:
"When using crystal, the clock is generated internally after power is stable. For a reliable power on reset, suggest to keep asserting the reset low long enough (10ms) to ensure the clock is stable and clock-to-reset 1ms requirement is satisfied."
Quoted 6 lines
Pass the 'reset-assert-us' property to describe such requirement.
While at it, use the 'reset-gpios' property inside the the mdio node instead of the deprecated usage of 'phy-reset-gpios'.
Signed-off-by Fabio Estevam <[email protected]>
Thanks,
Soeren
Quoted 21 lines
---
Changes since v2:
- Use reset-gpios and reset-assert-us inside the mdio node instead of the deprecated usage of phy-reset-gpios (Soeren)arch/arm/boot/dts/imx6q-tbs2910.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm/boot/dts/imx6q-tbs2910.dts +0
-1@@ -99,7 +99,6 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; - phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; phy-handle = <&phy>; status = "okay";
arch/arm/boot/dts/imx6q-tbs2910.dts line 116
Quoted 8 lines
arch/arm/boot/dts/imx6q-tbs2910.dts +2
-0@@ -110,6 +109,8 @@ phy: ethernet-phy@4 { reg = <4>; qca,clk-out-frequency = <125000000>; + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + reset-assert-us = <10000>; }; }; };
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo
AppliedRe: [PATCH v3 2/2] ARM: dts: imx6q-tbs2910: Pass reset-assert-us
In reply to Fabio EstevamQuoted 7 lines · Fabio Estevam
According to the AR8035 datasheet:
"When using crystal, the clock is generated internally after power is stable. For a reliable power on reset, suggest to keep asserting the reset low long enough (10ms) to ensure the clock is stable and clock-to-reset 1ms requirement is satisfied."
Quoted 6 lines
Pass the 'reset-assert-us' property to describe such requirement.
While at it, use the 'reset-gpios' property inside the the mdio node instead of the deprecated usage of 'phy-reset-gpios'.
Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines · Fabio Estevam
imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4.
The AR8035 provides a 125MHz clock to the
ENET_REF_CLKi.MX6 pin.
Quoted 8 lines
Improve the Ethernet representation by adding an mdio node with such information.
This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now expects the 'qca,clk-out-frequency' property to be passed via device tree.
Signed-off-by Fabio Estevam <[email protected]>
As for v2:
This works, describes the hardware correctly, and fixes ethernet problems in U-Boot.
Tested in U-Boot and linux-5.7:
Thanks,
Soeren
Quoted 20 lines
---
Changes since v2:
- None. Only reorded the patches.arch/arm/boot/dts/imx6q-tbs2910.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm/boot/dts/imx6q-tbs2910.dts +4
-0@@ -100,7 +100,18 @@ pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; + phy-handle = <&phy>; status = "okay"; + + mdio { + #address-cells = <1>;
arch/arm/boot/dts/imx6q-tbs2910.dts line 117
Quoted 10 lines
arch/arm/boot/dts/imx6q-tbs2910.dts +7
-0+ #size-cells = <0>; + + phy: ethernet-phy@4 { + reg = <4>; + qca,clk-out-frequency = <125000000>; + }; + }; }; &hdmi {
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Shawn Guo
AppliedQuoted 4 lines · Fabio Estevam
imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4.
The AR8035 provides a 125MHz clock to the
ENET_REF_CLKi.MX6 pin.
Quoted 8 lines
Improve the Ethernet representation by adding an mdio node with such information.
This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now expects the 'qca,clk-out-frequency' property to be passed via device tree.
Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel