Skip to contentSkip to conversation

lib: fix build for missing RCU library dependency

PATCH Applied Ferruh Yigit 4 participants 4 messages Jul 13, 2020 – Jul 15, 2020 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: fix build for missing RCU library dependency

'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should be reflected to build system.

Fixes 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

---
Cc: [email protected]

---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +1 -1
index 4b981f505e..8f5b68a2d4 100644
@@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
 DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib
 DEPDIRS-librte_fib := librte_eal librte_rib
 DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm
-DEPDIRS-librte_lpm := librte_eal librte_hash
+DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
 DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl
 DEPDIRS-librte_acl := librte_eal
 DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
Signature · 1 line
2.25.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, July 13, 2020 9:51 PM
To: Honnappa Nagarahalli <[email protected]>; Ruifeng Wang <[email protected]>; Vladimir Medvedkin <[email protected]>; Ray Kinsella <[email protected]>
Cc: [email protected]; Ferruh Yigit <[email protected]>
Subject: [PATCH] lib: fix build for missing RCU library dependency

Quoted 8 lines

'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should be reflected to build system.

Fixes 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

---
Cc: [email protected]

Hi Ferruh,

Thanks for fixing this.
Although I didn't reproduce the building issue, this patch is obviously valid.

Regards.
/Ruifeng

Quoted 18 lines
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +0 -0
@@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
 DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib  DEPDIRS-librte_fib :=

librte_eal librte_rib
DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
librte_eal librte_hash
+DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl DEPDIRS-librte_acl :=
librte_eal
DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
--
2.25.4

Acked-by
#2 lore raw
Quoted 20 lines · Ruifeng Wang
Quoted 10 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Monday, July 13, 2020 9:51 PM
To: Honnappa Nagarahalli <[email protected]>; Ruifeng Wang <[email protected]>; Vladimir Medvedkin <[email protected]>; Ray Kinsella <[email protected]>
Cc: [email protected]; Ferruh Yigit <[email protected]>
Subject: [PATCH] lib: fix build for missing RCU library dependency

Quoted 8 lines

'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should be reflected to build system.

Fixes 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

---
Cc: [email protected]

Hi Ferruh,

Quoted 7 lines

Thanks for fixing this.
Although I didn't reproduce the building issue, this patch is obviously valid.

Regards.
/Ruifeng

Was already there for meson/ninja.

Quoted 19 lines
Quoted 18 lines
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Makefile +0 -0
@@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
 DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib  DEPDIRS-librte_fib :=

librte_eal librte_rib
DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
librte_eal librte_hash
+DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl DEPDIRS-librte_acl :=
librte_eal
DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
--
2.25.4

Reviewed-by Ruifeng Wang Acked-by Ray Kinsella on v1 1/1 Applied
#3 lore raw
In reply to Ferruh Yigit
Quoted 3 lines · Ferruh Yigit

'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should be reflected to build system.

Good catch, thanks Ferruh.

Quoted 3 lines
Fixes 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

Applied.

Signature · 1 line
David Marchand