usb: typec: tcpm: Move to high priority workqueue for processing events
Subsystems (3)
Badhri Jagan Sridharan
maintainerPATCH 1/1 usb: typec: tcpm: Move to high priority workqueue for processing events
"tReceiverResponse 15 ms Section 6.6.2
The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire."
When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes does not get scheduled on time to meet the above requirement from the spec. Elevating the TCPM's work queue to higher priority allows TCPM to meet tReceiverResponse in a busy system.
--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/tcpm/tcpm.c +1 -1
@@ -4747,7 +4747,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)mutex_init (&port->lock);mutex_init (&port->swap_lock); - port->wq =create_singlethread_workqueue (dev_name (dev)); + port->wq =alloc_ordered_workqueue ("%s" ,WQ_HIGHPRI ,dev_name (dev));if (!port->wq)return ERR_PTR (-ENOMEM );INIT_DELAYED_WORK (&port->state_machine, tcpm_state_machine_work);
Signature · 1 line
2.27.0.383.g050319c2ae-goog
reg Kroah-Hartman
maintainerQuoted 21 lines · Badhri Jagan Sridharan
"tReceiverResponse 15 ms Section 6.6.2
The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire."When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes does not get scheduled on time to meet the above requirement from the spec. Elevating the TCPM's work queue to higher priority allows TCPM to meet tReceiverResponse in a busy system.
Signed-off-by Badhri Jagan Sridharan <[email protected]>--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +0
-0
drivers/usb/typec/tcpm/tcpm.c struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) · line 4750
Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4747,7 +4747,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)mutex_init (&port->lock);mutex_init (&port->swap_lock); - port->wq =create_singlethread_workqueue (dev_name (dev)); + port->wq =alloc_ordered_workqueue ("%s" ,WQ_HIGHPRI ,dev_name (dev));
How are you "guaranteeing" that this is really going to change anything on a highly loaded machine?
Yes, it might make things better, but if you have a hard deadline like this, you need to do things a bit differently to always ensure that you meet it. I do not think this change is that fix, do you?
thanks,
greg k-h
Quoted 31 lines · reg Kroah-Hartman
Quoted 21 lines · Badhri Jagan Sridharan
"tReceiverResponse 15 ms Section 6.6.2
The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire."When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes does not get scheduled on time to meet the above requirement from the spec. Elevating the TCPM's work queue to higher priority allows TCPM to meet tReceiverResponse in a busy system.
Signed-off-by Badhri Jagan Sridharan <[email protected]>--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +0
-0drivers/usb/typec/tcpm/tcpm.c struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) · line 4750
Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4747,7 +4747,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)mutex_init (&port->lock);mutex_init (&port->swap_lock); - port->wq =create_singlethread_workqueue (dev_name (dev)); + port->wq =alloc_ordered_workqueue ("%s" ,WQ_HIGHPRI ,dev_name (dev));How are you "guaranteeing" that this is really going to change anything on a highly loaded machine?
Quoted 4 lines
Yes, it might make things better, but if you have a hard deadline like this, you need to do things a bit differently to always ensure that you meet it. I do not think this change is that fix, do you?
Good point. The worker in drivers/watchdog/watchdog_dev.c might be useful as a starting point. There may be better examples - this is just one I know of which had a similar problem. See commits 38a1222ae4f3 and 1ff688209e2e.
Guenter
Badhri Jagan Sridharan
maintainerQuoted 33 lines · Guenter Roeck
Quoted 31 lines · reg Kroah-Hartman
Quoted 21 lines · Badhri Jagan Sridharan
"tReceiverResponse 15 ms Section 6.6.2
The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire."When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes does not get scheduled on time to meet the above requirement from the spec. Elevating the TCPM's work queue to higher priority allows TCPM to meet tReceiverResponse in a busy system.
Signed-off-by Badhri Jagan Sridharan <[email protected]>--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +0
-0drivers/usb/typec/tcpm/tcpm.c struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) · line 4750
Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4747,7 +4747,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)mutex_init (&port->lock);mutex_init (&port->swap_lock); - port->wq =create_singlethread_workqueue (dev_name (dev)); + port->wq =alloc_ordered_workqueue ("%s" ,WQ_HIGHPRI ,dev_name (dev));How are you "guaranteeing" that this is really going to change anything on a highly loaded machine?
Quoted 4 lines
Quoted 4 lines
Yes, it might make things better, but if you have a hard deadline like this, you need to do things a bit differently to always ensure that you meet it. I do not think this change is that fix, do you?
Yes Greg I agree with you, moving to HIGHPRI was making it better but is not going to
solve the problem always. I was wondering whether are there better ways of doing this.
Quoted 7 lines
Good point. The worker in
drivers/watchdog/!watchdog_dev.c might be useful as a starting point. There may be better examples - this is just one I know of which had a similar problem. See commits38a1222ae4f3and1ff688209e2e.Guenter
Thanks a lot Guenter !! Very useful pointers, will review the approaches in both the
commits !
Badhri Jagan Sridharan
maintainerHi Guenter,
Just sent out the patch "usb: typec: tcpm: Migrate workqueue to RT priority for processing events" which uses kthread_create_worker and hrtimer.nAppreciate your guidance !! The commits 38a1222ae4f3 and 1ff688209e2e were spot on as they were trying solve the same problem in a different subsystem.
Thanks,
Badhri
Quoted 55 lines · Badhri Jagan Sridharan
Quoted 33 lines · Guenter Roeck
Quoted 31 lines · reg Kroah-Hartman
Quoted 21 lines · Badhri Jagan Sridharan
"tReceiverResponse 15 ms Section 6.6.2
The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire."When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes does not get scheduled on time to meet the above requirement from the spec. Elevating the TCPM's work queue to higher priority allows TCPM to meet tReceiverResponse in a busy system.
Signed-off-by Badhri Jagan Sridharan <[email protected]>--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +0
-0drivers/usb/typec/tcpm/tcpm.c struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) · line 4750
Quoted 5 lines
drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -4747,7 +4747,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)mutex_init (&port->lock);mutex_init (&port->swap_lock); - port->wq =create_singlethread_workqueue (dev_name (dev)); + port->wq =alloc_ordered_workqueue ("%s" ,WQ_HIGHPRI ,dev_name (dev));How are you "guaranteeing" that this is really going to change anything on a highly loaded machine?
Quoted 4 lines
Quoted 4 lines
Yes, it might make things better, but if you have a hard deadline like this, you need to do things a bit differently to always ensure that you meet it. I do not think this change is that fix, do you?
Yes Greg I agree with you, moving to HIGHPRI was making it better but is not going to
solve the problem always. I was wondering whether are there better ways of doing this.Quoted 7 lines
Good point. The worker in
drivers/watchdog/!watchdog_dev.c might be useful as a starting point. There may be better examples - this is just one I know of which had a similar problem. See commits38a1222ae4f3and1ff688209e2e.Guenter
Thanks a lot Guenter !! Very useful pointers, will review the approaches in both the
commits !