Skip to contentSkip to conversation

Makefile: delete debug libs when debug is not enabled

PATCH New Danomi Manchego 3 participants 3 messages Jul 14, 2020 – Jul 21, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: delete debug libs when debug is not enabled

Some toolchains, like the Linaro gcc7 toolchains, now install libstdc++ debug library symbols to /lib/debug, which can be as large as the library itself. This commit removes the extra debug content if debugging is not enabled.

---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)
Makefile +3 -0
index 04c29b1..3a81385 100644
@@ -765,6 +765,9 @@ endif
 	rm -rf $(TARGET_DIR)/usr/doc $(TARGET_DIR)/usr/share/doc
 	rm -rf $(TARGET_DIR)/usr/share/gtk-doc
 	rmdir $(TARGET_DIR)/usr/share 2>/dev/null || true
+ifneq ($(BR2_ENABLE_DEBUG),y)
+	rm -rf $(TARGET_DIR)/lib/debug $(TARGET_DIR)/usr/lib/debug
+endif
 	$(STRIP_FIND_CMD) | xargs -0 $(STRIPCMD) 2>/dev/null || true
 	$(STRIP_FIND_SPECIAL_LIBS_CMD) | xargs -0 -r $(STRIPCMD) $(STRIP_STRIP_DEBUG) 2>/dev/null || true
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 Makefile: delete debug libs when debug is not enabled

Makefile endif · line 770

Quoted 3 lines · On Mon, 13 Jul 2020 22:25:54 -0400 Danomi Manchego…
Makefile +3 -0
+ifneq ($(BR2_ENABLE_DEBUG),y)
+	rm -rf $(TARGET_DIR)/lib/debug $(TARGET_DIR)/usr/lib/debug
+endif

The thing is that BR2_ENABLE_DEBUG=y doesn't mean you want debugging symbols on the target, it means you want debugging symbols in staging.

So, I adjusted this to:

+ifneq ($(BR2_ENABLE_DEBUG):$(BR2_STRIP_strip),y:)
+ rm -rf $(TARGET_DIR)/lib/debug $(TARGET_DIR)/usr/lib/debug
+endif

As BR2_ENABLE_DEBUG=y + BR2_STRIP_strip disabled is the best indication we have (I believe) to say "I want debugging symbols on the target".

Applied with that change. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 Makefile: delete debug libs when debug is not enabled

In reply to Danomi Manchego
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Danomi" == Danomi Manchego <[email protected]> writes:

Some toolchains, like the Linaro gcc7 toolchains, now install libstdc++ debug library symbols to /lib/debug, which can be as large as the library itself. This commit removes the extra debug content if debugging is not enabled.

Committed to 2020.02.x and 2020.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard