Skip to contentSkip to conversation

clk: qcom: msm8996: Make symbol 'cpu_msm8996_clks' static

PATCH Applied Wei Yongjun 2 participants 2 messages Jul 14, 2020 – Jul 21, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: msm8996: Make symbol 'cpu_msm8996_clks' static

The sparse tool complains as follows:

drivers/clk/qcom/clk-cpu-8996.c:341:19: warning:
symbol 'cpu_msm8996_clks' was not declared. Should it be static?

This variable is not used outside of clk-cpu-8996.c, so this commit marks it static.

Fixes 03e342dc45c9 ("clk: qcom: Add CPU clock driver for msm8996")
---
 drivers/clk/qcom/clk-cpu-8996.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clk-cpu-8996.c +1 -1
index 77a2d2806e58..4a4fde8dd12d 100644
@@ -338,7 +338,7 @@ static const struct regmap_config cpu_msm8996_regmap_config = {
 	.val_format_endian	= REGMAP_ENDIAN_LITTLE,
 };
 
-struct clk_regmap *cpu_msm8996_clks[] = {
+static struct clk_regmap *cpu_msm8996_clks[] = {
 	&perfcl_pll.clkr,
 	&pwrcl_pll.clkr,
 	&perfcl_alt_pll.clkr,
maintainer Applied
#1 lore raw

Quoting Wei Yongjun (2020-07-14 07:21:55)

Quoted 5 lines

The sparse tool complains as follows:

drivers/clk/qcom/clk-cpu-8996.c:341:19: warning:
symbol 'cpu_msm8996_clks' was not declared. Should it be static?

Quoted 7 lines

This variable is not used outside of clk-cpu-8996.c, so this commit marks it static.

Fixes 03e342dc45c9 ("clk: qcom: Add CPU clock driver for msm8996")

---

Applied to clk-next