irqchip: mips-gic: Make some symbols static
Subsystems (3)
PATCH 1/1 irqchip: mips-gic: Make some symbols static
The sparse tool complains as follows:
drivers/irqchip/irq-mips-gic.c:49:1: warning:
symbol '__pcpu_scope_pcpu_masks' was not declared. Should it be static?drivers/irqchip/irq-mips-gic.c:620:6: warning:
symbol 'gic_ipi_domain_free' was not declared. Should it be static?drivers/irqchip/irq-mips-gic.c:634:5: warning:
symbol 'gic_ipi_domain_match' was not declared. Should it be static?
Those symbols are not used outside of irq-mips-gic.c, so marks them static.
--- drivers/irqchip/irq-mips-gic.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/irqchip/irq-mips-gic.c +5 -5
@@ -46,7 +46,7 @@void __iomem *mips_gic_base; -DEFINE_PER_CPU_READ_MOSTLY(unsigned long[GIC_MAX_LONGS], pcpu_masks); +static DEFINE_PER_CPU_READ_MOSTLY(unsigned long[GIC_MAX_LONGS], pcpu_masks);static DEFINE_SPINLOCK (gic_lock);static struct irq_domain *gic_irq_domain;
@@ -617,8 +617,8 @@ static int gic_ipi_domain_alloc(struct irq_domain *d, unsigned int virq,return ret; } -void gic_ipi_domain_free (struct irq_domain *d,unsigned int virq, -unsigned int nr_irqs) +static void gic_ipi_domain_free (struct irq_domain *d,unsigned int virq, +unsigned int nr_irqs) {irq_hw_number_t base_hwirq;struct irq_data *data;
@@ -631,8 +631,8 @@ void gic_ipi_domain_free(struct irq_domain *d, unsigned int virq,bitmap_set (ipi_available, base_hwirq, nr_irqs); } -int gic_ipi_domain_match (struct irq_domain *d,struct device_node *node, -enum irq_domain_bus_token bus_token) +static int gic_ipi_domain_match (struct irq_domain *d,struct device_node *node, +enum irq_domain_bus_token bus_token) {bool is_ipi;
Marc Zyngier
AppliedQuoted 10 lines · Wei Yongjun
The sparse tool complains as follows:
drivers/irqchip/irq-mips-gic.c:49:1: warning:
symbol '__pcpu_scope_pcpu_masks' was not declared. Should it be static?drivers/irqchip/irq-mips-gic.c:620:6: warning:
symbol 'gic_ipi_domain_free' was not declared. Should it be static?drivers/irqchip/irq-mips-gic.c:634:5: warning:
symbol 'gic_ipi_domain_match' was not declared. Should it be static?[...]
Applied to irq/irqchip-5.9, thanks!
[1/1] irqchip/mips-gic: Make local symbols static
commit: 63bf3444359c94d647c2afa79b5e732585469581
Cheers,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.