Skip to contentSkip to conversation

package/gvfs: bump to version 1.44.1

PATCH New Fabrice Fontaine 2 participants 2 messages Apr 12, 2020 – Jul 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gvfs: bump to version 1.44.1

- Remove all patches (already in version)
- Move to meson-package
- Add new gsettings-desktop-schemas mandatory dependency
- gdu option doesn't exist anymore:
https://gitlab.gnome.org/GNOME/gvfs/-/commit/1db029df72bcd50dd877d388c2e0934d8ed3d321
- Use new gcrypt otion
- systemd-login option has been replaced by logind option
- avahi option has been replaced by dnsd option
- gtk3 optional dependency has been removed since
https://gitlab.gnome.org/GNOME/gvfs/-/commit/dff13283c943c8b10265bd3925d86f17cdc4be6f
- Disable new sftp backend:
https://gitlab.gnome.org/GNOME/gvfs/-/commit/44d45dca5d1ab2369fa7e5c2789b31c51e44f985
- Disable fuse (depends on fuse3 which is not available on buildroot)
- Remove gvfs-less workaround (not installed anymore)
- Update indentation of hash file

---
 ...authentication-agent-isn-t-available.patch |  46 ------
 ...ery_info_on_read-write-functionality.patch | 131 ----------------
 ...0003-admin-Allow-changing-file-owner.patch |  34 -----
 ...uid-to-ensure-correct-file-ownership.patch |  91 -----------
 ...ct-ownership-when-moving-to-file-uri.patch |  84 ----------
 ...e-connecting-client-is-the-same-user.patch |  96 ------------
 package/gvfs/Config.in                        |   1 +
 package/gvfs/gvfs.hash                        |   6 +-
 package/gvfs/gvfs.mk                          | 143 +++++++-----------
 9 files changed, 59 insertions(+), 573 deletions(-)
 delete mode 100644 package/gvfs/0001-admin-Prevent-access-if-any-authentication-agent-isn-t-available.patch
 delete mode 100644 package/gvfs/0002-admin-Add-query_info_on_read-write-functionality.patch
 delete mode 100644 package/gvfs/0003-admin-Allow-changing-file-owner.patch
 delete mode 100644 package/gvfs/0004-admin-Use-fsuid-to-ensure-correct-file-ownership.patch
 delete mode 100644 package/gvfs/0005-admin-Ensure-correct-ownership-when-moving-to-file-uri.patch
 delete mode 100644 package/gvfs/0006-gvfsdaemon-Check-that-the-connecting-client-is-the-same-user.patch
package/gvfs/0001-admin-Prevent-access-if-any-authentication-agent-isn-t-available.patch deleted +0 -46
deleted file mode 100644
index b5a6d024cc..0000000000
@@ -1,46 +0,0 @@
-From d8d0c8c40049cfd824b2b90d0cd47914052b9811 Mon Sep 17 00:00:00 2001
-From: Ondrej Holy <[email protected]>
-Date: Wed, 2 Jan 2019 17:13:27 +0100
-Subject: [PATCH] admin: Prevent access if any authentication agent isn't
- available
-
-The backend currently allows to access and modify files without prompting
-for password if any polkit authentication agent isn't available. This seems
-isn't usually problem, because polkit agents are integral parts of
-graphical environments / linux distributions. The agents can't be simply
-disabled without root permissions and are automatically respawned. However,
-this might be a problem in some non-standard cases.
-
-This affects only users which belong to wheel group (i.e. those who are
-already allowed to use sudo). It doesn't allow privilege escalation for
-users, who don't belong to that group.
-
-Let's return permission denied error also when the subject can't be
-authorized by any polkit agent to prevent this behavior.
-
-Closes: https://gitlab.gnome.org/GNOME/gvfs/issues/355
-
-[Retrieved from:
-https://gitlab.gnome.org/GNOME/gvfs/commit/d8d0c8c40049cfd824b2b90d0cd47914052b9811]
-Signed-off-by: Fabrice Fontaine <[email protected]>
----
- daemon/gvfsbackendadmin.c | 3 +--
- 1 file changed, 1 insertion(+), 2 deletions(-)
-
-diff --git a/daemon/gvfsbackendadmin.c b/daemon/gvfsbackendadmin.c
-index ec0f2392..0f849008 100644
---- a/daemon/gvfsbackendadmin.c
-+++ b/daemon/gvfsbackendadmin.c
-@@ -130,8 +130,7 @@ check_permission (GVfsBackendAdmin *self,
-       return FALSE;
-     }
- 
--  is_authorized = polkit_authorization_result_get_is_authorized (result) ||
--    polkit_authorization_result_get_is_challenge (result);
-+  is_authorized = polkit_authorization_result_get_is_authorized (result);
- 
-   g_object_unref (result);
- 
--- 
-2.24.1
-
package/gvfs/0002-admin-Add-query_info_on_read-write-functionality.patch deleted +0 -131

131 lines not on this page · raw message

package/gvfs/0003-admin-Allow-changing-file-owner.patch deleted +0 -34
deleted file mode 100644
index 04138b3957..0000000000
@@ -1,34 +0,0 @@
-From daf1163aba229afcfddf0f925aef7e97047e8959 Mon Sep 17 00:00:00 2001
-From: Ondrej Holy <[email protected]>
-Date: Thu, 23 May 2019 10:29:08 +0200
-Subject: [PATCH] admin: Allow changing file owner
-
-CAP_CHOWN is dropped together with other privilages and thus the backend
-can't change file owner. This might be probably e.g. in case of copy
-operation when G_FILE_COPY_ALL_METADATA is used. Let's keep CAP_CHOWN
-to fix this.
-
-[Retrieved from:
-https://gitlab.gnome.org/GNOME/gvfs/commit/daf1163aba229afcfddf0f925aef7e97047e8959]
-Signed-off-by: Fabrice Fontaine <[email protected]>
----
- daemon/gvfsbackendadmin.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
-
-diff --git a/daemon/gvfsbackendadmin.c b/daemon/gvfsbackendadmin.c
-index 23d16f16..a74d09cf 100644
---- a/daemon/gvfsbackendadmin.c
-+++ b/daemon/gvfsbackendadmin.c
-@@ -968,7 +968,8 @@ g_vfs_backend_admin_init (GVfsBackendAdmin *self)
- 
- #define REQUIRED_CAPS (CAP_TO_MASK(CAP_FOWNER) | \
-                        CAP_TO_MASK(CAP_DAC_OVERRIDE) | \
--                       CAP_TO_MASK(CAP_DAC_READ_SEARCH))
-+                       CAP_TO_MASK(CAP_DAC_READ_SEARCH) | \
-+                       CAP_TO_MASK(CAP_CHOWN))
- 
- static void
- acquire_caps (uid_t uid)
--- 
-2.24.1
-
package/gvfs/0004-admin-Use-fsuid-to-ensure-correct-file-ownership.patch deleted +0 -91

91 lines not on this page · raw message

package/gvfs/0005-admin-Ensure-correct-ownership-when-moving-to-file-uri.patch deleted +0 -84

84 lines not on this page · raw message

package/gvfs/0006-gvfsdaemon-Check-that-the-connecting-client-is-the-same-user.patch deleted +0 -96

96 lines not on this page · raw message

package/gvfs/Config.in +1 -0
index 44a75210e5..78280f80e0 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_GVFS
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_USE_MMU # dbus, glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
+	select BR2_PACKAGE_GSETTINGS_DESKTOP_SCHEMAS
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_SHARED_MIME_INFO
package/gvfs/gvfs.hash +3 -3
index 6b7403ffa4..2ee945e710 100644
@@ -1,5 +1,5 @@
-# From http://ftp.gnome.org/pub/GNOME/sources/gvfs/1.31/gvfs-1.31.4.sha256sum
-sha256	55244d447d040884dfb335fde638274cb6f2794285ada7fa84bcbbd34f06be04	gvfs-1.31.4.tar.xz
+# From http://ftp.gnome.org/pub/GNOME/sources/gvfs/1.44/gvfs-1.44.1.sha256sum
+sha256  50ef3245d1b03666a40455109169a2a1bd51419fd2d51f9fa6cfd4f89f04fb46  gvfs-1.44.1.tar.xz
 
 # Hash for license file
-sha256	45cf336e2e48176993babc5aabf44437390f40e6a86a472c6abfc7ce9c035db4	COPYING
+sha256  45cf336e2e48176993babc5aabf44437390f40e6a86a472c6abfc7ce9c035db4  COPYING
package/gvfs/gvfs.mk +55 -88

244 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/gvfs: bump to version 1.44.1

Quoted 16 lines · On Sun, 12 Apr 2020 14:57:47 +0200 Fabrice Fontaine…

- Remove all patches (already in version)
- Move to meson-package
- Add new gsettings-desktop-schemas mandatory dependency
- gdu option doesn't exist anymore:
https://gitlab.gnome.org/GNOME/gvfs/-/commit/1db029df72bcd50dd877d388c2e0934d8ed3d321
- Use new gcrypt otion
- systemd-login option has been replaced by logind option
- avahi option has been replaced by dnsd option
- gtk3 optional dependency has been removed since
https://gitlab.gnome.org/GNOME/gvfs/-/commit/dff13283c943c8b10265bd3925d86f17cdc4be6f
- Disable new sftp backend:
https://gitlab.gnome.org/GNOME/gvfs/-/commit/44d45dca5d1ab2369fa7e5c2789b31c51e44f985
- Disable fuse (depends on fuse3 which is not available on buildroot)
- Remove gvfs-less workaround (not installed anymore)
- Update indentation of hash file

Quoted 1 line

Thanks, I've applied, with just one change, see below.

Quoted 1 line

+GVFS_CONF_ENV = LIBS="$(TARGET_NLS_LIBS)"

I didn't actually test if this works or not, but none of our meson packages add TARGET_NLS_LIBS this way. See:

$ git grep TARGET_NLS_LIBS $(git grep -l meson-package)

so I've changed to:

GVFS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)

to match what we do in other packages.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com