Skip to contentSkip to conversation

power_supply: wilco_ec: Add permanent long life charging mode

PATCH RESEND Superseded Crag Wang 3 participants 5 messages Jul 15, 2020 – Jul 31, 2020 Power supply

lore
Share & tools
lore

Crag Wang

author
#0 lore raw

PATCH RESEND 1/1 power_supply: wilco_ec: Add permanent long life charging mode

This is a long life mode set in the factory for extended warranty battery, the power charging rate is customized so that battery at work last longer.

Presently switching to a different battery charging mode is through EC PID 0x0710 to configure the battery firmware, this operation will be blocked by EC with failure code 0x01 when PLL mode is already in use.

---
 Documentation/ABI/testing/sysfs-class-power-wilco | 3 +++
 drivers/power/supply/power_supply_sysfs.c         | 1 +
 drivers/power/supply/wilco-charger.c              | 5 +++++
 include/linux/power_supply.h                      | 1 +
 4 files changed, 10 insertions(+)
Documentation/ABI/testing/sysfs-class-power-wilco +3 -0
index da1d6ffe5e3c..1c91b17b6fd4 100644
@@ -14,6 +14,9 @@ Description:
 			Charging begins when level drops below
 			charge_control_start_threshold, and ceases when
 			level is above charge_control_end_threshold.
+		Permanent Long Life: Last longer battery life, this mode
+			is programmed once in the factory. Switching to a
+			different mode is unavailable.
 
 What:		/sys/class/power_supply/wilco-charger/charge_control_start_threshold
 Date:		April 2019
drivers/power/supply/power_supply_sysfs.c +1 -0
index bc79560229b5..af3884015ad8 100644
@@ -87,6 +87,7 @@ static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {
 	[POWER_SUPPLY_CHARGE_TYPE_STANDARD]	= "Standard",
 	[POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE]	= "Adaptive",
 	[POWER_SUPPLY_CHARGE_TYPE_CUSTOM]	= "Custom",
+	[POWER_SUPPLY_CHARGE_TYPE_LONGLIFE]	= "Permanent Long Life",
 };
 
 static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
drivers/power/supply/wilco-charger.c +5 -0
index b3c6d7cdd731..713c3018652f 100644
@@ -27,6 +27,7 @@ enum charge_mode {
 	CHARGE_MODE_AC = 3,	/* Mostly AC use, used for Trickle */
 	CHARGE_MODE_AUTO = 4,	/* Used for Adaptive */
 	CHARGE_MODE_CUSTOM = 5,	/* Used for Custom */
+	CHARGE_MODE_LONGLIFE = 6, /* Used for Permanent Long Life */
 };
 
 #define CHARGE_LOWER_LIMIT_MIN	50
@@ -48,6 +49,8 @@ static int psp_val_to_charge_mode(int psp_val)
 		return CHARGE_MODE_AUTO;
 	case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
 		return CHARGE_MODE_CUSTOM;
+	case POWER_SUPPLY_CHARGE_TYPE_LONGLIFE:
+		return CHARGE_MODE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
@@ -67,6 +70,8 @@ static int charge_mode_to_psp_val(enum charge_mode mode)
 		return POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE;
 	case CHARGE_MODE_CUSTOM:
 		return POWER_SUPPLY_CHARGE_TYPE_CUSTOM;
+	case CHARGE_MODE_LONGLIFE:
+		return POWER_SUPPLY_CHARGE_TYPE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
include/linux/power_supply.h +1 -0
index ac1345a48ad0..528a3eaa2320 100644
@@ -48,6 +48,7 @@ enum {
 	POWER_SUPPLY_CHARGE_TYPE_STANDARD,	/* normal speed */
 	POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE,	/* dynamically adjusted speed */
 	POWER_SUPPLY_CHARGE_TYPE_CUSTOM,	/* use CHARGE_CONTROL_* props */
+	POWER_SUPPLY_CHARGE_TYPE_LONGLIFE,	/* slow speed, longer life */
 };
 
 enum {
Signature · 4 lines
2.17.1

---
The original author, Nick no longer being around and that's why he's not on CC.
#1 lore raw

Hi,

Quoted 22 lines · Crag Wang

This is a long life mode set in the factory for extended warranty battery, the power charging rate is customized so that battery at work last longer.

Presently switching to a different battery charging mode is through EC PID 0x0710 to configure the battery firmware, this operation will be blocked by EC with failure code 0x01 when PLL mode is already in use.

---
 Documentation/ABI/testing/sysfs-class-power-wilco | 3 +++
 drivers/power/supply/power_supply_sysfs.c         | 1 +
 drivers/power/supply/wilco-charger.c              | 5 +++++
 include/linux/power_supply.h                      | 1 +
 4 files changed, 10 insertions(+)
Documentation/ABI/testing/sysfs-class-power-wilco +0 -0
index da1d6ffe5e3c..1c91b17b6fd4 100644

Documentation/ABI/testing/sysfs-class-power-wilco Description: · line 19

Quoted 6 lines
Documentation/ABI/testing/sysfs-class-power-wilco +3 -0
@@ -14,6 +14,9 @@ Description:
 			Charging begins when level drops below
 			charge_control_start_threshold, and ceases when
 			level is above charge_control_end_threshold.
+		Permanent Long Life: Last longer battery life, this mode
+			is programmed once in the factory. Switching to a
+			different mode is unavailable.

The documentation lacks one important aspect: What happens if I have a device where the factory did not program "Long Life"? I.e. what happens when

# cat /sys/class/power_supply/wilco-charger/charge_type
Standard
# echo "Long Life" > /sys/class/power_supply/wilco-charger/charge_type

Will the controller switch into permanent long life battery mode without any exit strategy?

drivers/power/supply/power_supply_sysfs.c static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = { · line 90

Quoted 11 lines
Documentation/ABI/testing/sysfs-class-power-wilco +0 -0
 What:		/sys/class/power_supply/wilco-charger/charge_control_start_threshold
 Date:		April 2019
drivers/power/supply/power_supply_sysfs.c +1 -0
index bc79560229b5..af3884015ad8 100644
@@ -87,6 +87,7 @@ static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {
 	[POWER_SUPPLY_CHARGE_TYPE_STANDARD]	= "Standard",
 	[POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE]	= "Adaptive",
 	[POWER_SUPPLY_CHARGE_TYPE_CUSTOM]	= "Custom",
+	[POWER_SUPPLY_CHARGE_TYPE_LONGLIFE]	= "Permanent Long Life",

The "Permanent" part is specific to the Wilco EC, so I think it's better to avoid it in the generic API. I think it's better to use just "Long Life" (and keep the wilco specific sysfs Documentation, that Long Life configuration is permanent).

-- Sebastian

Quoted 50 lines
drivers/power/supply/power_supply_sysfs.c +0 -0
 };
 
 static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
drivers/power/supply/wilco-charger.c +5 -0
index b3c6d7cdd731..713c3018652f 100644
@@ -27,6 +27,7 @@ enum charge_mode {
 	CHARGE_MODE_AC = 3,	/* Mostly AC use, used for Trickle */
 	CHARGE_MODE_AUTO = 4,	/* Used for Adaptive */
 	CHARGE_MODE_CUSTOM = 5,	/* Used for Custom */
+	CHARGE_MODE_LONGLIFE = 6, /* Used for Permanent Long Life */
 };
 
 #define CHARGE_LOWER_LIMIT_MIN	50
@@ -48,6 +49,8 @@ static int psp_val_to_charge_mode(int psp_val)
 		return CHARGE_MODE_AUTO;
 	case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
 		return CHARGE_MODE_CUSTOM;
+	case POWER_SUPPLY_CHARGE_TYPE_LONGLIFE:
+		return CHARGE_MODE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
@@ -67,6 +70,8 @@ static int charge_mode_to_psp_val(enum charge_mode mode)
 		return POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE;
 	case CHARGE_MODE_CUSTOM:
 		return POWER_SUPPLY_CHARGE_TYPE_CUSTOM;
+	case CHARGE_MODE_LONGLIFE:
+		return POWER_SUPPLY_CHARGE_TYPE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
include/linux/power_supply.h +1 -0
index ac1345a48ad0..528a3eaa2320 100644
@@ -48,6 +48,7 @@ enum {
 	POWER_SUPPLY_CHARGE_TYPE_STANDARD,	/* normal speed */
 	POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE,	/* dynamically adjusted speed */
 	POWER_SUPPLY_CHARGE_TYPE_CUSTOM,	/* use CHARGE_CONTROL_* props */
+	POWER_SUPPLY_CHARGE_TYPE_LONGLIFE,	/* slow speed, longer life */
 };
 
 enum {
Signature · 4 lines
2.17.1

---
The original author, Nick no longer being around and that's why he's not on CC.
#2 lore raw
Quoted 8 lines

Documentation/ABI/testing/sysfs-class-power-wilco Description: · line 19

Quoted 3 lines
Documentation/ABI/testing/sysfs-class-power-wilco +3 -0
+		Permanent Long Life: Last longer battery life, this mode
+			is programmed once in the factory. Switching to a
+			different mode is unavailable.

The documentation lacks one important aspect: What happens if I have a device where the factory did not program "Long Life"?
I.e. what happens when

Quoted 7 lines
# cat /sys/class/power_supply/wilco-charger/charge_type
Standard
# echo "Long Life" > /sys/class/power_supply/wilco-charger/charge_type

Will the controller switch into permanent long life battery mode without any exit strategy?

The set_property attempt will convert "Long Life" to its index of charge mode and send a EC command to Property ID 0x0710 for configuration. This try will be denied by EC because "Long Life" mode must be set (enable/disable) through a different PID that isn't publicly known. In the factory there's a proprietary tool in use for PLL configuration.

In above example after the run the charge mode will remain unchanged i.e.:
"Standard".

Quoted 16 lines
Quoted 1 line

What: /sys/class/power_supply/wilco-

charger/charge_control_start_threshold

drivers/power/supply/power_supply_sysfs.c static const char * const

Quoted 7 lines

Date: April 2019

drivers/power/supply/power_supply_sysfs.c +0 -0
index bc79560229b5..af3884015ad8 100644
@@ -87,6 +87,7 @@ static const char * const

POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {

drivers/power/supply/power_supply_sysfs.c static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {

Quoted 4 lines
drivers/power/supply/power_supply_sysfs.c +1 -0
 	[POWER_SUPPLY_CHARGE_TYPE_STANDARD]	= "Standard",
 	[POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE]	= "Adaptive",
 	[POWER_SUPPLY_CHARGE_TYPE_CUSTOM]	= "Custom",
+	[POWER_SUPPLY_CHARGE_TYPE_LONGLIFE]	= "Permanent Long

Life",

Quoted 4 lines

The "Permanent" part is specific to the Wilco EC, so I think it's better to avoid it in the generic API. I think it's better to use just "Long Life" (and keep the wilco specific sysfs Documentation, that Long Life configuration is permanent).

Agree with you, I will include this modification in the next patch.

Quoted 3 lines

-- Sebastian

author
#3 lore raw

PATCH v2 1/1 power_supply: wilco_ec: Add long life charging mode

In reply to Crag Wang

This is a long life mode set in the factory for extended warranty battery, the power charging rate is customized so that battery at work last longer.

Presently switching to a different battery charging mode is through EC PID 0x0710 to configure the battery firmware, this operation will be blocked by EC with failure code 0x01 when PLL mode is already in use.

---
 Documentation/ABI/testing/sysfs-class-power-wilco | 4 ++++
 drivers/power/supply/power_supply_sysfs.c         | 1 +
 drivers/power/supply/wilco-charger.c              | 5 +++++
 include/linux/power_supply.h                      | 1 +
 4 files changed, 11 insertions(+)
Documentation/ABI/testing/sysfs-class-power-wilco +4 -0
index da1d6ffe5e3c..84fde1d0ada0 100644
@@ -14,6 +14,10 @@ Description:
 			Charging begins when level drops below
 			charge_control_start_threshold, and ceases when
 			level is above charge_control_end_threshold.
+		Long Life: Customized charge rate for last longer battery life.
+			On Wilco device this mode is pre-configured in the factory
+			through EC's private PID. Swiching to a different mode will
+			be denied by Wilco EC when Long Life mode is enabled.
 
 What:		/sys/class/power_supply/wilco-charger/charge_control_start_threshold
 Date:		April 2019
drivers/power/supply/power_supply_sysfs.c +1 -0
index bc79560229b5..cfb87b8b8392 100644
@@ -87,6 +87,7 @@ static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {
 	[POWER_SUPPLY_CHARGE_TYPE_STANDARD]	= "Standard",
 	[POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE]	= "Adaptive",
 	[POWER_SUPPLY_CHARGE_TYPE_CUSTOM]	= "Custom",
+	[POWER_SUPPLY_CHARGE_TYPE_LONGLIFE]	= "Long Life",
 };
 
 static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
drivers/power/supply/wilco-charger.c +5 -0
index b3c6d7cdd731..98ade073ef05 100644
@@ -27,6 +27,7 @@ enum charge_mode {
 	CHARGE_MODE_AC = 3,	/* Mostly AC use, used for Trickle */
 	CHARGE_MODE_AUTO = 4,	/* Used for Adaptive */
 	CHARGE_MODE_CUSTOM = 5,	/* Used for Custom */
+	CHARGE_MODE_LONGLIFE = 6, /* Used for Long Life */
 };
 
 #define CHARGE_LOWER_LIMIT_MIN	50
@@ -48,6 +49,8 @@ static int psp_val_to_charge_mode(int psp_val)
 		return CHARGE_MODE_AUTO;
 	case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
 		return CHARGE_MODE_CUSTOM;
+	case POWER_SUPPLY_CHARGE_TYPE_LONGLIFE:
+		return CHARGE_MODE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
@@ -67,6 +70,8 @@ static int charge_mode_to_psp_val(enum charge_mode mode)
 		return POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE;
 	case CHARGE_MODE_CUSTOM:
 		return POWER_SUPPLY_CHARGE_TYPE_CUSTOM;
+	case CHARGE_MODE_LONGLIFE:
+		return POWER_SUPPLY_CHARGE_TYPE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
include/linux/power_supply.h +1 -0
index ac1345a48ad0..528a3eaa2320 100644
@@ -48,6 +48,7 @@ enum {
 	POWER_SUPPLY_CHARGE_TYPE_STANDARD,	/* normal speed */
 	POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE,	/* dynamically adjusted speed */
 	POWER_SUPPLY_CHARGE_TYPE_CUSTOM,	/* use CHARGE_CONTROL_* props */
+	POWER_SUPPLY_CHARGE_TYPE_LONGLIFE,	/* slow speed, longer life */
 };
 
 enum {
Signature · 4 lines
2.17.1

---
The original author, Nick no longer being around and that's why he's not on CC.
#4 lore raw

Re: [PATCH v2 1/1] power_supply: wilco_ec: Add long life charging mode

Hi,

Quoted 4 lines · Crag Wang

This is a long life mode set in the factory for extended warranty battery, the power charging rate is customized so that battery at work last longer.

Quoted 8 lines

Presently switching to a different battery charging mode is through EC PID 0x0710 to configure the battery firmware, this operation will be blocked by EC with failure code 0x01 when PLL mode is already in use.

---

Thanks, queued.

-- Sebastian

Quoted 80 lines
 Documentation/ABI/testing/sysfs-class-power-wilco | 4 ++++
 drivers/power/supply/power_supply_sysfs.c         | 1 +
 drivers/power/supply/wilco-charger.c              | 5 +++++
 include/linux/power_supply.h                      | 1 +
 4 files changed, 11 insertions(+)
Documentation/ABI/testing/sysfs-class-power-wilco +4 -0
index da1d6ffe5e3c..84fde1d0ada0 100644
@@ -14,6 +14,10 @@ Description:
 			Charging begins when level drops below
 			charge_control_start_threshold, and ceases when
 			level is above charge_control_end_threshold.
+		Long Life: Customized charge rate for last longer battery life.
+			On Wilco device this mode is pre-configured in the factory
+			through EC's private PID. Swiching to a different mode will
+			be denied by Wilco EC when Long Life mode is enabled.
 
 What:		/sys/class/power_supply/wilco-charger/charge_control_start_threshold
 Date:		April 2019
drivers/power/supply/power_supply_sysfs.c +1 -0
index bc79560229b5..cfb87b8b8392 100644
@@ -87,6 +87,7 @@ static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] = {
 	[POWER_SUPPLY_CHARGE_TYPE_STANDARD]	= "Standard",
 	[POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE]	= "Adaptive",
 	[POWER_SUPPLY_CHARGE_TYPE_CUSTOM]	= "Custom",
+	[POWER_SUPPLY_CHARGE_TYPE_LONGLIFE]	= "Long Life",
 };
 
 static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
drivers/power/supply/wilco-charger.c +5 -0
index b3c6d7cdd731..98ade073ef05 100644
@@ -27,6 +27,7 @@ enum charge_mode {
 	CHARGE_MODE_AC = 3,	/* Mostly AC use, used for Trickle */
 	CHARGE_MODE_AUTO = 4,	/* Used for Adaptive */
 	CHARGE_MODE_CUSTOM = 5,	/* Used for Custom */
+	CHARGE_MODE_LONGLIFE = 6, /* Used for Long Life */
 };
 
 #define CHARGE_LOWER_LIMIT_MIN	50
@@ -48,6 +49,8 @@ static int psp_val_to_charge_mode(int psp_val)
 		return CHARGE_MODE_AUTO;
 	case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
 		return CHARGE_MODE_CUSTOM;
+	case POWER_SUPPLY_CHARGE_TYPE_LONGLIFE:
+		return CHARGE_MODE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
@@ -67,6 +70,8 @@ static int charge_mode_to_psp_val(enum charge_mode mode)
 		return POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE;
 	case CHARGE_MODE_CUSTOM:
 		return POWER_SUPPLY_CHARGE_TYPE_CUSTOM;
+	case CHARGE_MODE_LONGLIFE:
+		return POWER_SUPPLY_CHARGE_TYPE_LONGLIFE;
 	default:
 		return -EINVAL;
 	}
include/linux/power_supply.h +1 -0
index ac1345a48ad0..528a3eaa2320 100644
@@ -48,6 +48,7 @@ enum {
 	POWER_SUPPLY_CHARGE_TYPE_STANDARD,	/* normal speed */
 	POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE,	/* dynamically adjusted speed */
 	POWER_SUPPLY_CHARGE_TYPE_CUSTOM,	/* use CHARGE_CONTROL_* props */
+	POWER_SUPPLY_CHARGE_TYPE_LONGLIFE,	/* slow speed, longer life */
 };
 
 enum {
Signature · 4 lines
2.17.1

---
The original author, Nick no longer being around and that's why he's not on CC.