Skip to contentSkip to conversation

xfs/010,030: filter AG header CRC error warnings

PATCH In review Darrick J. Wong 2 participants 3 messages Jul 13, 2020 – Jul 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/010,030: filter AG header CRC error warnings

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

---
 tests/xfs/010 |    6 +++++-
 tests/xfs/030 |    2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)
tests/xfs/010 +5 -1
index c341795d..ec23507a 100755
@@ -113,7 +113,11 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
tests/xfs/030 +2 -0
index 8f95331a..a270e36c 100755
@@ -43,6 +43,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
 			    -e '/^bad inobt block count/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^bad finobt block count/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'
#1 lore raw
Quoted 16 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

---
 tests/xfs/010 |    6 +++++-
 tests/xfs/030 |    2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)
tests/xfs/010 +0 -0
index c341795d..ec23507a 100755

tests/xfs/010 _check_scratch_fs · line 116

Quoted 4 lines
tests/xfs/010 +0 -1
@@ -113,7 +113,11 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks

I think this patch is based on another patch which hasn't been merged, right? Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev master branch, which HEAD is:
aae8fbec generic/270: wait for fsstress processes to be killed

Thanks,
Zorro

Quoted 22 lines
tests/xfs/010 +5 -0
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
tests/xfs/030 +2 -0
index 8f95331a..a270e36c 100755
@@ -43,6 +43,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
 			    -e '/^bad inobt block count/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^bad finobt block count/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'
#2 lore raw
Quoted 20 lines · Zorro Lang
Quoted 19 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Filter out the new AG header CRC verification warnings in xfs_repair since these tests were built before that existed.

---
 tests/xfs/010 |    6 +++++-
 tests/xfs/030 |    2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)
tests/xfs/010 +0 -0
index c341795d..ec23507a 100755
@@ -113,7 +113,11 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
Quoted 6 lines

tests/xfs/010 _check_scratch_fs · line 116

Quoted 1 line
tests/xfs/010 +0 -1
-_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks

I think this patch is based on another patch which hasn't been merged, right? Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev master branch, which HEAD is:
aae8fbec generic/270: wait for fsstress processes to be killed

Oops, yeah, I forgot that my development branch has multiple patches to those tests. Now that xfsprogs for-next has updated I guess I should clean all those up and send them for real.

--D

Quoted 26 lines

Thanks,
Zorro

Quoted 22 lines
tests/xfs/010 +5 -0
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
tests/xfs/030 +2 -0
index 8f95331a..a270e36c 100755
@@ -43,6 +43,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
 			    -e '/^bad inobt block count/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^bad finobt block count/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'