Skip to contentSkip to conversation

dt-bindings: hwmon: Correct vendor for mcp980x

PATCH In review Daniel M. Weeks 3 participants 6 messages Jul 3, 2020 – Jul 15, 2020

Subsystems (2)
Device tree bindings Hardware monitoring
lore
Share & tools
lore

Daniel M. Weeks

author
#0 lore raw

PATCH 1/1 dt-bindings: hwmon: Correct vendor for mcp980x

Signed-off-by Daniel M. Weeks <[email protected]>
---
 Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
 drivers/hwmon/lm75.c                             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/lm75.txt +1 -1
index 273616702c51..e5bb554cd2c3 100644
@@ -14,10 +14,10 @@ Required properties:
 		"maxim,max6626",
 		"maxim,max31725",
 		"maxim,max31726",
-		"maxim,mcp980x",
 		"nxp,pct2075",
 		"st,stds75",
 		"st,stlm75",
+		"microchip,mcp980x",
 		"microchip,tcn75",
 		"ti,tmp100",
 		"ti,tmp101",
drivers/hwmon/lm75.c +4 -4
index ba0be48aeadd..a8cfc7e4a685 100644
@@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "maxim,max31726",
 		.data = (void *)max31725
 	},
-	{
-		.compatible = "maxim,mcp980x",
-		.data = (void *)mcp980x
-	},
 	{
 		.compatible = "nxp,pct2075",
 		.data = (void *)pct2075

@@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "st,stlm75",
 		.data = (void *)stlm75
 	},
+	{
+		.compatible = "microchip,mcp980x",
+		.data = (void *)mcp980x
+	},
 	{
 		.compatible = "microchip,tcn75",
 		.data = (void *)tcn75
Signature · 1 line
Daniel M. Weeks
maintainer
#1 lore raw
Quoted 38 lines · Daniel M. Weeks
Signed-off-by Daniel M. Weeks <[email protected]>
---
 Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
 drivers/hwmon/lm75.c                             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/lm75.txt +1 -1
index 273616702c51..e5bb554cd2c3 100644
@@ -14,10 +14,10 @@ Required properties:
 		"maxim,max6626",
 		"maxim,max31725",
 		"maxim,max31726",
-		"maxim,mcp980x",
 		"nxp,pct2075",
 		"st,stds75",
 		"st,stlm75",
+		"microchip,mcp980x",
 		"microchip,tcn75",
 		"ti,tmp100",
 		"ti,tmp101",
drivers/hwmon/lm75.c +0 -4
index ba0be48aeadd..a8cfc7e4a685 100644
@@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "maxim,max31726",
 		.data = (void *)max31725
 	},
-	{
-		.compatible = "maxim,mcp980x",
-		.data = (void *)mcp980x
-	},
 	{
 		.compatible = "nxp,pct2075",
 		.data = (void *)pct2075

drivers/hwmon/lm75.c static const struct of_device_id __maybe_unused lm75_of_match[] = { · line 707

Quoted 6 lines
drivers/hwmon/lm75.c +3 -0
@@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "st,stlm75",
 		.data = (void *)stlm75
 	},
+	{
+		.compatible = "microchip,mcp980x",
+		.data = (void *)mcp980x

Hmm, makes me wonder if we should replace this with correct chip names since we are at it. After all, it only includes mcp980{0,1,2,3} and not mcp9805.

Rob, any thoughts ?

Guenter

Quoted 5 lines
drivers/hwmon/lm75.c +1 -0
+	},
 	{
 		.compatible = "microchip,tcn75",
 		.data = (void *)tcn75
maintainer
#2 lore raw
Quoted 49 lines · Guenter Roeck
Quoted 38 lines · Daniel M. Weeks
Signed-off-by Daniel M. Weeks <[email protected]>
---
 Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
 drivers/hwmon/lm75.c                             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/lm75.txt +1 -1
index 273616702c51..e5bb554cd2c3 100644
@@ -14,10 +14,10 @@ Required properties:
 		"maxim,max6626",
 		"maxim,max31725",
 		"maxim,max31726",
-		"maxim,mcp980x",
 		"nxp,pct2075",
 		"st,stds75",
 		"st,stlm75",
+		"microchip,mcp980x",
 		"microchip,tcn75",
 		"ti,tmp100",
 		"ti,tmp101",
drivers/hwmon/lm75.c +0 -4
index ba0be48aeadd..a8cfc7e4a685 100644
@@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "maxim,max31726",
 		.data = (void *)max31725
 	},
-	{
-		.compatible = "maxim,mcp980x",
-		.data = (void *)mcp980x
-	},
 	{
 		.compatible = "nxp,pct2075",
 		.data = (void *)pct2075

drivers/hwmon/lm75.c static const struct of_device_id __maybe_unused lm75_of_match[] = { · line 707

Quoted 6 lines
drivers/hwmon/lm75.c +3 -0
@@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "st,stlm75",
 		.data = (void *)stlm75
 	},
+	{
+		.compatible = "microchip,mcp980x",
+		.data = (void *)mcp980x

Hmm, makes me wonder if we should replace this with correct chip names since we are at it. After all, it only includes mcp980{0,1,2,3} and not mcp9805.

Quoted 1 line

Rob, any thoughts ?

Do we need to distinguish the chips? Aren't there existing users?

Rob

maintainer
#3 lore raw
Quoted 50 lines · Rob Herring
Quoted 49 lines · Guenter Roeck
Quoted 38 lines · Daniel M. Weeks
Signed-off-by Daniel M. Weeks <[email protected]>
---
 Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
 drivers/hwmon/lm75.c                             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/lm75.txt +1 -1
index 273616702c51..e5bb554cd2c3 100644
@@ -14,10 +14,10 @@ Required properties:
 		"maxim,max6626",
 		"maxim,max31725",
 		"maxim,max31726",
-		"maxim,mcp980x",
 		"nxp,pct2075",
 		"st,stds75",
 		"st,stlm75",
+		"microchip,mcp980x",
 		"microchip,tcn75",
 		"ti,tmp100",
 		"ti,tmp101",
drivers/hwmon/lm75.c +0 -4
index ba0be48aeadd..a8cfc7e4a685 100644
@@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "maxim,max31726",
 		.data = (void *)max31725
 	},
-	{
-		.compatible = "maxim,mcp980x",
-		.data = (void *)mcp980x
-	},
 	{
 		.compatible = "nxp,pct2075",
 		.data = (void *)pct2075

drivers/hwmon/lm75.c static const struct of_device_id __maybe_unused lm75_of_match[] = { · line 707

Quoted 6 lines
drivers/hwmon/lm75.c +3 -0
@@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "st,stlm75",
 		.data = (void *)stlm75
 	},
+	{
+		.compatible = "microchip,mcp980x",
+		.data = (void *)mcp980x

Hmm, makes me wonder if we should replace this with correct chip names since we are at it. After all, it only includes mcp980{0,1,2,3} and not mcp9805.

Quoted 4 lines
Quoted 1 line

Rob, any thoughts ?

Do we need to distinguish the chips? Aren't there existing users?

We don't specifically need to distinguish mcp908[0123], but "x" does not represent [0-9], only [0-3]. This driver does not support mcp9805, for example. I don't know how this kind of situation is handled in other drivers.

Looks like there are no existing in-kernel users. The initial entry for mcp980x was added back in 2008, with no DT support in mind. "maxim,mcp980x" was added with of_device_id table in 2017, with no one (including me) realizing that this is not a Maxim chip.

Guenter

maintainer
#4 lore raw
In reply to Daniel M. Weeks
Quoted 1 line · Daniel M. Weeks
Signed-off-by Daniel M. Weeks <[email protected]>

Commit message? Isn't this going to break any users? Or we rely on i2c stripping the vendor?

Quoted 49 lines
---
 Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
 drivers/hwmon/lm75.c                             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/lm75.txt +1 -1
index 273616702c51..e5bb554cd2c3 100644
@@ -14,10 +14,10 @@ Required properties:
 		"maxim,max6626",
 		"maxim,max31725",
 		"maxim,max31726",
-		"maxim,mcp980x",
 		"nxp,pct2075",
 		"st,stds75",
 		"st,stlm75",
+		"microchip,mcp980x",
 		"microchip,tcn75",
 		"ti,tmp100",
 		"ti,tmp101",
drivers/hwmon/lm75.c +4 -4
index ba0be48aeadd..a8cfc7e4a685 100644
@@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "maxim,max31726",
 		.data = (void *)max31725
 	},
-	{
-		.compatible = "maxim,mcp980x",
-		.data = (void *)mcp980x
-	},
 	{
 		.compatible = "nxp,pct2075",
 		.data = (void *)pct2075

@@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "st,stlm75",
 		.data = (void *)stlm75
 	},
+	{
+		.compatible = "microchip,mcp980x",
+		.data = (void *)mcp980x
+	},
 	{
 		.compatible = "microchip,tcn75",
 		.data = (void *)tcn75
Signature · 1 line
Daniel M. Weeks
maintainer
#5 lore raw
Quoted 6 lines · Rob Herring
Quoted 1 line · Daniel M. Weeks
Signed-off-by Daniel M. Weeks <[email protected]>

Commit message? Isn't this going to break any users? Or we rely on i2c stripping the vendor?

Looks like there are no in-kernel users.

Guenter

Quoted 49 lines
Quoted 49 lines
---
 Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
 drivers/hwmon/lm75.c                             | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/hwmon/lm75.txt +1 -1
index 273616702c51..e5bb554cd2c3 100644
@@ -14,10 +14,10 @@ Required properties:
 		"maxim,max6626",
 		"maxim,max31725",
 		"maxim,max31726",
-		"maxim,mcp980x",
 		"nxp,pct2075",
 		"st,stds75",
 		"st,stlm75",
+		"microchip,mcp980x",
 		"microchip,tcn75",
 		"ti,tmp100",
 		"ti,tmp101",
drivers/hwmon/lm75.c +4 -4
index ba0be48aeadd..a8cfc7e4a685 100644
@@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "maxim,max31726",
 		.data = (void *)max31725
 	},
-	{
-		.compatible = "maxim,mcp980x",
-		.data = (void *)mcp980x
-	},
 	{
 		.compatible = "nxp,pct2075",
 		.data = (void *)pct2075

@@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
 		.compatible = "st,stlm75",
 		.data = (void *)stlm75
 	},
+	{
+		.compatible = "microchip,mcp980x",
+		.data = (void *)mcp980x
+	},
 	{
 		.compatible = "microchip,tcn75",
 		.data = (void *)tcn75
Signature · 1 line
Daniel M. Weeks