Skip to contentSkip to conversation

package/libest: new package

PATCH In review Aleksandr Makarov 2 participants 2 messages Jul 15, 2020 – Jan 8, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libest: new package

libest is a C implementation of RFC 7030 (Enrollment over Secure Transport).

It can be used to provision public key certificates from a certificate authority (CA) or registration authority (RA) to end-user devices and network infrastructure devices.

https://github.com/cisco/libest

Notes on patches included in this package:

- libest bundles a stubbed version of libsafec, and has no provision to build against a system-installed full (non-stubbed) libsafec. We add a patch to make that possible.

- Added a configuration option --{enable,disable}-examples to toggle examples build by a separate patch.

- There's a configuration option --enable-jni which allows to build a JNI library for binding libest to Java programs. And that library would be using an outdated version of OpenSSL 1.0.
We fix that by adding support for OpenSSL 1.1 API for that library.

- Fixed a bug when specifying either --enable-FEATURE or --disable-FEATURE has always been enabling the feature.

---
Changes:
v1 -> v2:
Fixes suggested by Yann E. MORIN:

- Add notice in the commit message of the patches that we add.
- Swap libeXosip2 <-> libest in package/Config.in
- Remove series of AC_CHECK_HEADER for system libsafec headers.
- Use --disable-examples flag rather that removing examples from the Makefile lists.
- Remove per-feature config suboptions. Automatically enable features whose dependencies have been met.
- Use a Makefile github() function to acquire package sources.

New features:

- Add Config.in options to track bugged libest configurations:

- BR2_PACKAGE_LIBEST_WITH_LIBCOAP_BUGGED

Selecting libcoap package from the menuconfig list would try to enable --with-libcoap-dir option of libest, which would break libest compilation.

- BR2_PACKAGE_LIBEST_MODE_CLIENT_ONLY_WITH_OPENJDK_BUGGED

Selecting openjdk package and "client-only mode" suboption of libest would try to enable both libest --enable-client-only and --enable-jni configuration options.
That would break libest compilation as well.

---
 DEVELOPERS                                    |   3 +
 package/Config.in                             |   1 +
 ...client.c-add-support-for-OpenSSL-1.1.patch | 110 ++++++++++++
 ...le-examples-flag-to-toggle-examples-.patch |  88 ++++++++++
 ...libsafec-flag-to-link-against-system.patch | 107 ++++++++++++
 ...Fix-AC_ARG_ENABLE-AC_ARG_WITH-macros.patch | 162 ++++++++++++++++++
 package/libest/Config.in                      |  41 +++++
 package/libest/libest.hash                    |   3 +
 package/libest/libest.mk                      | 109 ++++++++++++
 package/libest/libest.pc                      |  10 ++
 10 files changed, 634 insertions(+)
 create mode 100644 package/libest/0001-java-jni-client.c-add-support-for-OpenSSL-1.1.patch
 create mode 100644 package/libest/0002-Add-enable-disable-examples-flag-to-toggle-examples-.patch
 create mode 100644 package/libest/0003-Add-with-system-libsafec-flag-to-link-against-system.patch
 create mode 100644 package/libest/0004-configure.ac-Fix-AC_ARG_ENABLE-AC_ARG_WITH-macros.patch
 create mode 100644 package/libest/Config.in
 create mode 100644 package/libest/libest.hash
 create mode 100644 package/libest/libest.mk
 create mode 100644 package/libest/libest.pc
DEVELOPERS +3 -0
index efbb676b48..1551743ef6 100644
@@ -142,6 +142,9 @@ F:	package/minimodem/
 N:	Alexander Lukichev <[email protected]>
 F:	package/openpgm/
 
+N:	Aleksandr Makarov <[email protected]>
+F:	package/libest/
+
 N:	Alexander Mukhin <[email protected]>
 F:	package/tinyproxy/
 
package/Config.in +1 -0
index aafaa312a1..44b2cbec0e 100644
@@ -1684,6 +1684,7 @@ menu "Networking"
 	source "package/libcurl/Config.in"
 	source "package/libdnet/Config.in"
 	source "package/libeXosip2/Config.in"
+	source "package/libest/Config.in"
 	source "package/libfcgi/Config.in"
 	source "package/libgsasl/Config.in"
 	source "package/libhtp/Config.in"
package/libest/0001-java-jni-client.c-add-support-for-OpenSSL-1.1.patch new file +110 -0

110 lines not on this page · raw message

package/libest/0002-Add-enable-disable-examples-flag-to-toggle-examples-.patch new file +88 -0

88 lines not on this page · raw message

package/libest/0003-Add-with-system-libsafec-flag-to-link-against-system.patch new file +107 -0

107 lines not on this page · raw message

package/libest/0004-configure.ac-Fix-AC_ARG_ENABLE-AC_ARG_WITH-macros.patch new file +162 -0

162 lines not on this page · raw message

package/libest/Config.in new file +41 -0

41 lines not on this page · raw message

package/libest/libest.hash new file +3 -0
new file mode 100644
index 0000000000..c902a9568f
@@ -0,0 +1,3 @@
+# Computed locally
+sha256  324b3a2b16cd14ea4234d75fa90f08b29509bac9cd3795c44268e22f906ee0ad  libest-3.2.0.tar.gz
+sha256  fbdb055f98babf8d86095d6f9b9e34d2ff21a8212e442b8f18bdcb403e44366c  LICENSE
package/libest/libest.mk new file +109 -0

109 lines not on this page · raw message

package/libest/libest.pc new file +10 -0
new file mode 100644
index 0000000000..166240f9d1
@@ -0,0 +1,10 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: libest
+Description: implementation of RFC 7030 (Enrollment over Secure Transport) 
+Version: 2.1.0
+Libs: -lest
+Cflags: -I${includedir}/est
Signature · 1 line
2.27.0
#1 lore raw

Hello Aleksandr,

Quoted 18 lines · On Wed, 15 Jul 2020 16:35:14 -0600 Aleksandr Makarov…

libest is a C implementation of RFC 7030 (Enrollment over Secure Transport).

It can be used to provision public key certificates from a certificate authority (CA) or registration authority (RA) to end-user devices and network infrastructure devices.

https://github.com/cisco/libest

Notes on patches included in this package:

- libest bundles a stubbed version of libsafec, and has no provision to build against a system-installed full (non-stubbed) libsafec. We add a patch to make that possible.

- Added a configuration option --{enable,disable}-examples to toggle examples build by a separate patch.

Quoted 7 lines

- There's a configuration option --enable-jni which allows to build a JNI library for binding libest to Java programs. And that library would be using an outdated version of OpenSSL 1.0.
We fix that by adding support for OpenSSL 1.1 API for that library.

- Fixed a bug when specifying either --enable-FEATURE or --disable-FEATURE has always been enabling the feature.

Sorry for the long delay. I finally applied your patch, but after making some significant changes:

[Thomas:
- Added comments about the upstream status in existing patches
- Added a patch fixing an autoreconf issue
- Added a patch adding a missing "extern" on a variable to fix build with gcc 10
- Removed the glibc dependency by using the new libexecinfo package
- Drastically simplified the complex libcoap disabling and client-only mode vs. OpenJDK issue. libcoap support is now forcefully disabled, and client-mode only option is made invisible when OpenJDK is enabled.
- Fixed the license information;
- Added missing host-pkgconf
]

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot