Skip to contentSkip to conversation

crypto/qat: use better variable names in CRC functions

PATCH Applied David Coyle 3 participants 3 messages Jul 16, 2020 – Jul 18, 2020 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/qat: use better variable names in CRC functions

The variable names crc_length and crc_offset have been changed to crc_data_len and crc_data_ofs respectively, to make it clearer as to their use i.e. the length and offset of the data over which the CRC is calculated.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")
---
 drivers/crypto/qat/qat_sym.c |  8 ++++----
 drivers/crypto/qat/qat_sym.h | 13 +++++++------
 2 files changed, 11 insertions(+), 10 deletions(-)
drivers/crypto/qat/qat_sym.c +4 -4
index 6d568ab8f..fe5c85c34 100644
@@ -108,18 +108,18 @@ qat_crc_generate(struct qat_sym_session *ctx,
 			struct rte_crypto_op *op)
 {
 	struct rte_crypto_sym_op *sym_op = op->sym;
-	uint32_t *crc, crc_length;
+	uint32_t *crc, crc_data_len;
 	uint8_t *crc_data;
 
 	if (ctx->qat_dir == ICP_QAT_HW_CIPHER_ENCRYPT &&
 			sym_op->auth.data.length != 0) {
 
-		crc_length = sym_op->auth.data.length;
+		crc_data_len = sym_op->auth.data.length;
 		crc_data = rte_pktmbuf_mtod_offset(sym_op->m_src, uint8_t *,
 				sym_op->auth.data.offset);
-		crc = (uint32_t *)(crc_data + crc_length);
+		crc = (uint32_t *)(crc_data + crc_data_len);
 
-		*crc = rte_net_crc_calc(crc_data, crc_length,
+		*crc = rte_net_crc_calc(crc_data, crc_data_len,
 				RTE_NET_CRC32_ETH);
 	}
 }
drivers/crypto/qat/qat_sym.h +7 -6
index dbca74efb..7934dd478 100644
@@ -140,20 +140,21 @@ static inline void
 qat_crc_verify(struct qat_sym_session *ctx, struct rte_crypto_op *op)
 {
 	struct rte_crypto_sym_op *sym_op = op->sym;
-	uint32_t crc_offset, crc_length, crc;
+	uint32_t crc_data_ofs, crc_data_len, crc;
 	uint8_t *crc_data;
 
 	if (ctx->qat_dir == ICP_QAT_HW_CIPHER_DECRYPT &&
 			sym_op->auth.data.length != 0) {
 
-		crc_offset = sym_op->auth.data.offset;
-		crc_length = sym_op->auth.data.length;
+		crc_data_ofs = sym_op->auth.data.offset;
+		crc_data_len = sym_op->auth.data.length;
 		crc_data = rte_pktmbuf_mtod_offset(sym_op->m_src, uint8_t *,
-				crc_offset);
+				crc_data_ofs);
 
-		crc = rte_net_crc_calc(crc_data, crc_length, RTE_NET_CRC32_ETH);
+		crc = rte_net_crc_calc(crc_data, crc_data_len,
+				RTE_NET_CRC32_ETH);
 
-		if (crc != *(uint32_t *)(crc_data + crc_length))
+		if (crc != *(uint32_t *)(crc_data + crc_data_len))
 			op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
 	}
 }
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines

-----Original Message-----
From: Coyle, David <[email protected]>
Sent: Thursday, July 16, 2020 4:35 PM
To: [email protected]; Doherty, Declan <[email protected]>; Trahe, Fiona <[email protected]>
Cc: [email protected]; Ryan, Brendan <[email protected]>; O'loingsigh, Mairtin <[email protected]>; De Lara Guarch, Pablo <[email protected]>; Coyle, David <[email protected]>
Subject: [PATCH v1] crypto/qat: use better variable names in CRC functions

Quoted 8 lines

The variable names crc_length and crc_offset have been changed to crc_data_len and crc_data_ofs respectively, to make it clearer as to their use i.e. the length and offset of the data over which the CRC is calculated.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")
Applied
#2 lore raw
Quoted 9 lines
Quoted 8 lines

The variable names crc_length and crc_offset have been changed to crc_data_len and crc_data_ofs respectively, to make it clearer as to their use i.e. the length and offset of the data over which the CRC is calculated.

Fixes 6f0ef237404b ("crypto/qat: support DOCSIS protocol")

Applied to dpdk-next-crypto

Thanks.