Skip to contentSkip to conversation

PCI: rcar-gen2: Use fallthrough pseudo-keyword

PATCH Superseded Gustavo A. R. Silva 3 participants 3 messages Jul 16, 2020 – Jul 22, 2020

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: rcar-gen2: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

---
 drivers/pci/controller/pci-rcar-gen2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-rcar-gen2.c +1 -1
index 326171cb1a97..2ec7093a7588 100644
@@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
 		pr_warn("unknown window size %ld - defaulting to 256M\n",
 			priv->window_size);
 		priv->window_size = SZ_256M;
-		/* fall-through */
+		fallthrough;
 	case SZ_256M:
 		val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
 		break;
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Gustavo,

Thanks for your patch!

Quoted 3 lines · Gustavo A. R. Silva

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.

Which unnecessary marking is being removed?
I don't see any.

Quoted 4 lines

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

For the actual patch contents:

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw

Hi Geert,

Quoted 4 lines · Geert Uytterhoeven

Hi Gustavo,

Thanks for your patch!

Quoted 9 lines
Quoted 3 lines · Gustavo A. R. Silva

Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.

Which unnecessary marking is being removed?
I don't see any.

There is none. I will remove those lines and send v2 with a URL to the proper documentation for Linux v5.7 instead of 'lastest', see:

https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

I'll add your Reviewed-by tag. :)

Quoted 8 lines
Quoted 4 lines

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

For the actual patch contents:

Thanks!
--
Gustavo