Skip to contentSkip to conversation

package/lm-sensors: always pass TARGET_CONFIGURE_OPTS

PATCH New Fabrice Fontaine 2 participants 2 messages Jul 13, 2020 – Jul 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lm-sensors: always pass TARGET_CONFIGURE_OPTS

lm-sensors dropped MACHINE variable since version 3.6.0 and
https://github.com/lm-sensors/lm-sensors/commit/0863eff8fa1d32797e3aec19672878aff893b0ae
instead it uses $(CC) -dumpmachine to guess the architecture

However, as $(TARGET_CONFIGURE_OPTS) is only passed to build step and not to install steps, this result in some binaries being built for the host during install step and raising a build failure on some autobuilders

Fixes:
- http://autobuild.buildroot.org/results/0180989afdd9272ecd5010a787931e0b10a6cdcf

---
 package/lm-sensors/lm-sensors.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/lm-sensors/lm-sensors.mk +2 -2
index a69ca6e2bf..8975efaffa 100644
@@ -20,7 +20,7 @@ LM_SENSORS_BINS_$(BR2_PACKAGE_LM_SENSORS_PWMCONFIG) += sbin/pwmconfig
 LM_SENSORS_BINS_$(BR2_PACKAGE_LM_SENSORS_SENSORS_DETECT) += sbin/sensors-detect
 
 LM_SENSORS_MAKE_OPTS = \
-	MACHINE=$(KERNEL_ARCH) \
+	$(TARGET_CONFIGURE_OPTS) \
 	PREFIX=/usr
 
 ifeq ($(BR2_STATIC_LIBS),y)
@@ -36,7 +36,7 @@ LM_SENSORS_MAKE_OPTS += BUILD_STATIC_LIB=1
 endif
 
 define LM_SENSORS_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LM_SENSORS_MAKE_OPTS) -C $(@D)
+	$(TARGET_MAKE_ENV) $(MAKE) $(LM_SENSORS_MAKE_OPTS) -C $(@D)
 endef
 
 define LM_SENSORS_INSTALL_STAGING_CMDS
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/lm-sensors: always pass TARGET_CONFIGURE_OPTS

Quoted 8 lines · On Mon, 13 Jul 2020 11:37:29 +0200 Fabrice Fontaine…

lm-sensors dropped MACHINE variable since version 3.6.0 and
https://github.com/lm-sensors/lm-sensors/commit/0863eff8fa1d32797e3aec19672878aff893b0ae
instead it uses $(CC) -dumpmachine to guess the architecture

However, as $(TARGET_CONFIGURE_OPTS) is only passed to build step and not to install steps, this result in some binaries being built for the host during install step and raising a build failure on some autobuilders

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/0180989afdd9272ecd5010a787931e0b10a6cdcf

---
 package/lm-sensors/lm-sensors.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com