Skip to contentSkip to conversation

usb: only build hcd-dwc2 host controller for RASPI target

PATCH In review Paul Zimmerman 2 participants 2 messages Jul 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: only build hcd-dwc2 host controller for RASPI target

The hcd-dwc2 host controller is currently built for all targets. Since for now hcd-dwc2 is only implemented on RASPI, restrict its build to that target only.

---

Hi Gerd,

Do we want to apply this before the 5.1.0 release? It seems a waste to build this code for every target when it's only used on one. Sorry I didn't realize this earlier.

Thanks,
Paul

 hw/arm/Kconfig | 1 +
 hw/usb/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
hw/arm/Kconfig +1 -0
index 4a224a6351..bc3a423940 100644
@@ -315,6 +315,7 @@ config RASPI
     select FRAMEBUFFER
     select PL011 # UART
     select SDHCI
+    select USB_DWC2
 
 config STM32F205_SOC
     bool
hw/usb/Kconfig +0 -1
index d4d8c37c28..5e63dc75f8 100644
@@ -48,7 +48,6 @@ config USB_MUSB
 
 config USB_DWC2
     bool
-    default y
     select USB
 
 config TUSB6010
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Paul Zimmerman

The hcd-dwc2 host controller is currently built for all targets. Since for now hcd-dwc2 is only implemented on RASPI, restrict its build to that target only.

Quoted 8 lines

---

Hi Gerd,

Do we want to apply this before the 5.1.0 release? It seems a waste to build this code for every target when it's only used on one. Sorry I didn't realize this earlier.

Not a big deal ;)

Quoted 33 lines

Thanks,
Paul

 hw/arm/Kconfig | 1 +
 hw/usb/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
hw/arm/Kconfig +1 -0
index 4a224a6351..bc3a423940 100644
@@ -315,6 +315,7 @@ config RASPI
     select FRAMEBUFFER
     select PL011 # UART
     select SDHCI
+    select USB_DWC2
 
 config STM32F205_SOC
     bool
hw/usb/Kconfig +0 -1
index d4d8c37c28..5e63dc75f8 100644
@@ -48,7 +48,6 @@ config USB_MUSB
 
 config USB_DWC2
     bool
-    default y
     select USB
 
 config TUSB6010