Skip to contentSkip to conversation

efi_loader: signature: rework for intermediate

PATCH New REITHER Robert - Contractor 2 participants 2 messages Jul 16, 2020 – Jul 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 7/8 efi_loader: signature: rework for intermediate

Hi,

I think I have found a bug in
lib/efi_loader/efi_signature.c

efi_verify_certificate()

+ cert = x509_cert_parse(sig_data->data, sig_data->size);
+ if (!cert) {
+ EFI_PRINT("Cannot parse x509 certificate\n");
+ continue;
+ }

x509_cert_parse() not only returns a pointer, but also embed a linux error_code, so if an error happens there, the (!cert) check will fail!

I suggest using:

- if (!cert) {
+ if (IS_ERR(cert)) {

Regards
Robert

#1 lore raw

PATCH v3 7/8 efi_loader: signature: rework for intermediate

Quoted 18 lines · REITHER Robert - Contractor

Hi,

I think I have found a bug in
lib/efi_loader/efi_signature.c

efi_verify_certificate()

(quoted diff) +5 -0
+                                             cert = x509_cert_parse(sig_data->data, sig_data->size);
+                                             if (!cert) {
+                                                            EFI_PRINT("Cannot parse x509 certificate\n");
+                                                            continue;
+                                             }

x509_cert_parse() not only returns a pointer, but also embed a linux error_code, so if an error happens there, the (!cert) check will fail!

I suggest using:

Review

Quoted 2 lines
(quoted diff) +1 -1
-                                              if (!cert) {
+                                            if (IS_ERR(cert)) {

That's correct.
Can you post a fix patch, please?

# There was the same problem with pkcs7_parse_message(),

# and I have fixed it before.

Thanks,
-Takahiro Akashi

Quoted 3 lines

Regards
Robert