usb: gadget: configfs: Fix use-after-free issue with udc_name
Subsystems (3)
PATCH 1/1 usb: gadget: configfs: Fix use-after-free issue with udc_name
There is a use-after-free issue, if access udc_name in function gadget_dev_desc_UDC_store after another context free udc_name in function unregister_gadget.
Contex 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> free udc_name->set udc_name to NULL
Contex 2:
gadget_dev_desc_UDC_show()-> access udc_name
Call trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38
Add mutex_lock to protect this kind of scenario.
--- drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/usb/gadget/configfs.c +9 -2
@@ -221,9 +221,16 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item,static ssize_t gadget_dev_desc_UDC_show (struct config_item *item,char *page) { -char *udc_name =to_gadget_info (item)->composite.gadget_driver.udc_name; +struct gadget_info *gi =to_gadget_info (item); +char *udc_name; +int ret; + +mutex_lock (&gi->lock); + udc_name = gi->composite.gadget_driver.udc_name; + ret =sprintf (page,"%s\n" , udc_name ?:"" ); +mutex_unlock (&gi->lock); -return sprintf (page,"%s\n" , udc_name ?:"" ); +return ret; }static int unregister_gadget (struct gadget_info *gi)
Signature · 1 line
2.18.0
Quoted 5 lines · Macpaul Lin
There is a use-after-free issue, if access
udc_namein functiongadget_dev_desc_UDC_storeafter another context freeudc_namein functionunregister_gadget.Contex 1:
%s/contex/context
Quoted 4 lines
gadget_dev_desc_UDC_store()->unregister_gadget()-> free
udc_name->setudc_nameto NULLContex 2:
The same, otherwise:
Peter
Quoted 55 lines
gadget_dev_desc_UDC_show()-> access
udc_nameCall trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38Add
mutex_lockto protect this kind of scenario.Signed-off-by Eddie Hung <[email protected]>Signed-off-by Macpaul Lin <[email protected]>--- drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)drivers/usb/gadget/configfs.c +9
-2@@ -221,9 +221,16 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item,static ssize_t gadget_dev_desc_UDC_show (struct config_item *item,char *page) { -char *udc_name =to_gadget_info (item)->composite.gadget_driver.udc_name; +struct gadget_info *gi =to_gadget_info (item); +char *udc_name; +int ret; + +mutex_lock (&gi->lock); + udc_name = gi->composite.gadget_driver.udc_name; + ret =sprintf (page,"%s\n" , udc_name ?:"" ); +mutex_unlock (&gi->lock); -return sprintf (page,"%s\n" , udc_name ?:"" ); +return ret; }static int unregister_gadget (struct gadget_info *gi)Signature · 1 line
2.18.0
Signature · 2 lines
Thanks, Peter Chen
PATCH v2 1/1 usb: gadget: configfs: Fix use-after-free issue with udc_name
In reply to Macpaul LinFrom: Eddie Hung <[email protected]>
There is a use-after-free issue, if access udc_name in function gadget_dev_desc_UDC_store after another context free udc_name in function unregister_gadget.
Context 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> free udc_name->set udc_name to NULL
Context 2:
gadget_dev_desc_UDC_show()-> access udc_name
Call trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38
Add mutex_lock to protect this kind of scenario.
---
Changes for v2:
- Fix typo %s/contex/context, Thanks Peter.
drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/usb/gadget/configfs.c +9 -2
@@ -221,9 +221,16 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item,static ssize_t gadget_dev_desc_UDC_show (struct config_item *item,char *page) { -char *udc_name =to_gadget_info (item)->composite.gadget_driver.udc_name; +struct gadget_info *gi =to_gadget_info (item); +char *udc_name; +int ret; + +mutex_lock (&gi->lock); + udc_name = gi->composite.gadget_driver.udc_name; + ret =sprintf (page,"%s\n" , udc_name ?:"" ); +mutex_unlock (&gi->lock); -return sprintf (page,"%s\n" , udc_name ?:"" ); +return ret; }static int unregister_gadget (struct gadget_info *gi)
Signature · 1 line
2.18.0
Quoted 2 lines · Macpaul Lin
From: Eddie Hung <[email protected]>
Well, it's strange, I simply replaced the uploader's name to my colleague, git send-email pop up this line automatically.
Shouldn't I do that kind of change. It did not happened before. Do I need to change it back and update patch v3?
Quoted 35 lines
There is a use-after-free issue, if access
udc_namein functiongadget_dev_desc_UDC_storeafter another context freeudc_namein functionunregister_gadget.Context 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> freeudc_name->setudc_nameto NULLContext 2:
gadget_dev_desc_UDC_show()-> accessudc_nameCall trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38Add
mutex_lockto protect this kind of scenario.Signed-off-by Eddie Hung <[email protected]>Signed-off-by Macpaul Lin <[email protected]>Reviewed-by Peter Chen <[email protected]>
Quoted 6 lines
---
Changes for v2:
- Fix typo %s/contex/context, Thanks Peter.drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
Thanks.
Macpaul Lin
Greg Kroah-Hartman
maintainerQuoted 9 lines · Macpaul Lin
Quoted 2 lines · Macpaul Lin
From: Eddie Hung <[email protected]>
Well, it's strange, I simply replaced the uploader's name to my colleague, git send-email pop up this line automatically.
Shouldn't I do that kind of change. It did not happened before. Do I need to change it back and update patch v3?
Who is the real author of this, Eddie or you? If Eddie, this is correct, if you, it is not.
thanks,
greg k-h
Quoted 11 lines · Greg Kroah-Hartman
Quoted 9 lines · Macpaul Lin
Quoted 2 lines · Macpaul Lin
From: Eddie Hung <[email protected]>
Well, it's strange, I simply replaced the uploader's name to my colleague, git send-email pop up this line automatically.
Shouldn't I do that kind of change. It did not happened before. Do I need to change it back and update patch v3?
Quoted 6 lines
Who is the real author of this, Eddie or you? If Eddie, this is correct, if you, it is not.
thanks,
greg k-h
It is Eddie! I just changed the uploader to the correct author from my working tree!
Thanks!
Regards,
Macpaul Lin
Quoted 56 lines · Macpaul Lin
From: Eddie Hung <[email protected]>
There is a use-after-free issue, if accessudc_namein functiongadget_dev_desc_UDC_storeafter another context freeudc_namein functionunregister_gadget.Context 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> freeudc_name->setudc_nameto NULLContext 2:
gadget_dev_desc_UDC_show()-> accessudc_nameCall trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38Add
mutex_lockto protect this kind of scenario.Signed-off-by Eddie Hung <[email protected]>Signed-off-by Macpaul Lin <[email protected]>Reviewed-by Peter Chen <[email protected]>---
Changes for v2:
- Fix typo %s/contex/context, Thanks Peter.drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)drivers/usb/gadget/configfs.c +4
-1@@ -221,9 +221,16 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item,static ssize_t gadget_dev_desc_UDC_show (struct config_item *item,char *page) { -char *udc_name =to_gadget_info (item)->composite.gadget_driver.udc_name; +struct gadget_info *gi =to_gadget_info (item); +char *udc_name; +int ret; +
drivers/usb/gadget/configfs.c static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item, · line 236
Quoted 10 lines
drivers/usb/gadget/configfs.c +5
-1+mutex_lock (&gi->lock); + udc_name = gi->composite.gadget_driver.udc_name; + ret =sprintf (page,"%s\n" , udc_name ?:"" ); +mutex_unlock (&gi->lock); -return sprintf (page,"%s\n" , udc_name ?:"" ); +return ret; }static int unregister_gadget (struct gadget_info *gi)
Just want to remind we have a fix here for usb/gadget/configfs.c. If the patch need to be further revised, please let us know.
Thanks!
Macpaul Lin
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi,
Quoted 31 lines · Macpaul Lin
From: Eddie Hung <[email protected]>
There is a use-after-free issue, if access
udc_namein functiongadget_dev_desc_UDC_storeafter another context freeudc_namein functionunregister_gadget.Context 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> freeudc_name->setudc_nameto NULLContext 2:
gadget_dev_desc_UDC_show()-> accessudc_nameCall trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38
Quoted 6 lines
Add
mutex_lockto protect this kind of scenario.Signed-off-by Eddie Hung <[email protected]>Signed-off-by Macpaul Lin <[email protected]>Reviewed-by Peter Chen <[email protected]>
patch doesn't apply:
$ patch -p1 --dry-run /usr/bin/patch: **** Only garbage was found in the patch input.
Please resend using git send-email and make sure your smtp server sends it as plain text, not base64.
Signature · 1 line
balbi
PATCH RESEND v2 1/1 usb: gadget: configfs: Fix use-after-free issue with udc_name
In reply to Macpaul LinFrom: Eddie Hung <[email protected]>
There is a use-after-free issue, if access udc_name in function gadget_dev_desc_UDC_store after another context free udc_name in function unregister_gadget.
Context 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> free udc_name->set udc_name to NULL
Context 2:
gadget_dev_desc_UDC_show()-> access udc_name
Call trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38
Add mutex_lock to protect this kind of scenario.
---
Changes for v2:
- Fix typo %s/contex/context, Thanks Peter.
drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/usb/gadget/configfs.c +9 -2
@@ -230,9 +230,16 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item,static ssize_t gadget_dev_desc_UDC_show (struct config_item *item,char *page) { -char *udc_name =to_gadget_info (item)->composite.gadget_driver.udc_name; +struct gadget_info *gi =to_gadget_info (item); +char *udc_name; +int ret; + +mutex_lock (&gi->lock); + udc_name = gi->composite.gadget_driver.udc_name; + ret =sprintf (page,"%s\n" , udc_name ?:"" ); +mutex_unlock (&gi->lock); -return sprintf (page,"%s\n" , udc_name ?:"" ); +return ret; }static int unregister_gadget (struct gadget_info *gi)
Signature · 1 line
2.26.2
PATCH RESEND v2 1/1 usb: gadget: configfs: Fix use-after-free issue with udc_name
In reply to Macpaul LinFrom: Eddie Hung <[email protected]>
There is a use-after-free issue, if access udc_name in function gadget_dev_desc_UDC_store after another context free udc_name in function unregister_gadget.
Context 1:
gadget_dev_desc_UDC_store()->unregister_gadget()-> free udc_name->set udc_name to NULL
Context 2:
gadget_dev_desc_UDC_show()-> access udc_name
Call trace: dump_backtrace+0x0/0x340 show_stack+0x14/0x1c dump_stack+0xe4/0x134 print_address_description+0x78/0x478 __kasan_report+0x270/0x2ec kasan_report+0x10/0x18 __asan_report_load1_noabort+0x18/0x20 string+0xf4/0x138 vsnprintf+0x428/0x14d0 sprintf+0xe4/0x12c gadget_dev_desc_UDC_show+0x54/0x64 configfs_read_file+0x210/0x3a0 __vfs_read+0xf0/0x49c vfs_read+0x130/0x2b4 SyS_read+0x114/0x208 el0_svc_naked+0x34/0x38
Add mutex_lock to protect this kind of scenario.
---
Changes for v2:
- Fix typo %s/contex/context, Thanks Peter.
drivers/usb/gadget/configfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/usb/gadget/configfs.c +9 -2
@@ -221,9 +221,16 @@ static ssize_t gadget_dev_desc_bcdUSB_store(struct config_item *item,static ssize_t gadget_dev_desc_UDC_show (struct config_item *item,char *page) { -char *udc_name =to_gadget_info (item)->composite.gadget_driver.udc_name; +struct gadget_info *gi =to_gadget_info (item); +char *udc_name; +int ret; + +mutex_lock (&gi->lock); + udc_name = gi->composite.gadget_driver.udc_name; + ret =sprintf (page,"%s\n" , udc_name ?:"" ); +mutex_unlock (&gi->lock); -return sprintf (page,"%s\n" , udc_name ?:"" ); +return ret; }static int unregister_gadget (struct gadget_info *gi)
Signature · 1 line
1.7.9.5