ext4/309: Test read-only external journal device
PATCH 1/1 ext4/309: Test read-only external journal device
We should never be able to mount ext4 file system read-write with read-only external journal device. Test it.
The test was based on generic/050.
--- tests/ext4/309 | 135 +++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/309.out | 32 +++++++++++ tests/ext4/group | 1 + 3 files changed, 168 insertions(+) create mode 100755 tests/ext4/309 create mode 100644 tests/ext4/309.out
tests/ext4/309 new file +135 -0
@@ -0,0 +1,135 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2009 Christoph Hellwig. +# Copyright (c) 2020 Lukas Czerner. +# +# FS QA Test No. 309 +# +# Copied from tests generic/050 and adjusted to support testing +# read-only external journal device on ext4. +# +# Check out various mount/remount/unmount scenarious on a read-only +# logdev blockdev. +# +seqfull=$0 +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + cd / + blockdev --setrw $SCRATCH_LOGDEV +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +_require_scratch_nocheck +_require_scratch_shutdown +_require_logdev +_require_local_device $SCRATCH_DEV +_require_local_device $SCRATCH_LOGDEV +_require_norecovery + +_scratch_mkfs >/dev/null 2>&1 +_require_metadata_journaling $SCRATCH_DEV + +# +# Mark the log device read-only +# +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mount it, and make sure we can't write to it, and we can unmount it again +# +echo "mounting with read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch +if [ "${PIPESTATUS[0]}" -eq 0 ]; then + echo "touching file on read-only filesystem (should fail)" + touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch +fi + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +echo "mounting with read-write log device:" +_try_scratch_mount 2>&1 | _filter_scratch + +echo "touch files" +touch $SCRATCH_MNT/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9} + +echo "going down:" +_scratch_shutdown -f + +echo "unmounting shutdown filesystem:" +_scratch_unmount 2>&1 | _filter_scratch + +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mounting a filesystem that requires log-recovery fails even with +# -o norecovery unless the fs device is read only or it's mounted +# read only +# +echo "mounting filesystem that needs recovery with a read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + + +echo "mounting filesystem with -o norecovery with a read-only log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +# +# This is the way out if the log device really is read-only. +# Doesn't mean it's a good idea in practice, more a last resort +# data recovery hack. Either the underlying fs device needs +# to be read only as well, or we mount the file system read only +# +echo "setting fs device read-only" +blockdev --setro $SCRATCH_DEV +echo "mounting filesystem with -o norecovery with a read-only fs and log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot +echo "setting fs device read-write" +blockdev --setrw $SCRATCH_DEV + +echo "mounting filesystem with -o norecovery,ro with a read-only log device:" +_try_scratch_mount -o norecovery,ro 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +# +# But log recovery is performed when mount with -o ro as long as +# the underlying device is not write protected. +# +echo "mounting filesystem that needs recovery with -o ro:" +_try_scratch_mount -o ro 2>&1 | _filter_scratch + +# success, all done +echo "*** done" +rm -f $seqres.full +status=0
tests/ext4/309.out new file +32 -0
@@ -0,0 +1,32 @@ +QA output created by 309 +setting log device read-only +mounting with read-only log device: +mount: device write-protected, mounting read-only +touching file on read-only filesystem (should fail) +touch: cannot touch 'SCRATCH_MNT/foo': Read-only file system +unmounting read-only filesystem +setting log device read-write +mounting with read-write log device: +touch files +going down: +unmounting shutdown filesystem: +setting log device read-only +mounting filesystem that needs recovery with a read-only log device: +mount: device write-protected, mounting read-only +mount: cannot mount device read-only +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +mounting filesystem with -o norecovery with a read-only log device: +mount: SCRATCH_MNT: wrong fs type, bad option, bad superblock on SCRATCH_DEV, missing codepage or helper program, or other error +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +setting fs device read-only +mounting filesystem with -o norecovery with a read-only fs and log device: +mount: device write-protected, mounting read-only +unmounting read-only filesystem +setting fs device read-write +mounting filesystem with -o norecovery,ro with a read-only log device: +unmounting read-only filesystem +setting log device read-write +mounting filesystem that needs recovery with -o ro: +*** done
tests/ext4/group +1 -0
@@ -56,3 +56,4 @@ 306 auto rw resize quick 307 auto ioctl rw defrag 308 auto ioctl rw prealloc quick defrag +309 shutdown mount auto quick
Signature · 1 line
2.21.3
[cc ext4 list for ext4 specific test]
Quoted 6 lines · Lukas Czerner
We should never be able to mount ext4 file system read-write with read-only external journal device. Test it.
The test was based on generic/050.
Signed-off-by Lukas Czerner <[email protected]>
Is there a patch or kernel commit that fixes this test failure? I'd be better to mention the patch in either commit log or test description, so others could know where is the fix easily.
Quoted 3 lines
--- tests/ext4/309 | 135 +++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/309.out | 32 +++++++++++
And use next available seq slot under ext4 dir, use "./tools/nextid ext4" to get the next available slot, which is 002 at this point.
Quoted 27 lines
tests/ext4/group | 1 + 3 files changed, 168 insertions(+) create mode 100755 tests/ext4/309 create mode 100644 tests/ext4/309.outtests/ext4/309 new file +16
-0@@ -0,0 +1,135 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2009 Christoph Hellwig. +# Copyright (c) 2020 Lukas Czerner. +# +# FS QA Test No. 309 +# +# Copied from tests generic/050 and adjusted to support testing +# read-only external journal device on ext4. +# +# Check out various mount/remount/unmount scenarious on a read-only +# logdev blockdev. +# +seqfull=$0 +seq=`basename $0` +seqres=$RESULT_DIR/$seq
tests/ext4/309 line 26
Quoted 10 lines
tests/ext4/309 new file +10
-0+echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + cd / + blockdev --setrw $SCRATCH_LOGDEV
Do 'blockdev --setrw $SCRATCH_DEV' here as well to make sure both LOGDEV and SCRATCH_DEV are set back to rw mode.
tests/ext4/309 line 35
Quoted 9 lines
tests/ext4/309 new file +9
-0+} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic
_supported_fs ext4
Otherwise looks fine to me.
Thanks,
Eryu
Quoted 149 lines
tests/ext4/309 new file +100
-0+_supported_os Linux + +_require_scratch_nocheck +_require_scratch_shutdown +_require_logdev +_require_local_device $SCRATCH_DEV +_require_local_device $SCRATCH_LOGDEV +_require_norecovery + +_scratch_mkfs >/dev/null 2>&1 +_require_metadata_journaling $SCRATCH_DEV + +# +# Mark the log device read-only +# +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mount it, and make sure we can't write to it, and we can unmount it again +# +echo "mounting with read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch +if [ "${PIPESTATUS[0]}" -eq 0 ]; then + echo "touching file on read-only filesystem (should fail)" + touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch +fi + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +echo "mounting with read-write log device:" +_try_scratch_mount 2>&1 | _filter_scratch + +echo "touch files" +touch $SCRATCH_MNT/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9} + +echo "going down:" +_scratch_shutdown -f + +echo "unmounting shutdown filesystem:" +_scratch_unmount 2>&1 | _filter_scratch + +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mounting a filesystem that requires log-recovery fails even with +# -o norecovery unless the fs device is read only or it's mounted +# read only +# +echo "mounting filesystem that needs recovery with a read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + + +echo "mounting filesystem with -o norecovery with a read-only log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +# +# This is the way out if the log device really is read-only. +# Doesn't mean it's a good idea in practice, more a last resort +# data recovery hack. Either the underlying fs device needs +# to be read only as well, or we mount the file system read only +# +echo "setting fs device read-only" +blockdev --setro $SCRATCH_DEV +echo "mounting filesystem with -o norecovery with a read-only fs and log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot +echo "setting fs device read-write" +blockdev --setrw $SCRATCH_DEV + +echo "mounting filesystem with -o norecovery,ro with a read-only log device:" +_try_scratch_mount -o norecovery,ro 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +# +# But log recovery is performed when mount with -o ro as long as +# the underlying device is not write protected. +# +echo "mounting filesystem that needs recovery with -o ro:" +_try_scratch_mount -o ro 2>&1 | _filter_scratch + +# success, all done +echo "*** done" +rm -f $seqres.full +status=0tests/ext4/309.out new file +32
-0@@ -0,0 +1,32 @@ +QA output created by 309 +setting log device read-only +mounting with read-only log device: +mount: device write-protected, mounting read-only +touching file on read-only filesystem (should fail) +touch: cannot touch 'SCRATCH_MNT/foo': Read-only file system +unmounting read-only filesystem +setting log device read-write +mounting with read-write log device: +touch files +going down: +unmounting shutdown filesystem: +setting log device read-only +mounting filesystem that needs recovery with a read-only log device: +mount: device write-protected, mounting read-only +mount: cannot mount device read-only +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +mounting filesystem with -o norecovery with a read-only log device: +mount: SCRATCH_MNT: wrong fs type, bad option, bad superblock on SCRATCH_DEV, missing codepage or helper program, or other error +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +setting fs device read-only +mounting filesystem with -o norecovery with a read-only fs and log device: +mount: device write-protected, mounting read-only +unmounting read-only filesystem +setting fs device read-write +mounting filesystem with -o norecovery,ro with a read-only log device: +unmounting read-only filesystem +setting log device read-write +mounting filesystem that needs recovery with -o ro: +*** donetests/ext4/group +1
-0@@ -56,3 +56,4 @@ 306 auto rw resize quick 307 auto ioctl rw defrag 308 auto ioctl rw prealloc quick defrag +309 shutdown mount auto quickSignature · 1 line
2.21.3
Quoted 75 lines · Eryu Guan
[cc ext4 list for ext4 specific test]
Quoted 6 lines · Lukas Czerner
We should never be able to mount ext4 file system read-write with read-only external journal device. Test it.
The test was based on generic/050.
Signed-off-by Lukas Czerner <[email protected]>Is there a patch or kernel commit that fixes this test failure? I'd be better to mention the patch in either commit log or test description, so others could know where is the fix easily.
Quoted 3 lines
--- tests/ext4/309 | 135 +++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/309.out | 32 +++++++++++And use next available seq slot under ext4 dir, use "
./tools/nextidext4" to get the next available slot, which is 002 at this point.Quoted 27 lines
tests/ext4/group | 1 + 3 files changed, 168 insertions(+) create mode 100755 tests/ext4/309 create mode 100644 tests/ext4/309.outtests/ext4/309 new file +16
-0@@ -0,0 +1,135 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2009 Christoph Hellwig. +# Copyright (c) 2020 Lukas Czerner. +# +# FS QA Test No. 309 +# +# Copied from tests generic/050 and adjusted to support testing +# read-only external journal device on ext4. +# +# Check out various mount/remount/unmount scenarious on a read-only +# logdev blockdev. +# +seqfull=$0 +seq=`basename $0` +seqres=$RESULT_DIR/$seqtests/ext4/309 line 26
Quoted 10 lines
tests/ext4/309 new file +10
-0+echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + cd / + blockdev --setrw $SCRATCH_LOGDEVDo 'blockdev --setrw $SCRATCH_DEV' here as well to make sure both LOGDEV and
SCRATCH_DEVare set back to rw mode.tests/ext4/309 line 35
Quoted 9 lines
tests/ext4/309 new file +9
-0+} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic
_supported_fsext4
Quoted 1 line
Otherwise looks fine to me.
Thans Eryu,
I'll resend with the changes you pointed out.
-Lukas
Quoted 154 lines
Thanks,
EryuQuoted 149 lines
tests/ext4/309 new file +100
-0+_supported_os Linux + +_require_scratch_nocheck +_require_scratch_shutdown +_require_logdev +_require_local_device $SCRATCH_DEV +_require_local_device $SCRATCH_LOGDEV +_require_norecovery + +_scratch_mkfs >/dev/null 2>&1 +_require_metadata_journaling $SCRATCH_DEV + +# +# Mark the log device read-only +# +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mount it, and make sure we can't write to it, and we can unmount it again +# +echo "mounting with read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch +if [ "${PIPESTATUS[0]}" -eq 0 ]; then + echo "touching file on read-only filesystem (should fail)" + touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch +fi + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +echo "mounting with read-write log device:" +_try_scratch_mount 2>&1 | _filter_scratch + +echo "touch files" +touch $SCRATCH_MNT/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9} + +echo "going down:" +_scratch_shutdown -f + +echo "unmounting shutdown filesystem:" +_scratch_unmount 2>&1 | _filter_scratch + +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mounting a filesystem that requires log-recovery fails even with +# -o norecovery unless the fs device is read only or it's mounted +# read only +# +echo "mounting filesystem that needs recovery with a read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + + +echo "mounting filesystem with -o norecovery with a read-only log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +# +# This is the way out if the log device really is read-only. +# Doesn't mean it's a good idea in practice, more a last resort +# data recovery hack. Either the underlying fs device needs +# to be read only as well, or we mount the file system read only +# +echo "setting fs device read-only" +blockdev --setro $SCRATCH_DEV +echo "mounting filesystem with -o norecovery with a read-only fs and log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot +echo "setting fs device read-write" +blockdev --setrw $SCRATCH_DEV + +echo "mounting filesystem with -o norecovery,ro with a read-only log device:" +_try_scratch_mount -o norecovery,ro 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +# +# But log recovery is performed when mount with -o ro as long as +# the underlying device is not write protected. +# +echo "mounting filesystem that needs recovery with -o ro:" +_try_scratch_mount -o ro 2>&1 | _filter_scratch + +# success, all done +echo "*** done" +rm -f $seqres.full +status=0tests/ext4/309.out new file +32
-0@@ -0,0 +1,32 @@ +QA output created by 309 +setting log device read-only +mounting with read-only log device: +mount: device write-protected, mounting read-only +touching file on read-only filesystem (should fail) +touch: cannot touch 'SCRATCH_MNT/foo': Read-only file system +unmounting read-only filesystem +setting log device read-write +mounting with read-write log device: +touch files +going down: +unmounting shutdown filesystem: +setting log device read-only +mounting filesystem that needs recovery with a read-only log device: +mount: device write-protected, mounting read-only +mount: cannot mount device read-only +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +mounting filesystem with -o norecovery with a read-only log device: +mount: SCRATCH_MNT: wrong fs type, bad option, bad superblock on SCRATCH_DEV, missing codepage or helper program, or other error +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +setting fs device read-only +mounting filesystem with -o norecovery with a read-only fs and log device: +mount: device write-protected, mounting read-only +unmounting read-only filesystem +setting fs device read-write +mounting filesystem with -o norecovery,ro with a read-only log device: +unmounting read-only filesystem +setting log device read-write +mounting filesystem that needs recovery with -o ro: +*** donetests/ext4/group +1
-0@@ -56,3 +56,4 @@ 306 auto rw resize quick 307 auto ioctl rw defrag 308 auto ioctl rw prealloc quick defrag +309 shutdown mount auto quickSignature · 1 line
2.21.3
PATCH v2 1/1 ext4/002: Test read-only external journal device
In reply to Lukas CzernerWe should never be able to mount ext4 file system read-write with read-only external journal device. Test it.
This problem has been addressed with proposed kernel patch
https://lore.kernel.org/linux-ext4/[email protected]/
The test was based on generic/050.
---
v2: include link to the kernel patch, cahnge test number,
ext4 and ext3 are only supported fs, setrw SCRATCH_DEV on exit
tests/ext4/002 | 139 +++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/002.out | 32 +++++++++++ tests/ext4/group | 1 + 3 files changed, 172 insertions(+) create mode 100755 tests/ext4/002 create mode 100644 tests/ext4/002.out
tests/ext4/002 new file +139 -0
@@ -0,0 +1,139 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2009 Christoph Hellwig. +# Copyright (c) 2020 Lukas Czerner. +# +# FS QA Test No. 002 +# +# Copied from tests generic/050 and adjusted to support testing +# read-only external journal device on ext4. +# +# Check out various mount/remount/unmount scenarious on a read-only +# logdev blockdev. +# +# This problem has been addressed with proposed kernel patch +# https://lore.kernel.org/linux-ext4/[email protected]/ +# +seqfull=$0 +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + cd / + blockdev --setrw $SCRATCH_LOGDEV + blockdev --setrw $SCRATCH_DEV +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs ext4 ext3 +_supported_os Linux + +_require_scratch_nocheck +_require_scratch_shutdown +_require_logdev +_require_local_device $SCRATCH_DEV +_require_local_device $SCRATCH_LOGDEV +_require_norecovery + +_scratch_mkfs >/dev/null 2>&1 +_require_metadata_journaling $SCRATCH_DEV + +# +# Mark the log device read-only +# +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mount it, and make sure we can't write to it, and we can unmount it again +# +echo "mounting with read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch +if [ "${PIPESTATUS[0]}" -eq 0 ]; then + echo "touching file on read-only filesystem (should fail)" + touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch +fi + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +echo "mounting with read-write log device:" +_try_scratch_mount 2>&1 | _filter_scratch + +echo "touch files" +touch $SCRATCH_MNT/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9} + +echo "going down:" +_scratch_shutdown -f + +echo "unmounting shutdown filesystem:" +_scratch_unmount 2>&1 | _filter_scratch + +echo "setting log device read-only" +blockdev --setro $SCRATCH_LOGDEV + +# +# Mounting a filesystem that requires log-recovery fails even with +# -o norecovery unless the fs device is read only or it's mounted +# read only +# +echo "mounting filesystem that needs recovery with a read-only log device:" +_try_scratch_mount 2>&1 | _filter_ro_mount | _filter_scratch + +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + + +echo "mounting filesystem with -o norecovery with a read-only log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +# +# This is the way out if the log device really is read-only. +# Doesn't mean it's a good idea in practice, more a last resort +# data recovery hack. Either the underlying fs device needs +# to be read only as well, or we mount the file system read only +# +echo "setting fs device read-only" +blockdev --setro $SCRATCH_DEV +echo "mounting filesystem with -o norecovery with a read-only fs and log device:" +_try_scratch_mount -o norecovery 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot +echo "setting fs device read-write" +blockdev --setrw $SCRATCH_DEV + +echo "mounting filesystem with -o norecovery,ro with a read-only log device:" +_try_scratch_mount -o norecovery,ro 2>&1 | _filter_ro_mount | _filter_scratch +echo "unmounting read-only filesystem" +_scratch_unmount 2>&1 | _filter_scratch | _filter_ending_dot + +echo "setting log device read-write" +blockdev --setrw $SCRATCH_LOGDEV + +# +# But log recovery is performed when mount with -o ro as long as +# the underlying device is not write protected. +# +echo "mounting filesystem that needs recovery with -o ro:" +_try_scratch_mount -o ro 2>&1 | _filter_scratch + +# success, all done +echo "*** done" +rm -f $seqres.full +status=0
tests/ext4/002.out new file +32 -0
@@ -0,0 +1,32 @@ +QA output created by 002 +setting log device read-only +mounting with read-only log device: +mount: device write-protected, mounting read-only +touching file on read-only filesystem (should fail) +touch: cannot touch 'SCRATCH_MNT/foo': Read-only file system +unmounting read-only filesystem +setting log device read-write +mounting with read-write log device: +touch files +going down: +unmounting shutdown filesystem: +setting log device read-only +mounting filesystem that needs recovery with a read-only log device: +mount: device write-protected, mounting read-only +mount: cannot mount device read-only +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +mounting filesystem with -o norecovery with a read-only log device: +mount: SCRATCH_MNT: wrong fs type, bad option, bad superblock on SCRATCH_DEV, missing codepage or helper program, or other error +unmounting read-only filesystem +umount: SCRATCH_DEV: not mounted +setting fs device read-only +mounting filesystem with -o norecovery with a read-only fs and log device: +mount: device write-protected, mounting read-only +unmounting read-only filesystem +setting fs device read-write +mounting filesystem with -o norecovery,ro with a read-only log device: +unmounting read-only filesystem +setting log device read-write +mounting filesystem that needs recovery with -o ro: +*** done
tests/ext4/group +1 -0
@@ -4,6 +4,7 @@ # - comment line before each group is "new" description # 001 auto prealloc quick zero +002 shutdown mount auto quick 003 auto quick 004 auto dump 005 auto quick metadata ioctl rw
Signature · 1 line
2.21.3
Re: [PATCH v2] ext4/002: Test read-only external journal device
Quoted 9 lines · Lukas Czerner
We should never be able to mount ext4 file system read-write with read-only external journal device. Test it.
This problem has been addressed with proposed kernel patch
https://lore.kernel.org/linux-ext4/[email protected]/The test was based on generic/050.
Signed-off-by Lukas Czerner <[email protected]>
Looks good, tested with and without the fix.
- Ted