Skip to contentSkip to conversation

virtiofsd: Remove "norace" from cmdline help and docs

PATCH In review Sergio Lopez 2 participants 3 messages Jul 17, 2020 – Aug 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 virtiofsd: Remove "norace" from cmdline help and docs

Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed the implementation of the "norace" option, so remove it from the cmdline help and the documentation too.

---
v2:
* Drop "norace" from the documentation too (Stefano Garzarella)

---
 docs/tools/virtiofsd.rst | 3 ---
 tools/virtiofsd/helper.c | 2 --
 2 files changed, 5 deletions(-)
docs/tools/virtiofsd.rst +0 -3
index 824e713491..58666a4495 100644
@@ -63,9 +63,6 @@ Options
     Print only log messages matching LEVEL or more severe.  LEVEL is one of
     ``err``, ``warn``, ``info``, or ``debug``.  The default is ``info``.
 
-  * norace -
-    Disable racy fallback.  The default is false.
-
   * posix_lock|no_posix_lock -
     Enable/disable remote POSIX locks.  The default is ``posix_lock``.
 
tools/virtiofsd/helper.c +0 -2
index 3105b6c23a..7bc5d7dc5a 100644
@@ -159,8 +159,6 @@ void fuse_cmdline_help(void)
            "    -o max_idle_threads        the maximum number of idle worker "
            "threads\n"
            "                               allowed (default: 10)\n"
-           "    -o norace                  disable racy fallback\n"
-           "                               default: false\n"
            "    -o posix_lock|no_posix_lock\n"
            "                               enable/disable remote posix lock\n"
            "                               default: posix_lock\n"
Signature · 1 line
2.26.2
#1 lore raw
Quoted 7 lines · * Sergio Lopez ([email protected]) wrote:

Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed the implementation of the "norace" option, so remove it from the cmdline help and the documentation too.

Thanks; I've added it for my list for the next virtiofsd pull.

Quoted 38 lines

---
v2:
* Drop "norace" from the documentation too (Stefano Garzarella)

---
 docs/tools/virtiofsd.rst | 3 ---
 tools/virtiofsd/helper.c | 2 --
 2 files changed, 5 deletions(-)
docs/tools/virtiofsd.rst +0 -3
index 824e713491..58666a4495 100644
@@ -63,9 +63,6 @@ Options
     Print only log messages matching LEVEL or more severe.  LEVEL is one of
     ``err``, ``warn``, ``info``, or ``debug``.  The default is ``info``.
 
-  * norace -
-    Disable racy fallback.  The default is false.
-
   * posix_lock|no_posix_lock -
     Enable/disable remote POSIX locks.  The default is ``posix_lock``.
 
tools/virtiofsd/helper.c +0 -2
index 3105b6c23a..7bc5d7dc5a 100644
@@ -159,8 +159,6 @@ void fuse_cmdline_help(void)
            "    -o max_idle_threads        the maximum number of idle worker "
            "threads\n"
            "                               allowed (default: 10)\n"
-           "    -o norace                  disable racy fallback\n"
-           "                               default: false\n"
            "    -o posix_lock|no_posix_lock\n"
            "                               enable/disable remote posix lock\n"
            "                               default: posix_lock\n"
Signature · 1 line
2.26.2

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

#2 lore raw
In reply to Sergio Lopez
Quoted 10 lines · * Sergio Lopez ([email protected]) wrote:

Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed the implementation of the "norace" option, so remove it from the cmdline help and the documentation too.

---
v2:
* Drop "norace" from the documentation too (Stefano Garzarella)

I've added this to my dev world; I'll post it to qemu when it opens up.

Dave

Quoted 35 lines
---
 docs/tools/virtiofsd.rst | 3 ---
 tools/virtiofsd/helper.c | 2 --
 2 files changed, 5 deletions(-)
docs/tools/virtiofsd.rst +0 -3
index 824e713491..58666a4495 100644
@@ -63,9 +63,6 @@ Options
     Print only log messages matching LEVEL or more severe.  LEVEL is one of
     ``err``, ``warn``, ``info``, or ``debug``.  The default is ``info``.
 
-  * norace -
-    Disable racy fallback.  The default is false.
-
   * posix_lock|no_posix_lock -
     Enable/disable remote POSIX locks.  The default is ``posix_lock``.
 
tools/virtiofsd/helper.c +0 -2
index 3105b6c23a..7bc5d7dc5a 100644
@@ -159,8 +159,6 @@ void fuse_cmdline_help(void)
            "    -o max_idle_threads        the maximum number of idle worker "
            "threads\n"
            "                               allowed (default: 10)\n"
-           "    -o norace                  disable racy fallback\n"
-           "                               default: false\n"
            "    -o posix_lock|no_posix_lock\n"
            "                               enable/disable remote posix lock\n"
            "                               default: posix_lock\n"
Signature · 1 line
2.26.2
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK