Rid W=1 warnings in Pinctrl
Subsystems (24)
cover Rid W=1 warnings in Pinctrl
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings.
After these patches are applied, the build system no longer complains about any W=0 nor W=1 level warnings in drivers/pinctrl.
Hurrah!
Lee Jones (25):
pinctrl: actions: pinctrl-owl: Supply missing 'struct owl_pinctrl'
attribute descriptions
pinctrl: sirf: pinctrl-atlas7: Fix a bunch of documentation
misdemeanours
pinctrl: bcm: pinctrl-bcm281xx: Demote obvious misuse of kerneldoc to
standard comment blocks
pinctrl: bcm: pinctrl-iproc-gpio: Rename incorrectly documented
function param
pinctrl: qcom: pinctrl-msm: Complete 'struct msm_pinctrl'
documentation
pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc
to standard comment blocks
pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
pinctrl: qcom: pinctrl-msm8976: Remove unused variable
'nav_tsync_groups'
pinctrl: mediatek: pinctrl-mtk-common-v2: Mark
'mtk_default_register_base_names' as __maybe_unused
pinctrl: core: Fix a bunch of kerneldoc issues
pinctrl: pinmux: Add some missing parameter descriptions
pinctrl: devicetree: Add one new attribute description and rename
another two
pinctrl: pinconf-generic: Add function parameter description 'pctldev'
pinctrl: pinctrl-at91-pio4: PM related attribute descriptions
arch: arm: mach-at91: pm: Move prototypes to mutually included header
pinctrl: pinctrl-at91: Demote non-kerneldoc header and complete
another
pinctrl: pinctrl-bm1880: Rename ill documented struct attribute
entries
pinctrl: pinctrl-rockchip: Fix a bunch of kerneldoc misdemeanours
pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
pinctrl: pinctrl-single: Fix struct/function documentation blocks
pinctrl: tegra: pinctrl-tegra194: Do not initialise field twice
pinctrl: meson: pinctrl-meson-a1: Remove unused const variable
'i2c_slave_groups'
pinctrl: mvebu: pinctrl-armada-37xx: Update documentation block for
'struct armada_37xx_pin_group'
pinctrl: pinctrl-amd: Do not define 'struct acpi_device_id' when
!CONFIG_ACPI
arch/arm/mach-at91/pm.c | 17 +++++-------- drivers/pinctrl/actions/pinctrl-owl.c | 4 ++++ drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 6 ++--- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +- drivers/pinctrl/core.c | 12 +++++----- drivers/pinctrl/devicetree.c | 5 ++-- .../pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 +- drivers/pinctrl/meson/pinctrl-meson-a1.c | 5 ---- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 +++--- drivers/pinctrl/pinconf-generic.c | 3 ++- drivers/pinctrl/pinctrl-amd.c | 2 ++ drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ drivers/pinctrl/pinctrl-at91.c | 7 +++++- drivers/pinctrl/pinctrl-bm1880.c | 4 ++-- drivers/pinctrl/pinctrl-rockchip.c | 22 +++++++++-------- drivers/pinctrl/pinctrl-rza1.c | 24 +++++++++---------- drivers/pinctrl/pinctrl-single.c | 13 +++++++--- drivers/pinctrl/pinmux.c | 5 +++- drivers/pinctrl/qcom/pinctrl-msm.c | 6 ++++- drivers/pinctrl/qcom/pinctrl-msm8976.c | 3 --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 ++--- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 ++--- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- drivers/pinctrl/sirf/pinctrl-atlas7.c | 21 +++++++--------- drivers/pinctrl/tegra/pinctrl-tegra194.c | 1 - include/linux/platform_data/atmel.h | 5 ++++ 26 files changed, 107 insertions(+), 87 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/25 pinctrl: actions: pinctrl-owl: Supply missing 'struct owl_pinctrl' attribute descriptions
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'clk' not described in 'owl_pinctrl' drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq_chip' not described in 'owl_pinctrl' drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'num_irq' not described in 'owl_pinctrl' drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq' not described in 'owl_pinctrl'
--- drivers/pinctrl/actions/pinctrl-owl.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/pinctrl/actions/pinctrl-owl.c +4 -0
@@ -35,8 +35,12 @@* @pctrldev: pinctrl handle * @chip: gpio chip * @lock: spinlock to protect registers +* @clk: clock control * @soc: reference to soc_data * @base: pinctrl register base address +* @irq_chip: IRQ chip information +* @num_irq: number of possible interrupts +* @irq: interrupt numbers */ struct owl_pinctrl {struct device *dev;
Signature · 1 line
2.25.1
Re: [PATCH 01/25] pinctrl: actions: pinctrl-owl: Supply missing 'struct owl_pinctrl' attribute descriptions
Quoted 11 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'clk' not described in 'owl_pinctrl'drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq_chip' not described in 'owl_pinctrl'drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'num_irq' not described in 'owl_pinctrl'drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq' not described in 'owl_pinctrl'Cc "Andreas Färber" <[email protected]>Cc Manivannan Sadhasivam <[email protected]>Cc David Liu <[email protected]>Signed-off-by Lee Jones <[email protected]>
Thanks,
Mani
Quoted 24 lines
--- drivers/pinctrl/actions/pinctrl-owl.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/pinctrl/actions/pinctrl-owl.c +4
-0@@ -35,8 +35,12 @@* @pctrldev: pinctrl handle * @chip: gpio chip * @lock: spinlock to protect registers +* @clk: clock control * @soc: reference to soc_data * @base: pinctrl register base address +* @irq_chip: IRQ chip information +* @num_irq: number of possible interrupts +* @irq: interrupt numbers */ struct owl_pinctrl {struct device *dev;Signature · 1 line
2.25.1
PATCH 2/25 pinctrl: sirf: pinctrl-atlas7: Fix a bunch of documentation misdemeanours
In reply to Lee JonesFrom ill formatted kerneldoc, to incomplete *and* incorrect struct headers, through to formatting issues and missing attribute descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/sirf/pinctrl-atlas7.c:197: warning: Function parameter or member 'id' not described in 'atlas7_pad_config' drivers/pinctrl/sirf/pinctrl-atlas7.c:221: warning: Function parameter or member 'func' not described in 'atlas7_pad_status' drivers/pinctrl/sirf/pinctrl-atlas7.c:221: warning: Function parameter or member 'pull' not described in 'atlas7_pad_status' drivers/pinctrl/sirf/pinctrl-atlas7.c:221: warning: Function parameter or member 'dstr' not described in 'atlas7_pad_status' drivers/pinctrl/sirf/pinctrl-atlas7.c:221: warning: Function parameter or member 'reserved' not described in 'atlas7_pad_status' drivers/pinctrl/sirf/pinctrl-atlas7.c:359: warning: Cannot understand * @dev: a pointer back to containing device on line 359 - I thought it was a doc line
drivers/pinctrl/sirf/pinctrl-atlas7.c:4794: warning: Function parameter or member 'pad_type' not described in 'atlas7_pull_info' drivers/pinctrl/sirf/pinctrl-atlas7.c:4917: warning: Function parameter or member 'reserved' not described in 'atlas7_ds_info' drivers/pinctrl/sirf/pinctrl-atlas7.c:5617: warning: Function parameter or member 'a7gc' not described in 'atlas7_gpio_to_bank' drivers/pinctrl/sirf/pinctrl-atlas7.c:5617: warning: Function parameter or member 'gpio' not described in 'atlas7_gpio_to_bank'
--- drivers/pinctrl/sirf/pinctrl-atlas7.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-)
drivers/pinctrl/sirf/pinctrl-atlas7.c +9 -12
@@ -169,7 +169,7 @@ struct dt_params {/** * struct atlas7_pad_conf - Atlas7 Pad Configuration -* @id The ID of this Pad. +* @id: The ID of this Pad. * @type: The type of this Pad. * @mux_reg: The mux register offset. * This register contains the mux.
@@ -210,7 +210,7 @@ struct atlas7_pad_config { .ad_ctrl_bit = adb, \ } -/** +/* * struct atlas7_pad_status - Atlas7 Pad status */ struct atlas7_pad_status {
@@ -355,10 +355,6 @@ struct atlas7_gpio_chip {struct atlas7_gpio_bank banks[]; }; -/** -* @dev: a pointer back to containing device -* @virtbase: the offset to the controller in virtual memory -*/ struct atlas7_pmx {struct device *dev;struct pinctrl_dev *pctl;
@@ -376,7 +372,7 @@ struct atlas7_pmx {* refer to A7DA IO Summary - CS-314158-DD-4E.xls */ -/*Pads in IOC RTC & TOP */ +/* Pads in IOC RTC & TOP */ static const struct pinctrl_pin_desc atlas7_ioc_pads[] = {/* RTC PADs */ PINCTRL_PIN (0 ,"rtc_gpio_0" ),
@@ -4781,10 +4777,10 @@ struct map_data {/** * struct atlas7_pull_info - Atlas7 Pad pull info -* @type:The type of this Pad. -* @mask:The mas value of this pin's pull bits. -* @v2s: The map of pull register value to pull status. -* @s2v: The map of pull status to pull register value. +* @pad_type: The type of this Pad. +* @mask: The mas value of this pin's pull bits. +* @v2s: The map of pull register value to pull status. +* @s2v: The map of pull status to pull register value. */ struct atlas7_pull_info {u8 pad_type;
@@ -4908,6 +4904,7 @@ static const struct atlas7_ds_ma_info atlas7_ma2ds_map[] = {* @type: The type of this Pad. * @mask: The mask value of this pin's pull bits. * @imval: The immediate value of drives trength register. +* @reserved: Reserved space */ struct atlas7_ds_info {u8 type;
@@ -5609,7 +5606,7 @@ static int __init atlas7_pinmux_init(void)arch_initcall (atlas7_pinmux_init); -/** +/* * The Following is GPIO Code */ static inline struct
Signature · 1 line
2.25.1
PATCH 3/25 pinctrl: bcm: pinctrl-bcm281xx: Demote obvious misuse of kerneldoc to standard comment blocks
In reply to Lee JonesThere has been little to no attempt to document any of the demoted structures here. These are obviously not kerneldoc headers.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/bcm/pinctrl-bcm281xx.c:65: warning: cannot understand function prototype: 'enum bcm281xx_pin_type ' drivers/pinctrl/bcm/pinctrl-bcm281xx.c:79: warning: cannot understand function prototype: 'struct bcm281xx_pin_function ' drivers/pinctrl/bcm/pinctrl-bcm281xx.c:89: warning: cannot understand function prototype: 'struct bcm281xx_pinctrl_data '
--- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/bcm/pinctrl-bcm281xx.c +3 -3
@@ -59,7 +59,7 @@#define BCM281XX_HDMI_PIN_REG_MODE_MASK 0x0010#define BCM281XX_HDMI_PIN_REG_MODE_SHIFT 4 -/** +/* * bcm281xx_pin_type - types of pin register */ enum bcm281xx_pin_type {
@@ -73,7 +73,7 @@ static enum bcm281xx_pin_type std_pin = BCM281XX_PIN_TYPE_STD;static enum bcm281xx_pin_type i2c_pin =BCM281XX_PIN_TYPE_I2C ;static enum bcm281xx_pin_type hdmi_pin =BCM281XX_PIN_TYPE_HDMI ; -/** +/* * bcm281xx_pin_function- define pin function */ struct bcm281xx_pin_function {
@@ -82,7 +82,7 @@ struct bcm281xx_pin_function {const unsigned ngroups; }; -/** +/* * bcm281xx_pinctrl_data - Broadcom-specific pinctrl data * @reg_base - base of pinctrl registers */
Signature · 1 line
2.25.1
Re: [PATCH 03/25] pinctrl: bcm: pinctrl-bcm281xx: Demote obvious misuse of kerneldoc to standard comment blocks
thanks.
Quoted 9 lines · Lee Jones
There has been little to no attempt to document any of the demoted structures here. These are obviously not kerneldoc headers.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/bcm/pinctrl-bcm281xx.c:65: warning: cannot understand function prototype: 'enumbcm281xx_pin_type'drivers/pinctrl/bcm/pinctrl-bcm281xx.c:79: warning: cannot understand function prototype: 'structbcm281xx_pin_function'drivers/pinctrl/bcm/pinctrl-bcm281xx.c:89: warning: cannot understand function prototype: 'structbcm281xx_pinctrl_data'
Quoted 6 lines
Cc Florian Fainelli <[email protected]>Cc Ray Jui <[email protected]>Cc Scott Branden <[email protected]>Cc YueHaibing <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 35 lines
--- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/pinctrl/bcm/pinctrl-bcm281xx.c +3
-3@@ -59,7 +59,7 @@#define BCM281XX_HDMI_PIN_REG_MODE_MASK 0x0010#define BCM281XX_HDMI_PIN_REG_MODE_SHIFT 4 -/** +/* * bcm281xx_pin_type - types of pin register */ enum bcm281xx_pin_type {@@ -73,7 +73,7 @@ static enum bcm281xx_pin_type std_pin = BCM281XX_PIN_TYPE_STD;static enum bcm281xx_pin_type i2c_pin =BCM281XX_PIN_TYPE_I2C ;static enum bcm281xx_pin_type hdmi_pin =BCM281XX_PIN_TYPE_HDMI ; -/** +/* * bcm281xx_pin_function- define pin function */ struct bcm281xx_pin_function {@@ -82,7 +82,7 @@ struct bcm281xx_pin_function {const unsigned ngroups; }; -/** +/* * bcm281xx_pinctrl_data - Broadcom-specific pinctrl data * @reg_base - base of pinctrl registers */
PATCH 4/25 pinctrl: bcm: pinctrl-iproc-gpio: Rename incorrectly documented function param
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Function parameter or member 'chip' not described in 'iproc_set_bit' drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Excess function parameter 'iproc_gpio' description in 'iproc_set_bit'
--- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +1 -1
@@ -131,7 +131,7 @@ static inline unsigned iproc_pin_to_gpio(unsigned pin)* iproc_set_bit - set or clear one bit (corresponding to the GPIO pin) in a * Iproc GPIO register * -* @iproc_gpio: Iproc GPIO device +* @chip: Iproc GPIO device * @reg: register offset * @gpio: GPIO pin * @set: set or clear
Signature · 1 line
2.25.1
Re: [PATCH 04/25] pinctrl: bcm: pinctrl-iproc-gpio: Rename incorrectly documented function param
thanks.
Quoted 9 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Function parameter or member 'chip' not described in 'iproc_set_bit'drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Excess function parameter 'iproc_gpio' description in 'iproc_set_bit'Cc Ray Jui <[email protected]>Cc Scott Branden <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 17 lines
--- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +1
-1@@ -131,7 +131,7 @@ static inline unsigned iproc_pin_to_gpio(unsigned pin)* iproc_set_bit - set or clear one bit (corresponding to the GPIO pin) in a * Iproc GPIO register * -* @iproc_gpio: Iproc GPIO device +* @chip: Iproc GPIO device * @reg: register offset * @gpio: GPIO pin * @set: set or clear
PATCH 5/25 pinctrl: qcom: pinctrl-msm: Complete 'struct msm_pinctrl' documentation
In reply to Lee JonesAdd missing descriptions for attributes and fix 1 formatting issue.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/qcom/pinctrl-msm.c:75: warning: Function parameter or member 'desc' not described in 'msm_pinctrl' drivers/pinctrl/qcom/pinctrl-msm.c:75: warning: Function parameter or member 'irq_chip' not described in 'msm_pinctrl' drivers/pinctrl/qcom/pinctrl-msm.c:75: warning: Function parameter or member 'intr_target_use_scm' not described in 'msm_pinctrl' drivers/pinctrl/qcom/pinctrl-msm.c:75: warning: Function parameter or member 'soc' not described in 'msm_pinctrl' drivers/pinctrl/qcom/pinctrl-msm.c:75: warning: Function parameter or member 'phys_base' not described in 'msm_pinctrl'
--- drivers/pinctrl/qcom/pinctrl-msm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/pinctrl/qcom/pinctrl-msm.c +5 -1
@@ -40,16 +40,20 @@* @dev: device handle. * @pctrl: pinctrl handle. * @chip: gpiochip handle. +* @desc: pin controller descriptor * @restart_nb: restart notifier block. +* @irq_chip: irq chip information * @irq: parent irq for the TLMM irq_chip. +* @intr_target_use_scm: route irq to application cpu using scm calls * @lock: Spinlock to protect register resources as well * as msm_pinctrl data structures. * @enabled_irqs: Bitmap of currently enabled irqs. * @dual_edge_irqs: Bitmap of irqs that need sw emulated dual edge * detection. * @skip_wake_irqs: Skip IRQs that are handled by wakeup interrupt controller -* @soc; Reference to soc_data of platform specific data. +* @soc: Reference to soc_data of platform specific data. * @regs: Base addresses for the TLMM tiles. +* @phys_base: Physical base address */ struct msm_pinctrl {struct device *dev;
Signature · 1 line
2.25.1
PATCH 6/25 pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
In reply to Lee JonesNo attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend' drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'
--- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +2 -2
@@ -1140,7 +1140,7 @@ static int samsung_pinctrl_probe(struct platform_device *pdev)return 0 ; } -/** +/* * samsung_pinctrl_suspend - save pinctrl state for suspend * * Save data for all banks handled by this device.
@@ -1187,7 +1187,7 @@ static int __maybe_unused samsung_pinctrl_suspend(struct device *dev)return 0 ; } -/** +/* * samsung_pinctrl_resume - restore pinctrl state from suspend * * Restore one of the banks that was saved during suspend.
Signature · 1 line
2.25.1
Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
Quoted 7 lines · Lee Jones
No attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'
Quoted 8 lines
Cc Tomasz Figa <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Cc Thomas Abraham <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
Thanks, applied.
Best regards,
Krzysztof
Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
Quoted 17 lines · Krzysztof Kozlowski
Quoted 7 lines · Lee Jones
No attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'Quoted 8 lines
Cc Tomasz Figa <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Cc Thomas Abraham <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
Quoted 1 line
Thanks, applied.
Same as the others. Already in -next.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Krzysztof Kozlowski
maintainerRe: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
Quoted 19 lines · Lee Jones
Quoted 17 lines · Krzysztof Kozlowski
Quoted 15 lines · Lee Jones
No attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'Cc Tomasz Figa <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Cc Thomas Abraham <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
Quoted 3 lines
Quoted 1 line
Thanks, applied.
Same as the others. Already in -next.
Thanks for letting me know. I dropped all of them.
Best regards,
Krzysztof
Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
Quoted 7 lines · Krzysztof Kozlowski
Quoted 3 lines · Lee Jones
Quoted 1 line
Thanks, applied.
Same as the others. Already in -next.
Thanks for letting me know. I dropped all of them.
It's a bit tricky at times with clean-up topics, I want submaintainers to pick it up if possible so sorry about this, it's just too much to coordinate sometimes.
Yours,
Linus Walleij
Krzysztof Kozlowski
maintainerRe: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
Quoted 6 lines · Linus Walleij
Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Lee Jones
Quoted 1 line
Thanks, applied.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Same as the others. Already in -next.
Thanks for letting me know. I dropped all of them.
It's a bit tricky at times with clean-up topics, I want submaintainers to pick it up if possible so sorry about this, it's just too much to coordinate sometimes.
No worries. Recently Samsung pinctrl driver is not that active so I could just provide you only a review. Maybe there is too much hustle to apply to sub-maintainer tree.
Best regards,
Krzysztof
PATCH 7/25 pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
In reply to Lee JonesKerneldoc struct titles must be followed by whitespace. Also attributes need to be in the format '@.*: ' else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data '
--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/samsung/pinctrl-s3c24xx.c +3 -3
@@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = { }/** -* struct s3c24xx_eint_data: EINT common data +* struct s3c24xx_eint_data - EINT common data * @drvdata: pin controller driver data * @domains: IRQ domains of particular EINT interrupts * @parents: mapped parent irqs in the main interrupt controller
@@ -92,10 +92,10 @@ struct s3c24xx_eint_data { };/** -* struct s3c24xx_eint_domain_data: per irq-domain data +* struct s3c24xx_eint_domain_data - per irq-domain data * @bank: pin bank related to the domain * @eint_data: common data -* eint0_3_parent_only: live eints 0-3 only in the main intc +* @eint0_3_parent_only: live eints 0-3 only in the main intc */ struct s3c24xx_eint_domain_data {struct samsung_pin_bank *bank;
Signature · 1 line
2.25.1
Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
Am Montag, 13. Juli 2020, 16:49:12 CEST schrieb Lee Jones:
Quoted 7 lines
Kerneldoc struct titles must be followed by whitespace. Also attributes need to be in the format '@.*: ' else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'structs3c24xx_eint_domain_data'
Quoted 7 lines
Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Tomasz Figa <[email protected]>Cc Sylwester Nawrocki <[email protected]>Cc Heiko Stuebner <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 31 lines
--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/pinctrl/samsung/pinctrl-s3c24xx.c +3
-3@@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = { }/** -* struct s3c24xx_eint_data: EINT common data +* struct s3c24xx_eint_data - EINT common data * @drvdata: pin controller driver data * @domains: IRQ domains of particular EINT interrupts * @parents: mapped parent irqs in the main interrupt controller @@ -92,10 +92,10 @@ struct s3c24xx_eint_data { };/** -* struct s3c24xx_eint_domain_data: per irq-domain data +* struct s3c24xx_eint_domain_data - per irq-domain data * @bank: pin bank related to the domain * @eint_data: common data -* eint0_3_parent_only: live eints 0-3 only in the main intc +* @eint0_3_parent_only: live eints 0-3 only in the main intc */ struct s3c24xx_eint_domain_data {struct samsung_pin_bank *bank;
Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
In reply to Lee JonesQuoted 14 lines · Lee Jones
Kerneldoc struct titles must be followed by whitespace. Also attributes need to be in the format '@.*: ' else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'structs3c24xx_eint_domain_data'Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Tomasz Figa <[email protected]>Cc Sylwester Nawrocki <[email protected]>Cc Heiko Stuebner <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 2 lines
--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
Thanks, applied.
Best regards,
Krzysztof
Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
Quoted 18 lines · Krzysztof Kozlowski
Quoted 14 lines · Lee Jones
Kerneldoc struct titles must be followed by whitespace. Also attributes need to be in the format '@.*: ' else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'structs3c24xx_eint_domain_data'Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Tomasz Figa <[email protected]>Cc Sylwester Nawrocki <[email protected]>Cc Heiko Stuebner <[email protected]>Signed-off-by Lee Jones <[email protected]>Quoted 2 lines
--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
Quoted 1 line
Thanks, applied.
This has already been applied and resides in -next.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 8/25 pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
In reply to Lee JonesKerneldoc struct titles must be followed by whitespace else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data '
--- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/samsung/pinctrl-s3c64xx.c +3 -3
@@ -193,7 +193,7 @@ static const struct samsung_pin_bank_type bank_type_2bit_alive = { }/** -* struct s3c64xx_eint0_data: EINT0 common data +* struct s3c64xx_eint0_data - EINT0 common data * @drvdata: pin controller driver data * @domains: IRQ domains of particular EINT0 interrupts * @pins: pin offsets inside of banks of particular EINT0 interrupts
@@ -205,7 +205,7 @@ struct s3c64xx_eint0_data { };/** -* struct s3c64xx_eint0_domain_data: EINT0 per-domain data +* struct s3c64xx_eint0_domain_data - EINT0 per-domain data * @bank: pin bank related to the domain * @eints: EINT0 interrupts related to the domain */
@@ -215,7 +215,7 @@ struct s3c64xx_eint0_domain_data { };/** -* struct s3c64xx_eint_gpio_data: GPIO EINT data +* struct s3c64xx_eint_gpio_data - GPIO EINT data * @drvdata: pin controller driver data * @domains: array of domains related to EINT interrupt groups */
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerRe: [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
Quoted 7 lines · Lee Jones
Kerneldoc struct titles must be followed by whitespace else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'structs3c64xx_eint0_domain_data'
Quoted 7 lines
Cc Tomasz Figa <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++---
Thanks, squashed with s3c24xx since these are similar issues and only documentation is affected.
Best regards,
Krzysztof
Re: [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
Quoted 16 lines · Krzysztof Kozlowski
Quoted 7 lines · Lee Jones
Kerneldoc struct titles must be followed by whitespace else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'structs3c64xx_eint0_domain_data'Quoted 7 lines
Cc Tomasz Figa <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Sylwester Nawrocki <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++---
Quoted 2 lines
Thanks, squashed with s3c24xx since these are similar issues and only documentation is affected.
This is already in -next.
Seems like an odd decision to squash them too.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 9/25 pinctrl: qcom: pinctrl-msm8976: Remove unused variable 'nav_tsync_groups'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/pinctrl/qcom/pinctrl-msm8976.c:802:27: warning: ‘nav_tsync_groups’ defined but not used [-Wunused-const-variable=] 802 | static const char
const nav_tsync_groups[] = {
| ^~~~~~~~~~~~~~~~
--- drivers/pinctrl/qcom/pinctrl-msm8976.c | 3 --- 1 file changed, 3 deletions(-)
drivers/pinctrl/qcom/pinctrl-msm8976.c +0 -3
@@ -799,9 +799,6 @@ static const char * const pa_indicator_groups[] = {static const char *const modem_tsync_groups[] = {"gpio93" , }; -static const char *const nav_tsync_groups[] = { -"gpio93" , -};static const char *const ssbi_wtr1_groups[] = {"gpio79" ,"gpio94" , };
Signature · 1 line
2.25.1
PATCH 10/25 pinctrl: mediatek: pinctrl-mtk-common-v2: Mark 'mtk_default_register_base_names' as __maybe_unused
In reply to Lee JonesNot all sourcefiles which end up including pinctrl-mtk-common-v2.h make use of 'mtk_default_register_base_names' and there is nowhere we can place the definition to void the need for __maybe_unused except its own headerfile, which seems like overkill. So instead we tell the compiler that it's okay for it to be unused by some of the consumers.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:19:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/mediatek/pinctrl-moore.h:25,
from drivers/pinctrl/mediatek/pinctrl-moore.c:12:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
from drivers/pinctrl/mediatek/pinctrl-paris.c:15:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
from drivers/pinctrl/mediatek/pinctrl-mtk-mt6797.h:15,
from drivers/pinctrl/mediatek/pinctrl-mt6797.c:13:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
from drivers/pinctrl/mediatek/pinctrl-mtk-mt8183.h:12,
from drivers/pinctrl/mediatek/pinctrl-mt8183.c:9:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
from drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h:12,
from drivers/pinctrl/mediatek/pinctrl-mt6765.c:10:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h +1 -1
@@ -80,7 +80,7 @@ enum { DRV_GRP_MAX, }; -static const char *const mtk_default_register_base_names[] = { +static const char *const mtk_default_register_base_names[]__maybe_unused = {"base" , };
Signature · 7 lines
2.25.1 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH 10/25] pinctrl: mediatek: pinctrl-mtk-common-v2: Mark 'mtk_default_register_base_names' as __maybe_unused
Quoted 42 lines · Lee Jones
Not all sourcefiles which end up including
pinctrl-mtk-common-v2.hmake use of 'mtk_default_register_base_names' and there is nowhere we can place the definition to void the need for__maybe_unusedexcept its own headerfile, which seems like overkill. So instead we tell the compiler that it's okay for it to be unused by some of the consumers.Fixes the following W=1 kernel build warning(s):
In file included from
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:19:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included fromdrivers/pinctrl/mediatek/pinctrl-moore.h:25,
fromdrivers/pinctrl/mediatek/pinctrl-moore.c:12:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included fromdrivers/pinctrl/mediatek/pinctrl-paris.h:27,
fromdrivers/pinctrl/mediatek/pinctrl-paris.c:15:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included fromdrivers/pinctrl/mediatek/pinctrl-paris.h:27,
fromdrivers/pinctrl/mediatek/pinctrl-mtk-mt6797.h:15,
fromdrivers/pinctrl/mediatek/pinctrl-mt6797.c:13:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included fromdrivers/pinctrl/mediatek/pinctrl-paris.h:27,
fromdrivers/pinctrl/mediatek/pinctrl-mtk-mt8183.h:12,
fromdrivers/pinctrl/mediatek/pinctrl-mt8183.c:9:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included fromdrivers/pinctrl/mediatek/pinctrl-paris.h:27,
fromdrivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h:12,
fromdrivers/pinctrl/mediatek/pinctrl-mt6765.c:10:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: ‘mtk_default_register_base_names’ defined but not used [-Wunused-const-variable=] 83 | static const char const mtk_default_register_base_names[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Quoted 4 lines
Cc Sean Wang <[email protected]>Cc Matthias Brugger <[email protected]>Signed-off-by Lee Jones <[email protected]>
Those MediaTek SoCs with multiple register bases wouldn't refer to the array
Quoted 2 lines
--- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 +-
PATCH 11/25 pinctrl: core: Fix a bunch of kerneldoc issues
In reply to Lee JonesMost are likely due to bitrot/API slip. Some are formatting issues.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/core.c:167: warning: Function parameter or member 'pin' not described in 'pin_get_name' drivers/pinctrl/core.c:167: warning: Excess function parameter 'name' description in 'pin_get_name' drivers/pinctrl/core.c:584: warning: Function parameter or member 'selector' not described in 'pinctrl_generic_get_group' drivers/pinctrl/core.c:584: warning: Excess function parameter 'gselector' description in 'pinctrl_generic_get_group' drivers/pinctrl/core.c:1356: error: Cannot parse struct or union!
drivers/pinctrl/core.c:1458: warning: Function parameter or member 'map' not described in 'pinctrl_unregister_mappings' drivers/pinctrl/core.c:1458: warning: Excess function parameter 'maps' description in 'pinctrl_unregister_mappings' drivers/pinctrl/core.c:2239: warning: Function parameter or member 'pctldev' not described in 'devm_pinctrl_register_and_init'
--- drivers/pinctrl/core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/pinctrl/core.c +6 -6
@@ -161,7 +161,7 @@ int pin_get_from_name(struct pinctrl_dev *pctldev, const char *name)/** * pin_get_name_from_id() - look up a pin name from a pin id * @pctldev: the pin control device to lookup the pin on -* @name: the name of the pin to look up +* @pin: pin number/id to look up */ const char *pin_get_name (struct pinctrl_dev *pctldev,const unsigned pin) {
@@ -577,7 +577,7 @@ EXPORT_SYMBOL_GPL(pinctrl_generic_get_group_pins);/** * pinctrl_generic_get_group() - returns a pin group based on the number * @pctldev: pin controller device -* @gselector: group number +* @selector: group number */ struct group_desc *pinctrl_generic_get_group (struct pinctrl_dev *pctldev,unsigned int selector)
@@ -1329,7 +1329,7 @@ static void devm_pinctrl_release(struct device *dev, void *res) }/** -* struct devm_pinctrl_get() - Resource managed pinctrl_get() +* devm_pinctrl_get() - Resource managed pinctrl_get() * @dev: the device to obtain the handle for * * If there is a need to explicitly destroy the returned struct pinctrl,
@@ -1451,7 +1451,7 @@ EXPORT_SYMBOL_GPL(pinctrl_register_mappings);/** * pinctrl_unregister_mappings() - unregister a set of pin controller mappings -* @maps: the pincontrol mappings table passed to pinctrl_register_mappings() +* @map: the pincontrol mappings table passed to pinctrl_register_mappings() * when registering the mappings. */ void pinctrl_unregister_mappings (const struct pinctrl_map *map)
@@ -2226,9 +2226,9 @@ EXPORT_SYMBOL_GPL(devm_pinctrl_register);* @dev: parent device for this pin controller * @pctldesc: descriptor for this pin controller * @driver_data: private pin controller data for this pin controller +* @pctldev: pin controller device * -* Returns an error pointer if pincontrol register failed. Otherwise -* it returns valid pinctrl handle. +* Returns zero on success or an error number on failure. * * The pinctrl device will be automatically released when the device is unbound. */
Signature · 1 line
2.25.1
PATCH 12/25 pinctrl: pinmux: Add some missing parameter descriptions
In reply to Lee JonesAnd rename another which has probably bitrotted.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinmux.c:83: warning: Function parameter or member 'pctldev' not described in 'pinmux_can_be_used_for_gpio' drivers/pinctrl/pinmux.c:108: warning: Function parameter or member 'pctldev' not described in 'pin_request' drivers/pinctrl/pinmux.c:261: warning: Function parameter or member 'gpio' not described in 'pinmux_request_gpio' drivers/pinctrl/pinmux.c:751: warning: Function parameter or member 'selector' not described in 'pinmux_generic_get_function' drivers/pinctrl/pinmux.c:751: warning: Excess function parameter 'group_selector' description in 'pinmux_generic_get_function'
--- drivers/pinctrl/pinmux.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pinctrl/pinmux.c +4 -1
@@ -74,6 +74,7 @@ int pinmux_validate_map(const struct pinctrl_map *map, int i)* pinmux_can_be_used_for_gpio() - check if a specific pin * is either muxed to a different function or used as gpio. * +* @pctldev: the associated pin controller device * @pin: the pin number in the global pin space * * Controllers not defined as strict will always return true,
@@ -96,6 +97,7 @@ bool pinmux_can_be_used_for_gpio(struct pinctrl_dev *pctldev, unsigned pin)/** * pin_request() - request a single pin to be muxed in, typically for GPIO +* @pctldev: the associated pin controller device * @pin: the pin number in the global pin space * @owner: a representation of the owner of this pin; typically the device * name that controls its mux function, or the requested GPIO name
@@ -254,6 +256,7 @@ static const char *pin_free(struct pinctrl_dev *pctldev, int pin,* @pctldev: pin controller device affected * @pin: the pin to mux in for GPIO * @range: the applicable GPIO range +* @gpio: number of requested GPIO */ int pinmux_request_gpio(struct pinctrl_dev *pctldev, struct pinctrl_gpio_range *range,
@@ -744,7 +747,7 @@ EXPORT_SYMBOL_GPL(pinmux_generic_get_function_groups);/** * pinmux_generic_get_function() - returns a function based on the number * @pctldev: pin controller device -* @group_selector: function number +* @selector: function number */ struct function_desc *pinmux_generic_get_function (struct pinctrl_dev *pctldev,unsigned int selector)
Signature · 1 line
2.25.1
PATCH 13/25 pinctrl: devicetree: Add one new attribute description and rename another two
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/pinctrl/devicetree.c:27: warning: Function parameter or member 'map' not described in 'pinctrl_dt_map' drivers/pinctrl/devicetree.c:27: warning: Function parameter or member 'num_maps' not described in 'pinctrl_dt_map' drivers/pinctrl/devicetree.c:409: warning: Function parameter or member 'out_args' not described in 'pinctrl_parse_index_with_args' drivers/pinctrl/devicetree.c:409: warning: Excess function parameter 'out_arts' description in 'pinctrl_parse_index_with_args'
--- drivers/pinctrl/devicetree.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pinctrl/devicetree.c +3 -2
@@ -17,7 +17,8 @@* struct pinctrl_dt_map - mapping table chunk parsed from device tree * @node: list node for struct pinctrl's @dt_maps field * @pctldev: the pin controller that allocated this struct, and will free it -* @maps: the mapping table entries +* @map: the mapping table entries +* @num_maps: number of mapping table entries */ struct pinctrl_dt_map {struct list_head node;
@@ -397,7 +398,7 @@ static int pinctrl_copy_args(const struct device_node *np,* @np: pointer to device node with the property * @list_name: property that contains the list * @index: index within the list -* @out_arts: entries in the list pointed by index +* @out_args: entries in the list pointed by index * * Finds the selected element in a pinctrl array consisting of an index * within the controller and a number of u32 entries specified for each
Signature · 1 line
2.25.1
PATCH 14/25 pinctrl: pinconf-generic: Add function parameter description 'pctldev'
In reply to Lee JonesFix a spelling/typo while we're here.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinconf-generic.c:242: warning: Function parameter or member 'pctldev' not described in 'pinconf_generic_parse_dt_config'
--- drivers/pinctrl/pinconf-generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/pinctrl/pinconf-generic.c +2 -1
@@ -231,9 +231,10 @@ static void parse_dt_cfg(struct device_node *np,* pinconf_generic_parse_dt_config() * parse the config properties into generic pinconfig values. * @np: node containing the pinconfig properties +* @pctldev: pincontrol device * @configs: array with nconfigs entries containing the generic pinconf values * must be freed when no longer necessary. -* @nconfigs: umber of configurations +* @nconfigs: number of configurations */ int pinconf_generic_parse_dt_config(struct device_node *np, struct pinctrl_dev *pctldev,
Signature · 1 line
2.25.1
PATCH 15/25 pinctrl: pinctrl-at91-pio4: PM related attribute descriptions
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91-pio4.c:132: warning: Function parameter or member 'pm_wakeup_sources' not described in 'atmel_pioctrl' drivers/pinctrl/pinctrl-at91-pio4.c:132: warning: Function parameter or member 'pm_suspend_backup' not described in 'atmel_pioctrl'
--- drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pinctrl/pinctrl-at91-pio4.c +2 -0
@@ -106,6 +106,8 @@ struct atmel_pin {* @irq_domain: irq domain for the gpio controller. * @irqs: table containing the hw irq number of the bank. The index of the * table is the bank id. +* @pm_wakeup_sources: bitmap of wakeup sources (lines) +* @pm_suspend_backup: backup/restore register values on suspend/resume * @dev: device entry for the Atmel PIO controller. * @node: node of the Atmel PIO controller. */
Signature · 1 line
2.25.1
PATCH 16/25 arch: arm: mach-at91: pm: Move prototypes to mutually included header
In reply to Lee JonesBoth the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | void at91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | void at91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
--- arch/arm/mach-at91/pm.c | 17 ++++++----------- drivers/pinctrl/pinctrl-at91.c | 1 + include/linux/platform_data/atmel.h | 5 +++++ 3 files changed, 12 insertions(+), 11 deletions(-)
arch/arm/mach-at91/pm.c +6 -11
@@ -25,17 +25,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);
@@ -325,6 +314,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif
drivers/pinctrl/pinctrl-at91.c +1 -0
@@ -22,6 +22,7 @@#include <linux/pinctrl/pinmux.h> /* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <linux/platform_data/atmel.h> #include "pinctrl-at91.h" #include "core.h"
include/linux/platform_data/atmel.h +5 -0
@@ -28,4 +28,9 @@ static inline int at91_suspend_entering_slow_clock(void) }#endif +#ifdef CONFIG_PINCTRL_AT91 +void at91_pinctrl_gpio_suspend (void ); +void at91_pinctrl_gpio_resume (void ); +#endif +#endif /* __ATMEL_H__ */
Signature · 1 line
2.25.1
Alexandre Belloni
maintainerRe: [PATCH 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Hi,
include/linux/platform_data/atmel.h
Quoted 74 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>--- arch/arm/mach-at91/pm.c | 17 ++++++----------- drivers/pinctrl/pinctrl-at91.c | 1 + include/linux/platform_data/atmel.h | 5 +++++ 3 files changed, 12 insertions(+), 11 deletions(-)arch/arm/mach-at91/pm.c +6
-11@@ -25,17 +25,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);@@ -325,6 +314,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif drivers/pinctrl/pinctrl-at91.c +1
-0@@ -22,6 +22,7 @@#include <linux/pinctrl/pinmux.h> /* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <linux/platform_data/atmel.h> #include "pinctrl-at91.h" #include "core.h" include/linux/platform_data/atmel.h +0
-0
The plan is to get rid of that file so you should probably find a better location.
Quoted 13 lines
include/linux/platform_data/atmel.h +5
-0@@ -28,4 +28,9 @@ static inline int at91_suspend_entering_slow_clock(void) }#endif +#ifdef CONFIG_PINCTRL_AT91 +void at91_pinctrl_gpio_suspend (void ); +void at91_pinctrl_gpio_resume (void ); +#endif +#endif /* __ATMEL_H__ */ Signature · 1 line
2.25.1
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Quoted 9 lines · Alexandre Belloni
include/linux/platform_data/atmel.h
Quoted 4 lines · Lee Jones
include/linux/platform_data/atmel.h +0
-0The plan is to get rid of that file so you should probably find a better location.
OK I dropped this one patch from the set for now.
Yours,
Linus Walleij
Re: [PATCH 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
In reply to Alexandre BelloniQuoted 71 lines · Alexandre Belloni
Hi,
Quoted 68 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>--- arch/arm/mach-at91/pm.c | 17 ++++++----------- drivers/pinctrl/pinctrl-at91.c | 1 + include/linux/platform_data/atmel.h | 5 +++++ 3 files changed, 12 insertions(+), 11 deletions(-)arch/arm/mach-at91/pm.c +6
-11@@ -25,17 +25,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);@@ -325,6 +314,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif drivers/pinctrl/pinctrl-at91.c +1
-0@@ -22,6 +22,7 @@#include <linux/pinctrl/pinmux.h> /* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <linux/platform_data/atmel.h>
Quoted 9 lines
include/linux/platform_data/atmel.h
Quoted 6 lines
drivers/pinctrl/pinctrl-at91.c +0
-0#include "pinctrl-at91.h" #include "core.h" include/linux/platform_data/atmel.h +0
-0The plan is to get rid of that file so you should probably find a better location.
Suggestions welcome.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Alexandre Belloni
maintainerRe: [PATCH 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Quoted 20 lines · Lee Jones
Quoted 10 lines
Quoted 10 lines
drivers/pinctrl/pinctrl-at91.c +1
-0@@ -22,6 +22,7 @@#include <linux/pinctrl/pinmux.h> /* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <linux/platform_data/atmel.h> Quoted 9 lines
include/linux/platform_data/atmel.h
Quoted 6 lines
drivers/pinctrl/pinctrl-at91.c +0
-0#include "pinctrl-at91.h" #include "core.h" include/linux/platform_data/atmel.h +0
-0The plan is to get rid of that file so you should probably find a better location.
Quoted 2 lines
Suggestions welcome.
Something like include/soc/at91/pm.h so we can also move at91_suspend_entering_slow_clock there and then kill platform_data/atmel.h.
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 16/25 arch: arm: mach-at91: pm: Move prototypes to mutually included header
In reply to Lee JonesBoth the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | void at91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | void at91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
---
v2: Moved shared header to: include/soc/at91/pm.h
arch/arm/mach-at91/pm.c | 19 ++++++++----------- drivers/pinctrl/pinctrl-at91.c | 2 ++ include/soc/at91/pm.h | 9 +++++++++ 3 files changed, 19 insertions(+), 11 deletions(-) create mode 100644 include/soc/at91/pm.h
arch/arm/mach-at91/pm.c +8 -11
@@ -17,6 +17,8 @@#include <linux/clk/at91_pmc.h> #include <linux/platform_data/atmel.h> +#include <soc/at91/pm.h> +#include <asm/cacheflush.h> #include <asm/fncpy.h> #include <asm/system_misc.h>
@@ -25,17 +27,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);
@@ -326,6 +317,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif
drivers/pinctrl/pinctrl-at91.c +2 -0
@@ -23,6 +23,8 @@/* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <soc/at91/pm.h> +#include "pinctrl-at91.h" #include "core.h"
include/soc/at91/pm.h new file +9 -0
@@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* atmel platform data +*/ + +#ifdef CONFIG_PINCTRL_AT91 +void at91_pinctrl_gpio_suspend (void ); +void at91_pinctrl_gpio_resume (void ); +#endif
Signature · 1 line
2.25.1
Alexandre Belloni
maintainerRe: [PATCH v2 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Hi,
Quoted 90 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>---
v2: Moved shared header to:
include/soc/at91/pm.harch/arm/mach-at91/pm.c | 19 ++++++++----------- drivers/pinctrl/pinctrl-at91.c | 2 ++ include/soc/at91/pm.h | 9 +++++++++ 3 files changed, 19 insertions(+), 11 deletions(-) create mode 100644 include/soc/at91/pm.harch/arm/mach-at91/pm.c +8
-11@@ -17,6 +17,8 @@#include <linux/clk/at91_pmc.h> #include <linux/platform_data/atmel.h> +#include <soc/at91/pm.h> +#include <asm/cacheflush.h> #include <asm/fncpy.h> #include <asm/system_misc.h> @@ -25,17 +27,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);@@ -326,6 +317,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif drivers/pinctrl/pinctrl-at91.c +2
-0@@ -23,6 +23,8 @@/* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <soc/at91/pm.h> +#include "pinctrl-at91.h" #include "core.h" include/soc/at91/pm.h new file +0
-0
include/soc/at91/pm.h line 6
Quoted 6 lines
include/soc/at91/pm.h new file +6
-0@@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* atmel platform data +*/ + +#ifdef CONFIG_PINCTRL_AT91
Shouldn't that be a header guard instead of depending on PINCTRL_AT91 ?
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH v2 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Quoted 21 lines · Alexandre Belloni
Hi,
Quoted 18 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>---
[...]
Quoted 6 lines
Quoted 6 lines
include/soc/at91/pm.h new file +0
-0@@ -0,0 +1,9 @@
Quoted 8 lines
include/soc/at91/pm.h line 6
Quoted 6 lines
include/soc/at91/pm.h new file +6
-0+/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* atmel platform data +*/ + +#ifdef CONFIG_PINCTRL_AT91 Shouldn't that be a header guard instead of depending on
PINCTRL_AT91?
I copied the same semantics from the header it was taken from.
Happy to turn it into a proper header file too.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Alexandre Belloni
maintainerRe: [PATCH v2 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Quoted 41 lines · Lee Jones
Quoted 21 lines · Alexandre Belloni
Hi,
Quoted 18 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>---
[...]
Quoted 6 lines
Quoted 6 lines
include/soc/at91/pm.h new file +0
-0@@ -0,0 +1,9 @@Quoted 8 lines
include/soc/at91/pm.h line 6
Quoted 6 lines
include/soc/at91/pm.h new file +6
-0+/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* atmel platform data +*/ + +#ifdef CONFIG_PINCTRL_AT91 Shouldn't that be a header guard instead of depending on
PINCTRL_AT91?
Quoted 3 lines
I copied the same semantics from the header it was taken from.
Happy to turn it into a proper header file too.
I guess that would be better. How do you expect this patch to be merged?
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH v2 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Quoted 42 lines · Alexandre Belloni
Quoted 41 lines · Lee Jones
Quoted 21 lines · Alexandre Belloni
Hi,
Quoted 18 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>---
[...]
Quoted 14 lines
include/soc/at91/pm.h line 6
Quoted 12 lines
include/soc/at91/pm.h new file +6
-0@@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* atmel platform data +*/ + +#ifdef CONFIG_PINCTRL_AT91 Shouldn't that be a header guard instead of depending on
PINCTRL_AT91?
Quoted 5 lines
Quoted 3 lines
I copied the same semantics from the header it was taken from.
Happy to turn it into a proper header file too.
I guess that would be better. How do you expect this patch to be merged?
I'll fix it.
No expectations. Whatever's easiest.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v3 16/25 arch: arm: mach-at91: pm: Move prototypes to mutually included header
In reply to Lee JonesBoth the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | void at91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | void at91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
--- arch/arm/mach-at91/pm.c | 19 ++++++++----------- drivers/pinctrl/pinctrl-at91.c | 2 ++ include/soc/at91/pm.h | 16 ++++++++++++++++ 3 files changed, 26 insertions(+), 11 deletions(-) create mode 100644 include/soc/at91/pm.h
arch/arm/mach-at91/pm.c +8 -11
@@ -17,6 +17,8 @@#include <linux/clk/at91_pmc.h> #include <linux/platform_data/atmel.h> +#include <soc/at91/pm.h> +#include <asm/cacheflush.h> #include <asm/fncpy.h> #include <asm/system_misc.h>
@@ -25,17 +27,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);
@@ -326,6 +317,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif
drivers/pinctrl/pinctrl-at91.c +2 -0
@@ -23,6 +23,8 @@/* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <soc/at91/pm.h> +#include "pinctrl-at91.h" #include "core.h"
include/soc/at91/pm.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Atmel Power Management +* +* Copyright (C) 2020 Atmel +* +* Author: Lee Jones <[email protected]> +*/ + +#ifndef __SOC_ATMEL_PM_H +#define __SOC_ATMEL_PM_H + +void at91_pinctrl_gpio_suspend (void ); +void at91_pinctrl_gpio_resume (void ); + +#endif /* __SOC_ATMEL_PM_H */
Signature · 1 line
2.25.1
Re: [PATCH v3 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header
Quoted 12 lines · Lee Jones
Both the caller and the supplier's source file should have access to the include file containing the prototypes.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] 1637 | voidat91_pinctrl_gpio_suspend(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] 1661 | voidat91_pinctrl_gpio_resume(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
Quoted 5 lines
Cc Russell King <[email protected]>Cc Nicolas Ferre <[email protected]>Cc Alexandre Belloni <[email protected]>Cc Ludovic Desroches <[email protected]>Signed-off-by Lee Jones <[email protected]>
This is my ack in case Linus wants that to go through the pinctrl tree, which is fine with me.
I can also take it through the at91 tree with Linus' ack.
Quoted 88 lines
--- arch/arm/mach-at91/pm.c | 19 ++++++++----------- drivers/pinctrl/pinctrl-at91.c | 2 ++ include/soc/at91/pm.h | 16 ++++++++++++++++ 3 files changed, 26 insertions(+), 11 deletions(-) create mode 100644 include/soc/at91/pm.harch/arm/mach-at91/pm.c +8
-11@@ -17,6 +17,8 @@#include <linux/clk/at91_pmc.h> #include <linux/platform_data/atmel.h> +#include <soc/at91/pm.h> +#include <asm/cacheflush.h> #include <asm/fncpy.h> #include <asm/system_misc.h> @@ -25,17 +27,6 @@#include "generic.h" #include "pm.h" -/* -* FIXME: this is needed to communicate between the pinctrl driver and -* the PM implementation in the machine. Possibly part of the PM -* implementation should be moved down into the pinctrl driver and get -* called as part of the generic suspend/resume path. -*/ -#ifdef CONFIG_PINCTRL_AT91 -extern void at91_pinctrl_gpio_suspend (void ); -extern void at91_pinctrl_gpio_resume (void ); -#endif -struct at91_soc_pm {int (*config_shdwc_ws)(void __iomem *shdwc,u32 *mode,u32 *polarity);int (*config_pmc_ws)(void __iomem *pmc,u32 mode,u32 polarity);@@ -326,6 +317,12 @@ static void at91_pm_suspend(suspend_state_t state)static int at91_pm_enter (suspend_state_t state) {#ifdef CONFIG_PINCTRL_AT91 +/* +* FIXME: this is needed to communicate between the pinctrl driver and +* the PM implementation in the machine. Possibly part of the PM +* implementation should be moved down into the pinctrl driver and get +* called as part of the generic suspend/resume path. +*/ at91_pinctrl_gpio_suspend ();#endif drivers/pinctrl/pinctrl-at91.c +2
-0@@ -23,6 +23,8 @@/* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <soc/at91/pm.h> +#include "pinctrl-at91.h" #include "core.h" include/soc/at91/pm.h new file +16
-0@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Atmel Power Management +* +* Copyright (C) 2020 Atmel +* +* Author: Lee Jones <[email protected]> +*/ + +#ifndef __SOC_ATMEL_PM_H +#define __SOC_ATMEL_PM_H + +void at91_pinctrl_gpio_suspend (void ); +void at91_pinctrl_gpio_resume (void ); + +#endif /* __SOC_ATMEL_PM_H */ Signature · 1 line
2.25.1
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 17/25 pinctrl: pinctrl-at91: Demote non-kerneldoc header and complete another
In reply to Lee JonesThe documentation header for 'struct at91_pinctrl_mux_ops' was missing entries for {g,s}et_drivestrength and {g,s}et_slewrate.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-at91.c:77: warning: cannot understand function prototype: 'enum drive_strength_bit ' drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'get_drivestrength' not described in 'at91_pinctrl_mux_ops' drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'set_drivestrength' not described in 'at91_pinctrl_mux_ops' drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'get_slewrate' not described in 'at91_pinctrl_mux_ops' drivers/pinctrl/pinctrl-at91.c:187: warning: Function parameter or member 'set_slewrate' not described in 'at91_pinctrl_mux_ops'
--- drivers/pinctrl/pinctrl-at91.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/pinctrl/pinctrl-at91.c +5 -1
@@ -66,7 +66,7 @@ static int gpio_banks;#define DEBOUNCE_VAL_SHIFT 17#define DEBOUNCE_VAL (0x3fff << DEBOUNCE_VAL_SHIFT) -/** +/* * These defines will translated the dt binding settings to our internal * settings. They are not necessarily the same value as the register setting. * The actual drive strength current of low, medium and high must be looked up
@@ -162,6 +162,10 @@ struct at91_pin_group {* @set_pulldown: enable/disable pulldown * @get_schmitt_trig: get schmitt trigger status * @disable_schmitt_trig: disable schmitt trigger +* @get_drivestrength: get driver strength +* @set_drivestrength: set driver strength +* @get_slewrate: get slew rate +* @set_slewrate: set slew rate * @irq_type: return irq type */ struct at91_pinctrl_mux_ops {
Signature · 1 line
2.25.1
PATCH 18/25 pinctrl: pinctrl-bm1880: Rename ill documented struct attribute entries
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pctrldev' not described in 'bm1880_pinctrl' drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pinconf' not described in 'bm1880_pinctrl'
--- drivers/pinctrl/pinctrl-bm1880.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-bm1880.c +2 -2
@@ -22,12 +22,12 @@/** * struct bm1880_pinctrl - driver data * @base: Pinctrl base address -* @pctrl: Pinctrl device +* @pctrldev: Pinctrl device * @groups: Pingroups * @ngroups: Number of @groups * @funcs: Pinmux functions * @nfuncs: Number of @funcs -* @pconf: Pinconf data +* @pinconf: Pinconf data */ struct bm1880_pinctrl {void __iomem *base;
Signature · 1 line
2.25.1
Re: [PATCH 18/25] pinctrl: pinctrl-bm1880: Rename ill documented struct attribute entries
Quoted 7 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pctrldev' not described in 'bm1880_pinctrl'drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pinconf' not described in 'bm1880_pinctrl'Cc Manivannan Sadhasivam <[email protected]>Signed-off-by Lee Jones <[email protected]>
Thanks,
Mani
Quoted 26 lines
--- drivers/pinctrl/pinctrl-bm1880.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/pinctrl/pinctrl-bm1880.c +2
-2@@ -22,12 +22,12 @@/** * struct bm1880_pinctrl - driver data * @base: Pinctrl base address -* @pctrl: Pinctrl device +* @pctrldev: Pinctrl device * @groups: Pingroups * @ngroups: Number of @groups * @funcs: Pinmux functions * @nfuncs: Number of @funcs -* @pconf: Pinconf data +* @pinconf: Pinconf data */ struct bm1880_pinctrl {void __iomem *base;Signature · 1 line
2.25.1
PATCH 19/25 pinctrl: pinctrl-rockchip: Fix a bunch of kerneldoc misdemeanours
In reply to Lee JonesDemote headers which are clearly not kerneldoc, provide titles for struct definition blocks, fix API slip (bitrot) misspellings and provide some missing entries.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-rockchip.c:82: warning: cannot understand function prototype: 'struct rockchip_iomux ' drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_DEFAULT' not described in enum 'rockchip_pin_drv_type' drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_1V8_OR_3V0' not described in enum 'rockchip_pin_drv_type' drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_1V8_ONLY' not described in enum 'rockchip_pin_drv_type' drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_1V8_3V0_AUTO' not described in enum 'rockchip_pin_drv_type' drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_3V3_ONLY' not described in enum 'rockchip_pin_drv_type' drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_MAX' not described in enum 'rockchip_pin_drv_type' drivers/pinctrl/pinctrl-rockchip.c:106: warning: Enum value 'PULL_TYPE_IO_DEFAULT' not described in enum 'rockchip_pin_pull_type' drivers/pinctrl/pinctrl-rockchip.c:106: warning: Enum value 'PULL_TYPE_IO_1V8_ONLY' not described in enum 'rockchip_pin_pull_type' drivers/pinctrl/pinctrl-rockchip.c:106: warning: Enum value 'PULL_TYPE_MAX' not described in enum 'rockchip_pin_pull_type' drivers/pinctrl/pinctrl-rockchip.c:109: warning: Cannot understand * @drv_type: drive strength variant using rockchip_perpin_drv_type on line 109 - I thought it was a doc line
drivers/pinctrl/pinctrl-rockchip.c:122: warning: Cannot understand * @reg_base: register base of the gpio bank
on line 109 - I thought it was a doc line
drivers/pinctrl/pinctrl-rockchip.c:325: warning: Function parameter or member 'route_location' not described in 'rockchip_mux_route_data' drivers/pinctrl/pinctrl-rockchip.c:328: warning: Cannot understand */
on line 109 - I thought it was a doc line
drivers/pinctrl/pinctrl-rockchip.c:375: warning: Function parameter or member 'data' not described in 'rockchip_pin_group' drivers/pinctrl/pinctrl-rockchip.c:387: warning: Function parameter or member 'ngroups' not described in 'rockchip_pmx_func'
--- drivers/pinctrl/pinctrl-rockchip.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)
drivers/pinctrl/pinctrl-rockchip.c +12 -10
@@ -63,7 +63,7 @@ enum rockchip_pinctrl_type { RK3399, }; -/** +/* * Encode variants of iomux registers into a type variable */ #define IOMUX_GPIO_ONLY BIT(0)
@@ -74,6 +74,7 @@ enum rockchip_pinctrl_type {#define IOMUX_WIDTH_2BIT BIT(5)/** +* struct rockchip_iomux * @type: iomux variant using IOMUX_* constants * @offset: if initialized to -1 it will be autocalculated, by specifying * an initial offset value the relevant source offset can be reset
@@ -84,7 +85,7 @@ struct rockchip_iomux {int offset; }; -/** +/* * enum type index corresponding to rockchip_perpin_drv_list arrays index. */ enum rockchip_pin_drv_type {
@@ -96,7 +97,7 @@ enum rockchip_pin_drv_type {DRV_TYPE_MAX }; -/** +/* * enum type index corresponding to rockchip_pull_list arrays index. */ enum rockchip_pin_pull_type {
@@ -106,6 +107,7 @@ enum rockchip_pin_pull_type { };/** +* struct rockchip_drv * @drv_type: drive strength variant using rockchip_perpin_drv_type * @offset: if initialized to -1 it will be autocalculated, by specifying * an initial offset value the relevant source offset can be reset
@@ -119,8 +121,9 @@ struct rockchip_drv { };/** +* struct rockchip_pin_bank * @reg_base: register base of the gpio bank -* @reg_pull: optional separate register for additional pull settings +* @regmap_pull: optional separate register for additional pull settings * @clk: clock of the gpio bank * @irq: interrupt of the gpio bank * @saved_masks: Saved content of GPIO_INTEN at suspend time.
@@ -138,6 +141,8 @@ struct rockchip_drv {* @gpio_chip: gpiolib chip * @grange: gpio range * @slock: spinlock for the gpio bank +* @toggle_edge_mode: bit mask to toggle (falling/rising) edge mode +* @recalced_mask: bit mask to indicate a need to recalulate the mask * @route_mask: bits describing the routing pins of per bank */ struct rockchip_pin_bank {
@@ -312,6 +317,7 @@ enum rockchip_mux_route_location {* @bank_num: bank number. * @pin: index at register or used to calc index. * @func: the min pin. +* @route_location: the mux route location (same, pmu, grf). * @route_offset: the max pin. * @route_val: the register offset. */
@@ -324,8 +330,6 @@ struct rockchip_mux_route_data {u32 route_val; }; -/** -*/ struct rockchip_pin_ctrl {struct rockchip_pin_bank *pin_banks;u32 nr_banks;
@@ -363,9 +367,7 @@ struct rockchip_pin_config {* @name: name of the pin group, used to lookup the group. * @pins: the pins included in this group. * @npins: number of pins included in this group. -* @func: the mux function number to be programmed when selected. -* @configs: the config values to be set for each pin -* @nconfigs: number of configs for each pin +* @data: local pin configuration */ struct rockchip_pin_group {const char *name;
@@ -378,7 +380,7 @@ struct rockchip_pin_group {* struct rockchip_pmx_func: represent a pin function. * @name: name of the pin function, used to lookup the function. * @groups: one or more names of pin groups that provide this function. -* @num_groups: number of groups included in @groups. +* @ngroups: number of groups included in @groups. */ struct rockchip_pmx_func {const char *name;
Signature · 1 line
2.25.1
Re: [PATCH 19/25] pinctrl: pinctrl-rockchip: Fix a bunch of kerneldoc misdemeanours
Am Montag, 13. Juli 2020, 16:49:24 CEST schrieb Lee Jones:
Quoted 26 lines
Demote headers which are clearly not kerneldoc, provide titles for struct definition blocks, fix API slip (bitrot) misspellings and provide some missing entries.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-rockchip.c:82: warning: cannot understand function prototype: 'structrockchip_iomux'drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_DEFAULT' not described in enum 'rockchip_pin_drv_type'drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_1V8_OR_3V0' not described in enum 'rockchip_pin_drv_type'drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_1V8_ONLY' not described in enum 'rockchip_pin_drv_type'drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_1V8_3V0_AUTO' not described in enum 'rockchip_pin_drv_type'drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_IO_3V3_ONLY' not described in enum 'rockchip_pin_drv_type'drivers/pinctrl/pinctrl-rockchip.c:97: warning: Enum value 'DRV_TYPE_MAX' not described in enum 'rockchip_pin_drv_type'drivers/pinctrl/pinctrl-rockchip.c:106: warning: Enum value 'PULL_TYPE_IO_DEFAULT' not described in enum 'rockchip_pin_pull_type'drivers/pinctrl/pinctrl-rockchip.c:106: warning: Enum value 'PULL_TYPE_IO_1V8_ONLY' not described in enum 'rockchip_pin_pull_type'drivers/pinctrl/pinctrl-rockchip.c:106: warning: Enum value 'PULL_TYPE_MAX' not described in enum 'rockchip_pin_pull_type'drivers/pinctrl/pinctrl-rockchip.c:109: warning: Cannot understand * @drv_type: drive strength variant usingrockchip_perpin_drv_typeon line 109 - I thought it was a doc line
drivers/pinctrl/pinctrl-rockchip.c:122: warning: Cannot understand * @reg_base: register base of the gpio bank
on line 109 - I thought it was a doc line
drivers/pinctrl/pinctrl-rockchip.c:325: warning: Function parameter or member 'route_location' not described in 'rockchip_mux_route_data'drivers/pinctrl/pinctrl-rockchip.c:328: warning: Cannot understand */
on line 109 - I thought it was a doc line
drivers/pinctrl/pinctrl-rockchip.c:375: warning: Function parameter or member 'data' not described in 'rockchip_pin_group'drivers/pinctrl/pinctrl-rockchip.c:387: warning: Function parameter or member 'ngroups' not described in 'rockchip_pmx_func'
Quoted 4 lines
Cc Heiko Stuebner <[email protected]>Cc Jean-Christophe PLAGNIOL-VILLARD <[email protected]>Signed-off-by Lee Jones <[email protected]>
Thanks for fixing these doc issues
PATCH 20/25 pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
In reply to Lee JonesSome description blocks are void of any description/documentation, others are missing 'struct' identifiers, there are also a couple of misspellings of function parameter names. Fix all of them.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-rza1.c:81: warning: cannot understand function prototype: 'struct rza1_bidir_pin ' drivers/pinctrl/pinctrl-rza1.c:90: warning: cannot understand function prototype: 'struct rza1_bidir_entry ' drivers/pinctrl/pinctrl-rza1.c:98: warning: cannot understand function prototype: 'struct rza1_swio_pin ' drivers/pinctrl/pinctrl-rza1.c:108: warning: cannot understand function prototype: 'struct rza1_swio_entry ' drivers/pinctrl/pinctrl-rza1.c:116: warning: cannot understand function prototype: 'struct rza1_pinmux_conf ' drivers/pinctrl/pinctrl-rza1.c:443: warning: cannot understand function prototype: 'struct rza1_mux_conf ' drivers/pinctrl/pinctrl-rza1.c:462: warning: cannot understand function prototype: 'struct rza1_port ' drivers/pinctrl/pinctrl-rza1.c:482: warning: cannot understand function prototype: 'struct rza1_pinctrl ' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'port' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'pin' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'func' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pinmux_get_flags' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'port' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'reg' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'bit' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'set' not described in 'rza1_set_bit' drivers/pinctrl/pinctrl-rza1.c:672: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pin_mux_single' drivers/pinctrl/pinctrl-rza1.c:672: warning: Excess function parameter 'pinctrl' description in 'rza1_pin_mux_single'
--- drivers/pinctrl/pinctrl-rza1.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/pinctrl/pinctrl-rza1.c +12 -12
@@ -75,7 +75,7 @@* RZ/A1 pinmux flags */ -/** +/* * rza1_bidir_pin - describe a single pin that needs bidir flag applied. */ struct rza1_bidir_pin {
@@ -83,7 +83,7 @@ struct rza1_bidir_pin { u8 func: 4; }; -/** +/* * rza1_bidir_entry - describe a list of pins that needs bidir flag applied. * Each struct rza1_bidir_entry describes a port. */
@@ -92,7 +92,7 @@ struct rza1_bidir_entry {const struct rza1_bidir_pin *pins; }; -/** +/* * rza1_swio_pin - describe a single pin that needs swio flag applied. */ struct rza1_swio_pin {
@@ -102,7 +102,7 @@ struct rza1_swio_pin { u16 input: 1; }; -/** +/* * rza1_swio_entry - describe a list of pins that needs swio flag applied */ struct rza1_swio_entry {
@@ -110,7 +110,7 @@ struct rza1_swio_entry {const struct rza1_swio_pin *pins; }; -/** +/* * rza1_pinmux_conf - group together bidir and swio pinmux flag tables */ struct rza1_pinmux_conf {
@@ -431,7 +431,7 @@ static const struct rza1_pinmux_conf rza1l_pmx_conf = {* RZ/A1 types */ /** -* rza1_mux_conf - describes a pin multiplexing operation +* struct rza1_mux_conf - describes a pin multiplexing operation * * @id: the pin identifier from 0 to RZA1_NPINS * @port: the port where pin sits on
@@ -450,7 +450,7 @@ struct rza1_mux_conf { };/** -* rza1_port - describes a pin port +* struct rza1_port - describes a pin port * * This is mostly useful to lock register writes per-bank and not globally. *
@@ -467,12 +467,12 @@ struct rza1_port { };/** -* rza1_pinctrl - RZ pincontroller device +* struct rza1_pinctrl - RZ pincontroller device * * @dev: parent device structure * @mutex: protect [pinctrl|pinmux]_generic functions * @base: logical address base -* @nports: number of pin controller ports +* @nport: number of pin controller ports * @ports: pin controller banks * @pins: pin array for pinctrl core * @desc: pincontroller desc for pinctrl core
@@ -536,7 +536,7 @@ static inline int rza1_pinmux_get_swio(unsigned int port,return -ENOENT ; } -/** +/* * rza1_pinmux_get_flags() - return pinmux flags associated to a pin */ static unsigned int rza1_pinmux_get_flags(unsigned int port, unsigned int pin,
@@ -566,7 +566,7 @@ static unsigned int rza1_pinmux_get_flags(unsigned int port, unsigned int pin,* RZ/A1 SoC operations */ -/** +/* * rza1_set_bit() - un-locked set/clear a single bit in pin configuration * registers */
@@ -664,7 +664,7 @@ static inline int rza1_pin_get(struct rza1_port *port, unsigned int pin)/** * rza1_pin_mux_single() - configure pin multiplexing on a single pin * -* @pinctrl: RZ/A1 pin controller device +* @rza1_pctl: RZ/A1 pin controller device * @mux_conf: pin multiplexing descriptor */ static int rza1_pin_mux_single(struct rza1_pinctrl *rza1_pctl,
Signature · 1 line
2.25.1
Re: [PATCH 20/25] pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
Hi Lee,
Quoted 25 lines · Lee Jones
Some description blocks are void of any description/documentation, others are missing 'struct' identifiers, there are also a couple of misspellings of function parameter names. Fix all of them.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-rza1.c:81: warning: cannot understand function prototype: 'structrza1_bidir_pin'drivers/pinctrl/pinctrl-rza1.c:90: warning: cannot understand function prototype: 'structrza1_bidir_entry'drivers/pinctrl/pinctrl-rza1.c:98: warning: cannot understand function prototype: 'structrza1_swio_pin'drivers/pinctrl/pinctrl-rza1.c:108: warning: cannot understand function prototype: 'structrza1_swio_entry'drivers/pinctrl/pinctrl-rza1.c:116: warning: cannot understand function prototype: 'structrza1_pinmux_conf'drivers/pinctrl/pinctrl-rza1.c:443: warning: cannot understand function prototype: 'structrza1_mux_conf'drivers/pinctrl/pinctrl-rza1.c:462: warning: cannot understand function prototype: 'structrza1_port'drivers/pinctrl/pinctrl-rza1.c:482: warning: cannot understand function prototype: 'structrza1_pinctrl'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'port' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'pin' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'func' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'port' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'reg' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'bit' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'set' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:672: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pin_mux_single'drivers/pinctrl/pinctrl-rza1.c:672: warning: Excess function parameter 'pinctrl' description in 'rza1_pin_mux_single'
Quoted 4 lines
Cc Geert Uytterhoeven <[email protected]>Cc Jacopo Mondi <[email protected]>Signed-off-by Lee Jones <[email protected]>
Thanks, at the time I had no real idea about the implications of documenting with kerneldoc :)
Thanks
j
Quoted 116 lines
--- drivers/pinctrl/pinctrl-rza1.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)drivers/pinctrl/pinctrl-rza1.c +12
-13@@ -75,7 +75,7 @@* RZ/A1 pinmux flags */ -/** +/* * rza1_bidir_pin - describe a single pin that needs bidir flag applied. */ struct rza1_bidir_pin {@@ -83,7 +83,7 @@ struct rza1_bidir_pin { u8 func: 4; }; -/** +/* * rza1_bidir_entry - describe a list of pins that needs bidir flag applied. * Each struct rza1_bidir_entry describes a port. */ @@ -92,7 +92,7 @@ struct rza1_bidir_entry {const struct rza1_bidir_pin *pins; }; -/** +/* * rza1_swio_pin - describe a single pin that needs swio flag applied. */ struct rza1_swio_pin {@@ -102,7 +102,7 @@ struct rza1_swio_pin { u16 input: 1; }; -/** +/* * rza1_swio_entry - describe a list of pins that needs swio flag applied */ struct rza1_swio_entry {@@ -110,7 +110,7 @@ struct rza1_swio_entry {const struct rza1_swio_pin *pins; }; -/** +/* * rza1_pinmux_conf - group together bidir and swio pinmux flag tables */ struct rza1_pinmux_conf {@@ -431,7 +431,7 @@ static const struct rza1_pinmux_conf rza1l_pmx_conf = {* RZ/A1 types */ /** -* rza1_mux_conf - describes a pin multiplexing operation +* struct rza1_mux_conf - describes a pin multiplexing operation * * @id: the pin identifier from 0 to RZA1_NPINS * @port: the port where pin sits on @@ -450,7 +450,7 @@ struct rza1_mux_conf { };/** -* rza1_port - describes a pin port +* struct rza1_port - describes a pin port * * This is mostly useful to lock register writes per-bank and not globally. * @@ -467,12 +467,12 @@ struct rza1_port { };/** -* rza1_pinctrl - RZ pincontroller device +* struct rza1_pinctrl - RZ pincontroller device * * @dev: parent device structure * @mutex: protect [pinctrl|pinmux]_generic functions * @base: logical address base -* @nports: number of pin controller ports +* @nport: number of pin controller ports * @ports: pin controller banks * @pins: pin array for pinctrl core * @desc: pincontroller desc for pinctrl core @@ -536,7 +536,7 @@ static inline int rza1_pinmux_get_swio(unsigned int port,return -ENOENT ; } -/** +/* * rza1_pinmux_get_flags() - return pinmux flags associated to a pin */ static unsigned int rza1_pinmux_get_flags(unsigned int port, unsigned int pin,@@ -566,7 +566,7 @@ static unsigned int rza1_pinmux_get_flags(unsigned int port, unsigned int pin,* RZ/A1 SoC operations */ -/** +/* * rza1_set_bit() - un-locked set/clear a single bit in pin configuration * registers */ @@ -664,7 +664,7 @@ static inline int rza1_pin_get(struct rza1_port *port, unsigned int pin)/** * rza1_pin_mux_single() - configure pin multiplexing on a single pin * -* @pinctrl: RZ/A1 pin controller device +* @rza1_pctl: RZ/A1 pin controller device * @mux_conf: pin multiplexing descriptor */ static int rza1_pin_mux_single(struct rza1_pinctrl *rza1_pctl, --2.25.1
Re: [PATCH 20/25] pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
Quoted 28 lines · Jacopo Mondi
Hi Lee,
Quoted 25 lines · Lee Jones
Some description blocks are void of any description/documentation, others are missing 'struct' identifiers, there are also a couple of misspellings of function parameter names. Fix all of them.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-rza1.c:81: warning: cannot understand function prototype: 'structrza1_bidir_pin'drivers/pinctrl/pinctrl-rza1.c:90: warning: cannot understand function prototype: 'structrza1_bidir_entry'drivers/pinctrl/pinctrl-rza1.c:98: warning: cannot understand function prototype: 'structrza1_swio_pin'drivers/pinctrl/pinctrl-rza1.c:108: warning: cannot understand function prototype: 'structrza1_swio_entry'drivers/pinctrl/pinctrl-rza1.c:116: warning: cannot understand function prototype: 'structrza1_pinmux_conf'drivers/pinctrl/pinctrl-rza1.c:443: warning: cannot understand function prototype: 'structrza1_mux_conf'drivers/pinctrl/pinctrl-rza1.c:462: warning: cannot understand function prototype: 'structrza1_port'drivers/pinctrl/pinctrl-rza1.c:482: warning: cannot understand function prototype: 'structrza1_pinctrl'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'port' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'pin' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'func' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'port' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'reg' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'bit' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'set' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:672: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pin_mux_single'drivers/pinctrl/pinctrl-rza1.c:672: warning: Excess function parameter 'pinctrl' description in 'rza1_pin_mux_single'
Quoted 7 lines
Quoted 4 lines
Cc Geert Uytterhoeven <[email protected]>Cc Jacopo Mondi <[email protected]>Signed-off-by Lee Jones <[email protected]>Thanks, at the time I had no real idea about the implications of documenting with kerneldoc :)
You and 1000 others! :D
Don't lose any sleep over it.
Quoted 1 line
Acked-by Jacopo Mondi <[email protected]>
Thanks.
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 20/25] pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
In reply to Lee JonesHi Lee,
Quoted 25 lines · Lee Jones
Some description blocks are void of any description/documentation, others are missing 'struct' identifiers, there are also a couple of misspellings of function parameter names. Fix all of them.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-rza1.c:81: warning: cannot understand function prototype: 'structrza1_bidir_pin'drivers/pinctrl/pinctrl-rza1.c:90: warning: cannot understand function prototype: 'structrza1_bidir_entry'drivers/pinctrl/pinctrl-rza1.c:98: warning: cannot understand function prototype: 'structrza1_swio_pin'drivers/pinctrl/pinctrl-rza1.c:108: warning: cannot understand function prototype: 'structrza1_swio_entry'drivers/pinctrl/pinctrl-rza1.c:116: warning: cannot understand function prototype: 'structrza1_pinmux_conf'drivers/pinctrl/pinctrl-rza1.c:443: warning: cannot understand function prototype: 'structrza1_mux_conf'drivers/pinctrl/pinctrl-rza1.c:462: warning: cannot understand function prototype: 'structrza1_port'drivers/pinctrl/pinctrl-rza1.c:482: warning: cannot understand function prototype: 'structrza1_pinctrl'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'port' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'pin' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'func' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:546: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pinmux_get_flags'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'port' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'reg' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'bit' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:575: warning: Function parameter or member 'set' not described in 'rza1_set_bit'drivers/pinctrl/pinctrl-rza1.c:672: warning: Function parameter or member 'rza1_pctl' not described in 'rza1_pin_mux_single'drivers/pinctrl/pinctrl-rza1.c:672: warning: Excess function parameter 'pinctrl' description in 'rza1_pin_mux_single'
Quoted 4 lines
Cc Geert Uytterhoeven <[email protected]>Cc Jacopo Mondi <[email protected]>Signed-off-by Lee Jones <[email protected]>
i.e. will queue in sh-pfc-for-v5.9.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH 20/25] pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
Quoted 2 lines · Geert Uytterhoeven
Reviewed-by Geert Uytterhoeven <[email protected]>i.e. will queue in sh-pfc-for-v5.9.
OK since Geert is queueing this I'll drop this patch from my tree.
Yours,
Linus Walleij
Re: [PATCH 20/25] pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others
Hi Linus,
Quoted 5 lines · Linus Walleij
Quoted 2 lines · Geert Uytterhoeven
Reviewed-by Geert Uytterhoeven <[email protected]>i.e. will queue in sh-pfc-for-v5.9.
OK since Geert is queueing this I'll drop this patch from my tree.
Oops, sorry, I didn't know you were planning to apply this one.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 21/25 pinctrl: pinctrl-single: Fix struct/function documentation blocks
In reply to Lee JonesAdd some missing attributes/parameter descriptions, remove other superfluous ones, add struct header titles and fix misspellings.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-single.c:50: warning: Function parameter or member 'mask' not described in 'pcs_func_vals' drivers/pinctrl/pinctrl-single.c:97: warning: Function parameter or member 'conf' not described in 'pcs_function' drivers/pinctrl/pinctrl-single.c:97: warning: Function parameter or member 'nconfs' not described in 'pcs_function' drivers/pinctrl/pinctrl-single.c:659: warning: Function parameter or member 'pin_pos' not described in 'pcs_add_pin' drivers/pinctrl/pinctrl-single.c:985: warning: Excess function parameter 'pctldev' description in 'pcs_parse_one_pinctrl_entry'
drivers/pinctrl/pinctrl-single.c:1357: warning: Cannot understand * @reg: virtual address of interrupt register
drivers/pinctrl/pinctrl-single.c:1377: warning: Function parameter or member 'pcs_soc' not described in 'pcs_irq_set' drivers/pinctrl/pinctrl-single.c:1377: warning: Function parameter or member 'irq' not described in 'pcs_irq_set' drivers/pinctrl/pinctrl-single.c:1377: warning: Function parameter or member 'enable' not described in 'pcs_irq_set' drivers/pinctrl/pinctrl-single.c:1458: warning: Function parameter or member 'pcs_soc' not described in 'pcs_irq_handle' drivers/pinctrl/pinctrl-single.c:1458: warning: Excess function parameter 'pcs_irq' description in 'pcs_irq_handle' drivers/pinctrl/pinctrl-single.c:1506: warning: Excess function parameter 'irq' description in 'pcs_irq_chain_handler'
--- drivers/pinctrl/pinctrl-single.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/pinctrl/pinctrl-single.c +10 -3
@@ -42,6 +42,7 @@* struct pcs_func_vals - mux function register offset and value pair * @reg: register virtual address * @val: register value +* @mask: mask */ struct pcs_func_vals {void __iomem *reg;
@@ -83,6 +84,8 @@ struct pcs_conf_type {* @nvals: number of entries in vals array * @pgnames: array of pingroup names the function uses * @npgnames: number of pingroup names the function uses +* @conf: array of pin configurations +* @nconfs: number of pin configurations available * @node: list node */ struct pcs_function {
@@ -653,6 +656,7 @@ static const struct pinconf_ops pcs_pinconf_ops = {* pcs_add_pin() - add a pin to the static per controller pin array * @pcs: pcs driver instance * @offset: register offset from base +* @pin_pos: unused */ static int pcs_add_pin (struct pcs_device *pcs,unsigned offset,unsigned pin_pos)
@@ -959,7 +963,6 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,/** * pcs_parse_one_pinctrl_entry() - parses a device tree mux entry -* @pctldev: pin controller device * @pcs: pinctrl driver instance * @np: device node of the mux entry * @map: map entry
@@ -1353,7 +1356,9 @@ static int pcs_add_gpio_func(struct device_node *node, struct pcs_device *pcs) }return ret; } +/** +* struct pcs_interrupt * @reg: virtual address of interrupt register * @hwirq: hardware irq number * @irq: virtual irq number
@@ -1368,6 +1373,9 @@ struct pcs_interrupt {/** * pcs_irq_set() - enables or disables an interrupt +* @pcs_soc: SoC specific settings +* @irq: interrupt +* @enable: enable or disable the interrupt * * Note that this currently assumes one interrupt per pinctrl * register that is typically used for wake-up events.
@@ -1448,7 +1456,7 @@ static int pcs_irq_set_wake(struct irq_data *d, unsigned int state)/** * pcs_irq_handle() - common interrupt handler -* @pcs_irq: interrupt data +* @pcs_soc: SoC specific settings * * Note that this currently assumes we have one interrupt bit per * mux register. This interrupt is typically used for wake-up events.
@@ -1496,7 +1504,6 @@ static irqreturn_t pcs_irq_handler(int irq, void *d)/** * pcs_irq_handle() - handler for the dedicated chained interrupt case -* @irq: interrupt * @desc: interrupt descriptor * * Use this if you have a separate interrupt for each
Signature · 1 line
2.25.1
Re: [PATCH 21/25] pinctrl: pinctrl-single: Fix struct/function documentation blocks
Quoted 5 lines · Lee Jones
Add some missing attributes/parameter descriptions, remove other superfluous ones, add struct header titles and fix misspellings.
Fixes the following W=1 kernel build warning(s):
Quoted 12 lines
drivers/pinctrl/pinctrl-single.c:50: warning: Function parameter or member 'mask' not described in 'pcs_func_vals'drivers/pinctrl/pinctrl-single.c:97: warning: Function parameter or member 'conf' not described in 'pcs_function'drivers/pinctrl/pinctrl-single.c:97: warning: Function parameter or member 'nconfs' not described in 'pcs_function'drivers/pinctrl/pinctrl-single.c:659: warning: Function parameter or member 'pin_pos' not described in 'pcs_add_pin'drivers/pinctrl/pinctrl-single.c:985: warning: Excess function parameter 'pctldev' description in 'pcs_parse_one_pinctrl_entry'
drivers/pinctrl/pinctrl-single.c:1357: warning: Cannot understand * @reg: virtual address of interrupt register
drivers/pinctrl/pinctrl-single.c:1377: warning: Function parameter or member 'pcs_soc' not described in 'pcs_irq_set'drivers/pinctrl/pinctrl-single.c:1377: warning: Function parameter or member 'irq' not described in 'pcs_irq_set'drivers/pinctrl/pinctrl-single.c:1377: warning: Function parameter or member 'enable' not described in 'pcs_irq_set'drivers/pinctrl/pinctrl-single.c:1458: warning: Function parameter or member 'pcs_soc' not described in 'pcs_irq_handle'drivers/pinctrl/pinctrl-single.c:1458: warning: Excess function parameter 'pcs_irq' description in 'pcs_irq_handle'drivers/pinctrl/pinctrl-single.c:1506: warning: Excess function parameter 'irq' description in 'pcs_irq_chain_handler'
Thanks looks good to me:
PATCH 22/25 pinctrl: tegra: pinctrl-tegra194: Do not initialise field twice
In reply to Lee JonesBoth PIN_PINGROUP_ENTRY_Y() and DRV_PINGROUP_ENTRY_Y() macros are called for each of the 2 pin groups defined here, and both of them initialise 'drv_reg', causing the compiler to complain.
Only initialise 'drv_reg' once.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init] 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 105 | DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_clkreq_n_pgg0’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro ‘PINGROUP’
128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3, 0x14000, 0,
| ^~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for ‘tegra194_groups[0].drv_reg’) 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 105 | DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_clkreq_n_pgg0’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro ‘PINGROUP’
128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3, 0x14000, 0,
| ^~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init] 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 107 | DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_rst_n_pgg1’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro ‘PINGROUP’
130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3, 0x14008, 0,
| ^~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for ‘tegra194_groups[1].drv_reg’) 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 107 | DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_rst_n_pgg1’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro ‘PINGROUP’
130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3, 0x14008, 0,
| ^~~~~~~~
--- drivers/pinctrl/tegra/pinctrl-tegra194.c | 1 - 1 file changed, 1 deletion(-)
drivers/pinctrl/tegra/pinctrl-tegra194.c +0 -1
@@ -98,7 +98,6 @@ static struct tegra_function tegra194_functions[] = { .sfsel_bit = 10, \ .schmitt_bit = schmitt_b, \ .drvtype_bit = 13, \ - .drv_reg = -1, \ .parked_bitmask = 0#define drive_pex_l5_clkreq_n_pgg0 \
Signature · 1 line
2.25.1
Re: [PATCH 22/25] pinctrl: tegra: pinctrl-tegra194: Do not initialise field twice
Quoted 49 lines · Lee Jones
Both
PIN_PINGROUP_ENTRY_Y()andDRV_PINGROUP_ENTRY_Y()macros are called for each of the 2 pin groups defined here, and both of them initialise 'drv_reg', causing the compiler to complain.Only initialise '
drv_reg' once.Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init] 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 105 |DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_clkreq_n_pgg0’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro ‘PINGROUP’
128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3,0x14000, 0,
| ^~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for ‘tegra194_groups[0].drv_reg’) 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:105:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 105 |DRV_PINGROUP_ENTRY_Y(0x14004, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_clkreq_n_pgg0’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:128:2: note: in expansion of macro ‘PINGROUP’
128 | PINGROUP(pex_l5_clkreq_n_pgg0, PE5, RSVD1, RSVD2, RSVD3,0x14000, 0,
| ^~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: warning: initialized field overwritten [-Woverride-init] 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 107 |DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_rst_n_pgg1’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro ‘PINGROUP’
130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3,0x14008, 0,
| ^~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:71:14: note: (near initialization for ‘tegra194_groups[1].drv_reg’) 71 | .drv_reg = ((r)), | ^
drivers/pinctrl/tegra/pinctrl-tegra194.c:107:2: note: in expansion of macro ‘DRV_PINGROUP_ENTRY_Y’ 107 |DRV_PINGROUP_ENTRY_Y(0x1400c, 12, 5, 20, 5, -1, -1, -1, -1, 0)
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:124:3: note: in expansion of macro ‘drive_pex_l5_rst_n_pgg1’ 124 | drive_##pg_name, | ^~~~~~
drivers/pinctrl/tegra/pinctrl-tegra194.c:130:2: note: in expansion of macro ‘PINGROUP’
130 | PINGROUP(pex_l5_rst_n_pgg1, PE5, RSVD1, RSVD2, RSVD3,0x14008, 0,
| ^~~~~~~~
Quoted 7 lines
Cc Thierry Reding <[email protected]>Cc Jonathan Hunter <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/pinctrl/tegra/pinctrl-tegra194.c | 1 - 1 file changed, 1 deletion(-)
Indeed, looks correct to me:
PATCH 23/25 pinctrl: meson: pinctrl-meson-a1: Remove unused const variable 'i2c_slave_groups'
In reply to Lee JonesIt has never been used.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/meson/pinctrl-meson-a1.c:749:27: warning: ‘i2c_slave_groups’ defined but not used [-Wunused-const-variable=] 749 | static const char const i2c_slave_groups[] = {
| ^~~~~~~~~~~~~~~~
--- drivers/pinctrl/meson/pinctrl-meson-a1.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/pinctrl/meson/pinctrl-meson-a1.c +0 -5
@@ -746,11 +746,6 @@ static const char * const i2c3_groups[] = { "i2c3_sck_x", "i2c3_sda_x", "i2c3_sck_f", "i2c3_sda_f", }; -static const char *const i2c_slave_groups[] = { -"i2c_slave_sda_a" ,"i2c_slave_sck_a" , -"i2c_slave_sda_f" ,"i2c_slave_sck_f" , -}; -static const char *const spi_a_groups[] = {"spi_a_mosi_x2" ,"spi_a_ss0_x3" ,"spi_a_sclk_x4" ,"spi_a_miso_x5" ,"spi_a_mosi_x7" ,"spi_a_miso_x8" ,"spi_a_ss0_x9" ,"spi_a_sclk_x10" ,
Signature · 1 line
2.25.1
PATCH 24/25 pinctrl: mvebu: pinctrl-armada-37xx: Update documentation block for 'struct armada_37xx_pin_group'
In reply to Lee JonesCorrect misspellings and provide missing entries.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:68: warning: Function parameter or member 'start_pin' not described in 'armada_37xx_pin_group' drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:68: warning: Function parameter or member 'val' not described in 'armada_37xx_pin_group' drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:68: warning: Function parameter or member 'extra_pin' not described in 'armada_37xx_pin_group' drivers/pinctrl/mvebu/pinctrl-armada-37xx.c:68: warning: Function parameter or member 'extra_npins' not described in 'armada_37xx_pin_group'
--- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +4 -3
@@ -45,13 +45,14 @@* The pins of a pinmux groups are composed of one or two groups of contiguous * pins. * @name: Name of the pin group, used to lookup the group. -* @start_pins: Index of the first pin of the main range of pins belonging to +* @start_pin: Index of the first pin of the main range of pins belonging to * the group * @npins: Number of pins included in the first range * @reg_mask: Bit mask matching the group in the selection register -* @extra_pins: Index of the first pin of the optional second range of pins +* @val: Value to write to the registers for a given function +* @extra_pin: Index of the first pin of the optional second range of pins * belonging to the group -* @npins: Number of pins included in the second optional range +* @extra_npins:Number of pins included in the second optional range * @funcs: A list of pinmux functions that can be selected for this group. * @pins: List of the pins included in the group */
Signature · 1 line
2.25.1
PATCH 25/25 pinctrl: pinctrl-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
In reply to Lee JonesSince ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, 'struct amd_gpio_acpi_match' becomes defined but unused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/pinctrl-amd.c:959:36: warning: ‘amd_gpio_acpi_match’ defined but not used [-Wunused-const-variable=] 959 | static const struct acpi_device_id amd_gpio_acpi_match[] = {
--- drivers/pinctrl/pinctrl-amd.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pinctrl/pinctrl-amd.c +2 -0
@@ -956,12 +956,14 @@ static int amd_gpio_remove(struct platform_device *pdev)return 0 ; } +#ifdef CONFIG_ACPI static const struct acpi_device_id amd_gpio_acpi_match[] = { {"AMD0030" ,0 }, {"AMDI0030" ,0 }, { }, };MODULE_DEVICE_TABLE (acpi, amd_gpio_acpi_match); +#endif static struct platform_driver amd_gpio_driver = { .driver = {
Signature · 1 line
2.25.1
Quoted 1 line · Lee Jones
pinctrl: pinctrl-single: Fix struct/function documentation blocks
This patch didn't apply to v5.8-rc1 so I applied that one separately after merging in all the other patches from a branch.
Seems to work! So all applied.
Also THANKS for doing this!!
Yours,
Linus Walleij