Skip to contentSkip to conversation

ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

PATCH In review Andrew Sy Kim 3 participants 4 messages Jul 17, 2020 – Jul 22, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

---
 include/net/ip_vs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/ip_vs.h +1 -1
index 91a9e1d590a6..9a59a33787cb 100644
@@ -1533,7 +1533,7 @@ static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs)
 
 void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs);
 #else
-static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs) {}
+static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs) {}
 #endif
 
 #define IP_VS_DFWD_METHOD(dest) (atomic_read(&(dest)->conn_flags) & \
Signature · 1 line
2.20.1
maintainer Acked-by on v1 1/1
#1 lore raw

Hello,

Quoted 4 lines · Andrew Sy Kim

Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

Pablo, please apply this too.

Quoted 19 lines
---
 include/net/ip_vs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/ip_vs.h +1 -1
index 91a9e1d590a6..9a59a33787cb 100644
@@ -1533,7 +1533,7 @@ static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs)
 
 void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs);
 #else
-static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs) {}
+static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs) {}
 #endif
 
 #define IP_VS_DFWD_METHOD(dest) (atomic_read(&(dest)->conn_flags) & \
Signature · 1 line
2.20.1

Regards

#2 lore raw
Quoted 5 lines · Julian Anastasov

Hello,

On Fri, 17 Jul 2020, Andrew Sy Kim wrote:

Quoted 8 lines
Quoted 4 lines

Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

Pablo, please apply this too.

I have squashed this fix and "ipvs: ensure RCU read unlock when connection flushing and ipvs is disabled" into the original patch:

"ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1"

maintainer
#3 lore raw

Hello,

Quoted 11 lines · Pablo Neira Ayuso
Quoted 10 lines · Julian Anastasov
Quoted 4 lines · Andrew Sy Kim

Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

Quoted 7 lines
Quoted 1 line

Pablo, please apply this too.

I have squashed this fix and "ipvs: ensure RCU read unlock when connection flushing and ipvs is disabled" into the original patch:

"ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1"

Very good, thanks!

Regards

--
Julian Anastasov <[email protected]>