Skip to contentSkip to conversation

remove include/config_defaults.h

PATCH New Rasmus Villemoes 2 participants 2 messages Jul 7, 2020 – Jul 17, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove include/config_defaults.h

Since commit 4b0bcfa7c4ec (Kconfig: Migrate CONFIG_BOOTM_* options), the config_defaults.h file has been void of any actual content - and these days, "sane defaults for everyone" is achieved by appropriate default values in Kconfig. Remove it, and thus make every translation unit process one less header file.

---
 include/config_defaults.h | 12 ------------
 include/configs/kc1.h     |  6 ------
 include/configs/sniper.h  |  6 ------
 scripts/Makefile.autoconf |  1 -
 4 files changed, 25 deletions(-)
 delete mode 100644 include/config_defaults.h
include/config_defaults.h deleted +0 -12
deleted file mode 100644
index d211a41ef2..0000000000
@@ -1,12 +0,0 @@
-/*
- * config_defaults.h - sane defaults for everyone
- *
- * Copyright (c) 2009 Analog Devices Inc.
- *
- * Licensed under the GPL-2 or later.
- */
-
-#ifndef _CONFIG_DEFAULTS_H_
-#define _CONFIG_DEFAULTS_H_
-
-#endif
include/configs/kc1.h +0 -6
index e3a219c46b..3f71739f83 100644
@@ -149,10 +149,4 @@
 	"mmc read ${kernel_addr_r} ${boot_mmc_start} ${boot_mmc_size} && " \
 	"bootm ${kernel_addr_r};"
 
-/*
- * Defaults
- */
-
-#include <config_defaults.h>
-
 #endif
include/configs/sniper.h +0 -6
index 0e2fcc3e23..5ea8efabfc 100644
@@ -142,10 +142,4 @@
 	"mmc read ${kernel_addr_r} ${boot_mmc_start} ${boot_mmc_size} && " \
 	"bootm ${kernel_addr_r};"
 
-/*
- * Defaults
- */
-
-#include <config_defaults.h>
-
 #endif
scripts/Makefile.autoconf +0 -1
index 00b8fb34aa..0bfc1b2a62 100644
@@ -104,7 +104,6 @@ define filechk_config_h
 		| sed '/=/ {s/=/	/;q; } ; { s/$$/	1/; }'; \
 	done;								\
 	echo \#define CONFIG_BOARDDIR board/$(if $(VENDOR),$(VENDOR)/)$(BOARD);\
-	echo \#include \<config_defaults.h\>;				\
 	echo \#include \<config_uncmd_spl.h\>;				\
 	echo \#include \<configs/$(CONFIG_SYS_CONFIG_NAME).h\>;		\
 	echo \#include \<asm/config.h\>;				\
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 remove include/config_defaults.h

Quoted 7 lines · Rasmus Villemoes

Since commit 4b0bcfa7c4ec (Kconfig: Migrate CONFIG_BOOTM_* options), the config_defaults.h file has been void of any actual content - and these days, "sane defaults for everyone" is achieved by appropriate default values in Kconfig. Remove it, and thus make every translation unit process one less header file.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200717/e24d9198/attachment.sig>