net: bnxt: don't complain if TC flower can't be supported
Jakub Kicinski
maintainerPATCH 1/1 net: bnxt: don't complain if TC flower can't be supported
The fact that NETIF_F_HW_TC is not set should be a sufficient indication to the user that TC offloads are not supported. No need to bother users of older firmware versions with pointless warnings on every boot.
Also, since the support is optional, bnxt_init_tc() should not return an error in case FW is old, similarly to how error is not returned when CONFIG_BNXT_FLOWER_OFFLOAD is not set.
With that we can add an error message to the caller, to warn about actual unexpected failures.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++++- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 7 ++----- 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +4 -1
@@ -12086,7 +12086,10 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto init_err_pci_clean; } } -bnxt_init_tc (bp); + rc =bnxt_init_tc (bp); +if (rc) +netdev_err (dev,"Failed to initialize TC flower offload, err = %d.\n" , + rc); }bnxt_dl_register (bp);
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c +2 -5
@@ -2000,11 +2000,8 @@ int bnxt_init_tc(struct bnxt *bp)struct bnxt_tc_info *tc_info;int rc; -if (bp->hwrm_spec_code <0x10803 ) { -netdev_warn (bp->dev, -"Firmware does not support TC flower offload.\n" ); -return -ENOTSUPP ; - } +if (bp->hwrm_spec_code <0x10803 ) +return 0 ; tc_info =kzalloc (sizeof (*tc_info),GFP_KERNEL );if (!tc_info)
Signature · 1 line
2.26.2
Quoted 6 lines · Jakub Kicinski
The fact that
NETIF_F_HW_TCis not set should be a sufficient indication to the user that TC offloads are not supported. No need to bother users of older firmware versions with pointless warnings on every boot.
Quoted 8 lines
Also, since the support is optional,
bnxt_init_tc()should not return an error in case FW is old, similarly to how error is not returned whenCONFIG_BNXT_FLOWER_OFFLOADis not set.With that we can add an error message to the caller, to warn about actual unexpected failures.
Signed-off-by Jakub Kicinski <[email protected]>
Thanks.
From: Jakub Kicinski <[email protected]>
Date: Fri, 17 Jul 2020 13:59:58 -0700
Quoted 5 lines
The fact that
NETIF_F_HW_TCis not set should be a sufficient indication to the user that TC offloads are not supported. No need to bother users of older firmware versions with pointless warnings on every boot.
Quoted 8 lines
Also, since the support is optional,
bnxt_init_tc()should not return an error in case FW is old, similarly to how error is not returned whenCONFIG_BNXT_FLOWER_OFFLOADis not set.With that we can add an error message to the caller, to warn about actual unexpected failures.
Signed-off-by Jakub Kicinski <[email protected]>
Applied, thank you.