Skip to contentSkip to conversation

ASoC: Intel: Skylake: Avoid the use of one-element array

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Jul 17, 2020 – Jul 20, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: Skylake: Avoid the use of one-element array

One-element arrays are being deprecated[1]. Replace the one-element array with a simple value type 'u8 reserved'[2], once it seems this is just a placeholder for alignment.

[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86

---
 sound/soc/intel/skylake/skl-topology.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/skylake/skl-topology.h +1 -1
index 9889f728752c..5e93ad85e06d 100644
@@ -97,7 +97,7 @@ struct skl_audio_data_format {
 	u8 number_of_channels;
 	u8 valid_bit_depth;
 	u8 sample_type;
-	u8 reserved[1];
+	u8 reserved;
 } __packed;
 
 struct skl_base_cfg {
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw

Looks ok and tests on our side also pass.

Quoted 28 lines · Gustavo A. R. Silva

One-element arrays are being deprecated[1]. Replace the one-element array with a simple value type 'u8 reserved'[2], once it seems this is just a placeholder for alignment.

[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86

---
  sound/soc/intel/skylake/skl-topology.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/skylake/skl-topology.h +1 -1
index 9889f728752c..5e93ad85e06d 100644
@@ -97,7 +97,7 @@ struct skl_audio_data_format {
  	u8 number_of_channels;
  	u8 valid_bit_depth;
  	u8 sample_type;
-	u8 reserved[1];
+	u8 reserved;
  } __packed;
 
  struct skl_base_cfg {
maintainer
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 6 lines · Gustavo A. R. Silva

One-element arrays are being deprecated[1]. Replace the one-element array with a simple value type 'u8 reserved'[2], once it seems this is just a placeholder for alignment.

[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: Skylake: Avoid the use of one-element array

      commit: 23f8d964f15a21991a166f0d1a7cf3cf8e4bfc9b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark