pwm: bcm-iproc: handle clk_get_rate() return
Subsystems (2)
PATCH v4 1/1 pwm: bcm-iproc: handle clk_get_rate() return
From: Rayagonda Kokatanur <[email protected]>
Handle clk_get_rate() returning 0 to avoid possible division by zero.
---
Changes from v3: fixed typo in commit message: Reviewed-off-by. Hopefully everything clean now.
Changes from v2: update commit message to remove <= condition as clk_get_rate only returns value >= 0
--- drivers/pwm/pwm-bcm-iproc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/pwm/pwm-bcm-iproc.c +7 -2
@@ -85,8 +85,6 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,u64 tmp, multi, rate;u32 value, prescale; - rate =clk_get_rate (ip->clk); - value =readl (ip->base +IPROC_PWM_CTRL_OFFSET );if (value &BIT (IPROC_PWM_CTRL_EN_SHIFT (pwm->hwpwm)))
@@ -99,6 +97,13 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,else state->polarity =PWM_POLARITY_INVERSED ; + rate =clk_get_rate (ip->clk); +if (rate ==0 ) { + state->period =0 ; + state->duty_cycle =0 ; +return ; + } + value =readl (ip->base +IPROC_PWM_PRESCALE_OFFSET ); prescale = value >>IPROC_PWM_PRESCALE_SHIFT (pwm->hwpwm); prescale &=IPROC_PWM_PRESCALE_MAX ;
Signature · 1 line
2.17.1
Hi Thierry/Uwe,
Do you have any further comment on this patch? If not, could you please help to pick it up?
Thanks,
Ray
Quoted 46 lines · Scott Branden
From: Rayagonda Kokatanur <[email protected]>
Handle
clk_get_rate()returning 0 to avoid possible division by zero.Fixes daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller")Signed-off-by Rayagonda Kokatanur <[email protected]>Signed-off-by Scott Branden <[email protected]>Reviewed-by Ray Jui <[email protected]>---
Changes from v3: fixed typo in commit message: Reviewed-off-by. Hopefully everything clean now.
Changes from v2: update commit message to remove <= condition asclk_get_rateonly returns value >= 0--- drivers/pwm/pwm-bcm-iproc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/pwm/pwm-bcm-iproc.c +7
-2@@ -85,8 +85,6 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,u64 tmp, multi, rate;u32 value, prescale; - rate =clk_get_rate (ip->clk); - value =readl (ip->base +IPROC_PWM_CTRL_OFFSET );if (value &BIT (IPROC_PWM_CTRL_EN_SHIFT (pwm->hwpwm)))@@ -99,6 +97,13 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,else state->polarity =PWM_POLARITY_INVERSED ; + rate =clk_get_rate (ip->clk); +if (rate ==0 ) { + state->period =0 ; + state->duty_cycle =0 ; +return ; + } + value =readl (ip->base +IPROC_PWM_PRESCALE_OFFSET ); prescale = value >>IPROC_PWM_PRESCALE_SHIFT (pwm->hwpwm); prescale &=IPROC_PWM_PRESCALE_MAX ;
Quoted 8 lines · Scott Branden
From: Rayagonda Kokatanur <[email protected]>
Handle
clk_get_rate()returning 0 to avoid possible division by zero.Fixes daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller")Signed-off-by Rayagonda Kokatanur <[email protected]>Signed-off-by Scott Branden <[email protected]>Reviewed-by Ray Jui <[email protected]>
LGTM
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Thierry Reding
AppliedQuoted 9 lines · Scott Branden
From: Rayagonda Kokatanur <[email protected]>
Handle
clk_get_rate()returning 0 to avoid possible division by zero.Fixes daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller")Signed-off-by Rayagonda Kokatanur <[email protected]>Signed-off-by Scott Branden <[email protected]>Reviewed-by Ray Jui <[email protected]>
Quoted 8 lines
---
Changes from v3: fixed typo in commit message: Reviewed-off-by. Hopefully everything clean now.
Changes from v2: update commit message to remove <= condition asclk_get_rateonly returns value >= 0--- drivers/pwm/pwm-bcm-iproc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry