Skip to contentSkip to conversation

pulseaudio: improve the Thumb frame pointer fix

PATCH New Tanu Kaskinen 1 participant 1 message Jul 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pulseaudio: improve the Thumb frame pointer fix

By changing the register that PulseAudio uses in its asm code makes it unnecessary to care whether frame pointers are enabled or not.

This fix was suggested by Andre McCurdy.

---

v2: Fixed the Upstream-Status line.

 .../pulseaudio/pulseaudio.inc                 |  8 ----
 ..._neon-use-register-r12-instead-of-r7.patch | 48 +++++++++++++++++++
 .../pulseaudio/pulseaudio_13.0.bb             |  1 +
 3 files changed, 49 insertions(+), 8 deletions(-)
 create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-remap_neon-use-register-r12-instead-of-r7.patch
meta/recipes-multimedia/pulseaudio/pulseaudio.inc +0 -8
index c7f3e67022..4e32b27087 100644
@@ -63,14 +63,6 @@ DEPENDS += "speexdsp libxml-parser-perl-native libcap"
 
 inherit autotools bash-completion pkgconfig useradd gettext perlnative systemd manpages gsettings
 
-# When compiling for Thumb or Thumb2, frame pointers _must_ be disabled since the
-# Thumb frame pointer in r7 clashes with pulseaudio's use of inline asm to make syscalls
-# (where r7 is used for the syscall NR). In most cases, frame pointers will be
-# disabled automatically due to the optimisation level, but append an explicit
-# -fomit-frame-pointer to handle cases where optimisation is set to -O0 or frame
-# pointers have been enabled by -fno-omit-frame-pointer earlier in CFLAGS, etc.
-CFLAGS_append_arm = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}"
-
 # *.desktop rules wont be generated during configure and build will fail
 # if using --disable-nls
 USE_NLS = "yes"
meta/recipes-multimedia/pulseaudio/pulseaudio/0001-remap_neon-use-register-r12-instead-of-r7.patch new file +48 -0

48 lines not on this page · raw message

meta/recipes-multimedia/pulseaudio/pulseaudio_13.0.bb +1 -0
index d2f201d06e..53e9a2357d 100644
@@ -4,6 +4,7 @@ SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \
            file://0001-client-conf-Add-allow-autospawn-for-root.patch \
            file://0002-do-not-display-CLFAGS-to-improve-reproducibility-bui.patch \
            file://0001-remap-arm-Adjust-inline-asm-constraints.patch \
+           file://0001-remap_neon-use-register-r12-instead-of-r7.patch \
            file://volatiles.04_pulse \
            "
 SRC_URI[md5sum] = "e41d606f90254ed45c90520faf83d95c"
Signature · 1 line
2.20.1