mt76: mt76u: add missing release on skb in __mt76x02u_mcu_send_msg
PATCH 1/1 mt76: mt76u: add missing release on skb in __mt76x02u_mcu_send_msg
In the implementation of __mt76x02u_mcu_send_msg() the skb is consumed all execution paths except one. Release skb before returning if test_bit() fails.
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c +5 -2
@@ -87,8 +87,10 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct sk_buff *skb,u32 info;int ret; -if (test_bit (MT76_REMOVED , &dev->phy.state)) -return 0 ; +if (test_bit (MT76_REMOVED , &dev->phy.state)) { + ret =0 ; + goto out; + }if (wait_resp) { seq = ++dev->mcu.msg_seq &0xf ;
@@ -111,6 +113,7 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct sk_buff *skb,if (wait_resp) ret =mt76x02u_mcu_wait_resp (dev, seq); +out:consume_skb (skb);return ret;
Signature · 1 line
2.17.1