net: dsa: felix: Make some symbols static
Subsystems (4)
PATCH 1/1 net: dsa: felix: Make some symbols static
Fix sparse build warning:
drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning:
symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static?drivers/net/dsa/ocelot/felix_vsc9959.c:640:19: warning:
symbol 'vsc9959_vcap_is2_actions' was not declared. Should it be static?
--- drivers/net/dsa/ocelot/felix_vsc9959.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/dsa/ocelot/felix_vsc9959.c +2 -2
@@ -557,7 +557,7 @@ static const struct ocelot_stat_layout vsc9959_stats_layout[] = { { .offset = 0x111, .name = "drop_green_prio_7", }, }; -struct vcap_field vsc9959_vcap_is2_keys[] = { +static struct vcap_field vsc9959_vcap_is2_keys[] = {/* Common: 41 bits */ [VCAP_IS2_TYPE ] = {0 ,4 }, [VCAP_IS2_HK_FIRST ] = {4 ,1 },
@@ -637,7 +637,7 @@ struct vcap_field vsc9959_vcap_is2_keys[] = { [VCAP_IS2_HK_OAM_IS_Y1731] = {182, 1}, }; -struct vcap_field vsc9959_vcap_is2_actions[] = { +static struct vcap_field vsc9959_vcap_is2_actions[] = { [VCAP_IS2_ACT_HIT_ME_ONCE ] = {0 ,1 }, [VCAP_IS2_ACT_CPU_COPY_ENA ] = {1 ,1 }, [VCAP_IS2_ACT_CPU_QU_NUM ] = {2 ,3 },
Signature · 1 line
2.17.1
Vladimir Oltean
maintainerQuoted 10 lines · Wang Hai
Fix sparse build warning:
drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning:
symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static?drivers/net/dsa/ocelot/felix_vsc9959.c:640:19: warning:
symbol 'vsc9959_vcap_is2_actions' was not declared. Should it be static?Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>---
Please update your tree.
commit 3ab4ceb6e9639e4e42d473e46ae7976c24187876
Author: Vladimir Oltean <[email protected]> Date: Sat Jun 20 18:43:36 2020 +0300
net: dsa: felix: make vcap is2 keys and actions static
Get rid of some sparse warnings.
Quoted 28 lines
drivers/net/dsa/ocelot/felix_vsc9959.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/dsa/ocelot/felix_vsc9959.c +2
-2@@ -557,7 +557,7 @@ static const struct ocelot_stat_layout vsc9959_stats_layout[] = { { .offset = 0x111, .name = "drop_green_prio_7", }, }; -struct vcap_field vsc9959_vcap_is2_keys[] = { +static struct vcap_field vsc9959_vcap_is2_keys[] = {/* Common: 41 bits */ [VCAP_IS2_TYPE ] = {0 ,4 }, [VCAP_IS2_HK_FIRST ] = {4 ,1 },@@ -637,7 +637,7 @@ struct vcap_field vsc9959_vcap_is2_keys[] = { [VCAP_IS2_HK_OAM_IS_Y1731] = {182, 1}, }; -struct vcap_field vsc9959_vcap_is2_actions[] = { +static struct vcap_field vsc9959_vcap_is2_actions[] = { [VCAP_IS2_ACT_HIT_ME_ONCE ] = {0 ,1 }, [VCAP_IS2_ACT_CPU_COPY_ENA ] = {1 ,1 }, [VCAP_IS2_ACT_CPU_QU_NUM ] = {2 ,3 },Signature · 1 line
2.17.1
Thanks,
-Vladimir
Thanks for reminding me, I'll do it.
Quoted 57 lines · Vladimir Oltean
Quoted 10 lines · Wang Hai
Fix sparse build warning:
drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning:
symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static?drivers/net/dsa/ocelot/felix_vsc9959.c:640:19: warning:
symbol 'vsc9959_vcap_is2_actions' was not declared. Should it be static?Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>---
Please update your tree.
commit
3ab4ceb6e9639e4e42d473e46ae7976c24187876Author: Vladimir Oltean <[email protected]> Date: Sat Jun 20 18:43:36 2020 +0300net: dsa: felix: make vcap is2 keys and actions static
Get rid of some sparse warnings.
Signed-off-by Vladimir Oltean <[email protected]>Signed-off-by David S. Miller <[email protected]>Quoted 28 lines
drivers/net/dsa/ocelot/felix_vsc9959.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/dsa/ocelot/felix_vsc9959.c +2
-2@@ -557,7 +557,7 @@ static const struct ocelot_stat_layout vsc9959_stats_layout[] = { { .offset = 0x111, .name = "drop_green_prio_7", }, }; -struct vcap_field vsc9959_vcap_is2_keys[] = { +static struct vcap_field vsc9959_vcap_is2_keys[] = {/* Common: 41 bits */ [VCAP_IS2_TYPE ] = {0 ,4 }, [VCAP_IS2_HK_FIRST ] = {4 ,1 },@@ -637,7 +637,7 @@ struct vcap_field vsc9959_vcap_is2_keys[] = { [VCAP_IS2_HK_OAM_IS_Y1731] = {182, 1}, }; -struct vcap_field vsc9959_vcap_is2_actions[] = { +static struct vcap_field vsc9959_vcap_is2_actions[] = { [VCAP_IS2_ACT_HIT_ME_ONCE ] = {0 ,1 }, [VCAP_IS2_ACT_CPU_COPY_ENA ] = {1 ,1 }, [VCAP_IS2_ACT_CPU_QU_NUM ] = {2 ,3 },Signature · 1 line
2.17.1Thanks,
-Vladimir.