Skip to contentSkip to conversation

treewide: replace nogroup with nobody

PATCH New Norbert Lange 2 participants 2 messages Jul 17, 2020 – Jul 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 treewide: replace nogroup with nobody

Use the recommended groupname for user nobody. One practical issue is that systemd-sysusers will otherwise create a nobody group with gid 999.

Quote: "If the username exists on a system,then they should be in the suggested corresponding group".

https://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/usernames.html

---
v2:
- Undo whitespace changes in boa.conf

---
 package/boa/boa.conf                 | 2 +-
 package/mosquitto/mosquitto.mk       | 2 +-
 package/oracle-mysql/oracle-mysql.mk | 2 +-
 package/systemd/systemd.mk           | 1 -
 system/skeleton/etc/group            | 2 +-
 5 files changed, 4 insertions(+), 5 deletions(-)
package/boa/boa.conf +1 -1
index e94029665f..f51c237316 100644
@@ -46,7 +46,7 @@ Port 80
 # Group: The group name or GID the server should run as.
 
 User nobody
-Group nogroup
+Group nobody
 
 # ServerAdmin: The email address where server problems should be sent.
 # Note: this is not currently used, except as an environment variable
package/mosquitto/mosquitto.mk +1 -1
index 2a9b504eb8..cdd515e1a4 100644
@@ -114,7 +114,7 @@ define MOSQUITTO_INSTALL_INIT_SYSTEMD
 endef
 
 define MOSQUITTO_USERS
-	mosquitto -1 nogroup -1 * - - - Mosquitto user
+	mosquitto -1 nobody -1 * - - - Mosquitto user
 endef
 endif
 
package/oracle-mysql/oracle-mysql.mk +1 -1
index 1449c58e41..ccfa40cfb1 100644
@@ -102,7 +102,7 @@ ORACLE_MYSQL_CONF_OPTS += --without-debug
 endif
 
 define ORACLE_MYSQL_USERS
-	mysql -1 nogroup -1 * /var/mysql - - MySQL daemon
+	mysql -1 nobody -1 * /var/mysql - - MySQL daemon
 endef
 
 define ORACLE_MYSQL_ADD_FOLDER
package/systemd/systemd.mk +0 -1
index 8e01a0db5b..e88b559dbb 100644
@@ -38,7 +38,6 @@ SYSTEMD_CONF_OPTS += \
 	-Dsulogin-path=/usr/sbin/sulogin \
 	-Dmount-path=/usr/bin/mount \
 	-Dumount-path=/usr/bin/umount \
-	-Dnobody-group=nogroup \
 	-Didn=true \
 	-Dnss-systemd=true
 
system/skeleton/etc/group +1 -1
index 76346b35f2..6822a277bf 100644
@@ -23,4 +23,4 @@ staff:x:50:
 lock:x:54:
 netdev:x:82:
 users:x:100:
-nogroup:x:65534:
+nobody:x:65534:
Signature · 1 line
2.27.0
#1 lore raw

PATCH v2 1/1 treewide: replace nogroup with nobody

Norbert, All,

On 2020-07-17 23:52 +0200, Norbert Lange spake thusly:

Quoted 10 lines

Use the recommended groupname for user nobody. One practical issue is that systemd-sysusers will otherwise create a nobody group with gid 999.

Quote: "If the username exists on a system,then they should be in the suggested corresponding group".

https://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/usernames.html

Applied to master, after expanding the commit log with more references. Thanks!

Regards,
Yann E. MORIN.

Quoted 75 lines

---
v2:

(quoted diff) +0 -2
-   Undo whitespace changes in boa.conf
---
 package/boa/boa.conf                 | 2 +-
 package/mosquitto/mosquitto.mk       | 2 +-
 package/oracle-mysql/oracle-mysql.mk | 2 +-
 package/systemd/systemd.mk           | 1 -
 system/skeleton/etc/group            | 2 +-
 5 files changed, 4 insertions(+), 5 deletions(-)
package/boa/boa.conf +1 -1
index e94029665f..f51c237316 100644
@@ -46,7 +46,7 @@ Port 80
 # Group: The group name or GID the server should run as.
 
 User nobody
-Group nogroup
+Group nobody
 
 # ServerAdmin: The email address where server problems should be sent.
 # Note: this is not currently used, except as an environment variable
package/mosquitto/mosquitto.mk +1 -1
index 2a9b504eb8..cdd515e1a4 100644
@@ -114,7 +114,7 @@ define MOSQUITTO_INSTALL_INIT_SYSTEMD
 endef
 
 define MOSQUITTO_USERS
-	mosquitto -1 nogroup -1 * - - - Mosquitto user
+	mosquitto -1 nobody -1 * - - - Mosquitto user
 endef
 endif
 
package/oracle-mysql/oracle-mysql.mk +1 -1
index 1449c58e41..ccfa40cfb1 100644
@@ -102,7 +102,7 @@ ORACLE_MYSQL_CONF_OPTS += --without-debug
 endif
 
 define ORACLE_MYSQL_USERS
-	mysql -1 nogroup -1 * /var/mysql - - MySQL daemon
+	mysql -1 nobody -1 * /var/mysql - - MySQL daemon
 endef
 
 define ORACLE_MYSQL_ADD_FOLDER
package/systemd/systemd.mk +0 -1
index 8e01a0db5b..e88b559dbb 100644
@@ -38,7 +38,6 @@ SYSTEMD_CONF_OPTS += \
 	-Dsulogin-path=/usr/sbin/sulogin \
 	-Dmount-path=/usr/bin/mount \
 	-Dumount-path=/usr/bin/umount \
-	-Dnobody-group=nogroup \
 	-Didn=true \
 	-Dnss-systemd=true
 
system/skeleton/etc/group +1 -1
index 76346b35f2..6822a277bf 100644
@@ -23,4 +23,4 @@ staff:x:50:
 lock:x:54:
 netdev:x:82:
 users:x:100:
-nogroup:x:65534:
+nobody:x:65534:
Signature · 1 line
2.27.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'