Allow privileged user to map the OA buffer
Subsystems (3)
cover Allow privileged user to map the OA buffer
This cover letter is included to trigger "Test-with" an IGT patch.
Tests - https://patchwork.freedesktop.org/patch/377905/?series=79617&rev=1
Test-with: [email protected]
Piotr Maciejewski (4):
drm/i915/perf: Ensure observation logic is not clock gated drm/i915/perf: Whitelist OA report trigger registers drm/i915/perf: Whitelist OA counter and buffer registers drm/i915/perf: Map OA buffer to user space for gen12 performance query
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 60 +++++++ .../gpu/drm/i915/gt/selftest_workarounds.c | 15 +- drivers/gpu/drm/i915/i915_perf.c | 167 +++++++++++++++++- drivers/gpu/drm/i915/i915_perf_types.h | 5 + drivers/gpu/drm/i915/i915_reg.h | 12 ++ include/uapi/drm/i915_drm.h | 32 ++++ 8 files changed, 290 insertions(+), 5 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/4 drm/i915/perf: Ensure observation logic is not clock gated
From: Piotr Maciejewski <[email protected]>
A clock gating switch can control if the performance monitoring and observation logic is enaled or not. Ensure that we enable the clocks.
v2: Separate code from other patches (Lionel)
--- drivers/gpu/drm/i915/i915_perf.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 10 insertions(+)
drivers/gpu/drm/i915/i915_perf.c +8 -0
@@ -2493,6 +2493,14 @@ gen12_enable_metric_set(struct i915_perf_stream *stream, (period_exponent << GEN12_OAG_OAGLBCTXCTRL_TIMER_PERIOD_SHIFT)) : 0); +/* +* Initialize Super Queue Internal Cnt Register +* Set PMON Enable in order to collect valid metrics. +*/ +intel_uncore_write (uncore,GEN12_SQCNT1 , +intel_uncore_read (uncore,GEN12_SQCNT1 ) | +GEN12_SQCNT1_PMON_ENABLE ); +/* * Update all contexts prior writing the mux configurations as we need * to make sure all slices/subslices are ON before writing to NOA
drivers/gpu/drm/i915/i915_reg.h +2 -0
@@ -696,6 +696,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define OABUFFER_SIZE_16M (7 << 3)#define GEN12_OA_TLB_INV_CR _MMIO(0xceec) +#define GEN12_SQCNT1 _MMIO(0x8718) +#define GEN12_SQCNT1_PMON_ENABLE (1 << 30)/* Gen12 OAR unit */ #define GEN12_OAR_OACONTROL _MMIO(0x2960)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/4] drm/i915/perf: Ensure observation logic is not clock gated
Quoted 20 lines · Umesh Nerlige Ramappa
From: Piotr Maciejewski <[email protected]>
A clock gating switch can control if the performance monitoring and observation logic is enaled or not. Ensure that we enable the clocks.
v2: Separate code from other patches (Lionel)
Fixes 00a7f0d7155c ("drm/i915/tgl: Add perf support on TGL")Signed-off-by Piotr Maciejewski <[email protected]>Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/i915_perf.c | 8 ++++++++ drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 10 insertions(+)drivers/gpu/drm/i915/i915_perf.c +0
-0
drivers/gpu/drm/i915/i915_perf.c gen12_enable_metric_set(struct i915_perf_stream *stream, · line 2502
Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +7
-0@@ -2493,6 +2493,14 @@ gen12_enable_metric_set(struct i915_perf_stream *stream, (period_exponent << GEN12_OAG_OAGLBCTXCTRL_TIMER_PERIOD_SHIFT)) : 0); +/* +* Initialize Super Queue Internal Cnt Register +* Set PMON Enable in order to collect valid metrics. +*/ +intel_uncore_write (uncore,GEN12_SQCNT1 , +intel_uncore_read (uncore,GEN12_SQCNT1 ) | +GEN12_SQCNT1_PMON_ENABLE );
Thanks for splitting this.
We just need to also disable this when i915-perf is disabled, documentation says it saved power when turned off.
-Lionel
Quoted 9 lines
drivers/gpu/drm/i915/i915_perf.c +1
-0+/* * Update all contexts prior writing the mux configurations as we need * to make sure all slices/subslices are ON before writing to NOA drivers/gpu/drm/i915/i915_reg.h +0
-0
drivers/gpu/drm/i915/i915_reg.h static inline bool i915_mmio_reg_valid(i915_reg_t reg) · line 703
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0@@ -696,6 +696,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define OABUFFER_SIZE_16M (7 << 3)#define GEN12_OA_TLB_INV_CR _MMIO(0xceec) +#define GEN12_SQCNT1 _MMIO(0x8718) +#define GEN12_SQCNT1_PMON_ENABLE (1 << 30)/* Gen12 OAR unit */ #define GEN12_OAR_OACONTROL _MMIO(0x2960)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/4 drm/i915/perf: Whitelist OA report trigger registers
In reply to Umesh Nerlige RamappaFrom: Piotr Maciejewski <[email protected]>
OA reports can be triggered into the OA buffer by writing into the OAREPORTTRIG registers. Whitelist the registers to allow user to trigger reports.
v2:
- Move related change to this patch (Lionel)
- Bump up perf revision (Lionel)
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 26 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_perf.c | 11 ++++++--- 2 files changed, 34 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +26 -0
@@ -1365,6 +1365,20 @@ whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)whitelist_reg_ext (wal, reg,RING_FORCE_TO_NONPRIV_ACCESS_RW ); } +static void gen9_whitelist_build_performance_counters (struct i915_wa_list *w) +{ +/* OA buffer trigger report 2/6 used by performance query */ +whitelist_reg (w,OAREPORTTRIG2 ); +whitelist_reg (w,OAREPORTTRIG6 ); +} + +static void gen12_whitelist_build_performance_counters (struct i915_wa_list *w) +{ +/* OA buffer trigger report 2/6 used by performance query */ +whitelist_reg (w,GEN12_OAG_OAREPORTTRIG2 ); +whitelist_reg (w,GEN12_OAG_OAREPORTTRIG6 ); +} +static void gen9_whitelist_build (struct i915_wa_list *w) {/* WaVFEStateAfterPipeControlwithMediaStateClear:skl,bxt,glk,cfl */
@@ -1378,6 +1392,9 @@ static void gen9_whitelist_build(struct i915_wa_list *w)/* WaSendPushConstantsFromMMIO:skl,bxt */ whitelist_reg (w,COMMON_SLICE_CHICKEN2 ); + +/* Performance counters support */ +gen9_whitelist_build_performance_counters (w); }static void skl_whitelist_build (struct intel_engine_cs *engine)
@@ -1471,6 +1488,9 @@ static void cnl_whitelist_build(struct intel_engine_cs *engine)/* WaEnablePreemptionGranularityControlByUMD:cnl */ whitelist_reg (w,GEN8_CS_CHICKEN1 ); + +/* Performance counters support */ +gen9_whitelist_build_performance_counters (w); }static void icl_whitelist_build (struct intel_engine_cs *engine)
@@ -1500,6 +1520,9 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)whitelist_reg_ext (w,PS_INVOCATION_COUNT ,RING_FORCE_TO_NONPRIV_ACCESS_RD |RING_FORCE_TO_NONPRIV_RANGE_4 ); + +/* Performance counters support */ +gen9_whitelist_build_performance_counters (w);break ;case VIDEO_DECODE_CLASS :
@@ -1550,6 +1573,9 @@ static void tgl_whitelist_build(struct intel_engine_cs *engine)/* Wa_1806527549:tgl */ whitelist_reg (w,HIZ_CHICKEN ); + +/* Performance counters support */ +gen12_whitelist_build_performance_counters (w);break ;default : whitelist_reg_ext(w,
drivers/gpu/drm/i915/i915_perf.c +8 -3
@@ -1448,7 +1448,8 @@ static void gen8_init_oa_buffer(struct i915_perf_stream *stream)* bit." */ intel_uncore_write (uncore,GEN8_OABUFFER , gtt_offset | -OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT ); +OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT | +GEN7_OABUFFER_EDGE_TRIGGER );intel_uncore_write (uncore,GEN8_OATAILPTR , gtt_offset &GEN8_OATAILPTR_MASK );/* Mark that we need updated tail pointers to read from... */
@@ -1501,7 +1502,8 @@ static void gen12_init_oa_buffer(struct i915_perf_stream *stream)* bit." */ intel_uncore_write (uncore,GEN12_OAG_OABUFFER , gtt_offset | -OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT ); +OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT | +GEN7_OABUFFER_EDGE_TRIGGER );intel_uncore_write (uncore,GEN12_OAG_OATAILPTR , gtt_offset &GEN12_OAG_OATAILPTR_MASK );
@@ -4440,8 +4442,11 @@ int i915_perf_ioctl_version(void)* * 5: Add DRM_I915_PERF_PROP_POLL_OA_PERIOD parameter that controls the * interval for the hrtimer used to check for OA data. +* +* 6: Whitelist OATRIGGER registers to allow user to trigger reports +* into the OA buffer. */ -return 5 ; +return 6 ; }#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/4] drm/i915/perf: Whitelist OA report trigger registers
Quoted 107 lines · Umesh Nerlige Ramappa
From: Piotr Maciejewski <[email protected]>
OA reports can be triggered into the OA buffer by writing into the OAREPORTTRIG registers. Whitelist the registers to allow user to trigger reports.
v2:
- Move related change to this patch (Lionel)
- Bump up perf revision (Lionel)Signed-off-by Piotr Maciejewski <[email protected]>Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 26 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_perf.c | 11 ++++++--- 2 files changed, 34 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/gt/intel_workarounds.c +26
-0@@ -1365,6 +1365,20 @@ whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)whitelist_reg_ext (wal, reg,RING_FORCE_TO_NONPRIV_ACCESS_RW ); } +static void gen9_whitelist_build_performance_counters (struct i915_wa_list *w) +{ +/* OA buffer trigger report 2/6 used by performance query */ +whitelist_reg (w,OAREPORTTRIG2 ); +whitelist_reg (w,OAREPORTTRIG6 ); +} + +static void gen12_whitelist_build_performance_counters (struct i915_wa_list *w) +{ +/* OA buffer trigger report 2/6 used by performance query */ +whitelist_reg (w,GEN12_OAG_OAREPORTTRIG2 ); +whitelist_reg (w,GEN12_OAG_OAREPORTTRIG6 ); +} +static void gen9_whitelist_build (struct i915_wa_list *w) {/* WaVFEStateAfterPipeControlwithMediaStateClear:skl,bxt,glk,cfl */ @@ -1378,6 +1392,9 @@ static void gen9_whitelist_build(struct i915_wa_list *w)/* WaSendPushConstantsFromMMIO:skl,bxt */ whitelist_reg (w,COMMON_SLICE_CHICKEN2 ); + +/* Performance counters support */ +gen9_whitelist_build_performance_counters (w); }static void skl_whitelist_build (struct intel_engine_cs *engine)@@ -1471,6 +1488,9 @@ static void cnl_whitelist_build(struct intel_engine_cs *engine)/* WaEnablePreemptionGranularityControlByUMD:cnl */ whitelist_reg (w,GEN8_CS_CHICKEN1 ); + +/* Performance counters support */ +gen9_whitelist_build_performance_counters (w); }static void icl_whitelist_build (struct intel_engine_cs *engine)@@ -1500,6 +1520,9 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)whitelist_reg_ext (w,PS_INVOCATION_COUNT ,RING_FORCE_TO_NONPRIV_ACCESS_RD |RING_FORCE_TO_NONPRIV_RANGE_4 ); + +/* Performance counters support */ +gen9_whitelist_build_performance_counters (w);break ;case VIDEO_DECODE_CLASS :@@ -1550,6 +1573,9 @@ static void tgl_whitelist_build(struct intel_engine_cs *engine)/* Wa_1806527549:tgl */ whitelist_reg (w,HIZ_CHICKEN ); + +/* Performance counters support */ +gen12_whitelist_build_performance_counters (w);break ;default : whitelist_reg_ext(w,drivers/gpu/drm/i915/i915_perf.c +4
-2@@ -1448,7 +1448,8 @@ static void gen8_init_oa_buffer(struct i915_perf_stream *stream)* bit." */ intel_uncore_write (uncore,GEN8_OABUFFER , gtt_offset | -OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT ); +OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT | +GEN7_OABUFFER_EDGE_TRIGGER );intel_uncore_write (uncore,GEN8_OATAILPTR , gtt_offset &GEN8_OATAILPTR_MASK );/* Mark that we need updated tail pointers to read from... */ @@ -1501,7 +1502,8 @@ static void gen12_init_oa_buffer(struct i915_perf_stream *stream)* bit." */ intel_uncore_write (uncore,GEN12_OAG_OABUFFER , gtt_offset | -OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT ); +OABUFFER_SIZE_16M |GEN8_OABUFFER_MEM_SELECT_GGTT | +GEN7_OABUFFER_EDGE_TRIGGER );intel_uncore_write (uncore,GEN12_OAG_OATAILPTR , gtt_offset &GEN12_OAG_OATAILPTR_MASK );
drivers/gpu/drm/i915/i915_perf.c int i915_perf_ioctl_version(void) · line 4447
Quoted 6 lines
drivers/gpu/drm/i915/i915_perf.c +3
-0@@ -4440,8 +4442,11 @@ int i915_perf_ioctl_version(void)* * 5: Add DRM_I915_PERF_PROP_POLL_OA_PERIOD parameter that controls the * interval for the hrtimer used to check for OA data. +* +* 6: Whitelist OATRIGGER registers to allow user to trigger reports +* into the OA buffer.
If you could just add a comment this only applies to gen8+.
Thanks!
drivers/gpu/drm/i915/i915_perf.c int i915_perf_ioctl_version(void) · line 4452
Quoted 6 lines
drivers/gpu/drm/i915/i915_perf.c +1
-1*/ -return 5 ; +return 6 ; }#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/4 drm/i915/perf: Whitelist OA counter and buffer registers
In reply to Umesh Nerlige RamappaFrom: Piotr Maciejewski <[email protected]>
It is useful to have markers in the OA reports to identify triggered reports. Whitelist some OA counters that can be used as markers.
A triggered report can be found faster if we can sample the HW tail and head registers when the report was triggered. Whitelist OA buffer specific registers.
v2:
- Bump up the perf revision (Lionel)
- Use indexing for counters (Lionel)
- Fix selftest for oa ticking register (Umesh)
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 34 +++++++++++++++++++ .../gpu/drm/i915/gt/selftest_workarounds.c | 15 +++++++- drivers/gpu/drm/i915/i915_perf.c | 5 ++- drivers/gpu/drm/i915/i915_reg.h | 10 ++++++ 4 files changed, 62 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +34 -0
@@ -1370,6 +1370,23 @@ static void gen9_whitelist_build_performance_counters(struct i915_wa_list *w)/* OA buffer trigger report 2/6 used by performance query */ whitelist_reg (w,OAREPORTTRIG2 );whitelist_reg (w,OAREPORTTRIG6 ); + +/* Performance counters A18-20 used by tbs marker query */ +whitelist_reg_ext (w,OA_PERF_COUNTER_A (18 ), +RING_FORCE_TO_NONPRIV_ACCESS_RW | +RING_FORCE_TO_NONPRIV_RANGE_4 ); + +whitelist_reg (w,OA_PERF_COUNTER_A (20 )); +whitelist_reg (w,OA_PERF_COUNTER_A_UPPER (20 )); + +/* Read access to gpu ticks */ +whitelist_reg_ext (w,GEN8_GPU_TICKS , +RING_FORCE_TO_NONPRIV_ACCESS_RD ); + +/* Read access to: oa status, head, tail, buffer settings */ +whitelist_reg_ext (w,GEN8_OASTATUS , +RING_FORCE_TO_NONPRIV_ACCESS_RD | +RING_FORCE_TO_NONPRIV_RANGE_4 ); }static void gen12_whitelist_build_performance_counters (struct i915_wa_list *w)
@@ -1377,6 +1394,23 @@ static void gen12_whitelist_build_performance_counters(struct i915_wa_list *w)/* OA buffer trigger report 2/6 used by performance query */ whitelist_reg (w,GEN12_OAG_OAREPORTTRIG2 );whitelist_reg (w,GEN12_OAG_OAREPORTTRIG6 ); + +/* Performance counters A18-20 used by tbs marker query */ +whitelist_reg_ext (w,GEN12_OAG_PERF_COUNTER_A (18 ), +RING_FORCE_TO_NONPRIV_ACCESS_RW | +RING_FORCE_TO_NONPRIV_RANGE_4 ); + +whitelist_reg (w,GEN12_OAG_PERF_COUNTER_A (20 )); +whitelist_reg (w,GEN12_OAG_PERF_COUNTER_A_UPPER (20 )); + +/* Read access to gpu ticks */ +whitelist_reg_ext (w,GEN12_OAG_GPU_TICKS , +RING_FORCE_TO_NONPRIV_ACCESS_RD ); + +/* Read access to: oa status, head, tail, buffer settings */ +whitelist_reg_ext (w,GEN12_OAG_OASTATUS , +RING_FORCE_TO_NONPRIV_ACCESS_RD | +RING_FORCE_TO_NONPRIV_RANGE_4 ); }static void gen9_whitelist_build (struct i915_wa_list *w)
drivers/gpu/drm/i915/gt/selftest_workarounds.c +14 -1
@@ -431,6 +431,19 @@ static bool timestamp(const struct intel_engine_cs *engine, u32 reg) } } +static bool oa_gpu_ticks (u32 reg) +{ + reg = reg & ~RING_FORCE_TO_NONPRIV_ACCESS_MASK ; +switch (reg) { +case 0x2910 : +case 0xda90 : +return true; + +default : +return false; + } +} +static bool ro_register (u32 reg) { if ((reg & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
@@ -511,7 +524,7 @@ static int check_dirty_whitelist(struct intel_context *ce)if (wo_register (engine, reg))continue ; -if (timestamp (engine, reg)) +if (timestamp (engine, reg) ||oa_gpu_ticks (reg))continue ;/* timestamps are expected to autoincrement */ ro_reg =ro_register (reg);
drivers/gpu/drm/i915/i915_perf.c +4 -1
@@ -4445,8 +4445,11 @@ int i915_perf_ioctl_version(void)* * 6: Whitelist OATRIGGER registers to allow user to trigger reports * into the OA buffer. +* +* 7: Whitelist OA buffer head/tail registers for user to identify the +* location of triggered reports into the OA buffer. */ -return 6 ; +return 7 ; }#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )
drivers/gpu/drm/i915/i915_reg.h +10 -0
@@ -675,6 +675,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define GEN7_OASTATUS2_HEAD_MASK 0xffffffc0#define GEN7_OASTATUS2_MEM_SELECT_GGTT (1 << 0)/* 0: PPGTT, 1: GGTT */ +#define GEN8_GPU_TICKS _MMIO(0x2910)#define GEN8_OASTATUS _MMIO(0x2b08)#define GEN8_OASTATUS_OVERRUN_STATUS (1 << 3)#define GEN8_OASTATUS_COUNTER_OVERFLOW (1 << 2)
@@ -733,6 +734,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define GEN12_OAG_OA_DEBUG_DISABLE_GO_1_0_REPORTS (1 << 2)#define GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS (1 << 1) +#define GEN12_OAG_GPU_TICKS _MMIO(0xda90)#define GEN12_OAG_OASTATUS _MMIO(0xdafc)#define GEN12_OAG_OASTATUS_COUNTER_OVERFLOW (1 << 2)#define GEN12_OAG_OASTATUS_BUFFER_OVERFLOW (1 << 1)
@@ -974,6 +976,14 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define OAREPORTTRIG8_NOA_SELECT_6_SHIFT 24#define OAREPORTTRIG8_NOA_SELECT_7_SHIFT 28 +/* Performance counters registers */ +#define OA_PERF_COUNTER_A (idx) _MMIO(0x2800 + 8 * (idx)) +#define OA_PERF_COUNTER_A_UPPER (idx) _MMIO(0x2800 + 8 * (idx) + 4) + +/* Gen12 Performance counters registers */ +#define GEN12_OAG_PERF_COUNTER_A (idx) _MMIO(0xD980 + 8 * (idx)) +#define GEN12_OAG_PERF_COUNTER_A_UPPER (idx) _MMIO(0xD980 + 8 * (idx) + 4) +/* Same layout as OASTARTTRIGX */ #define GEN12_OAG_OASTARTTRIG1 _MMIO(0xd900)#define GEN12_OAG_OASTARTTRIG2 _MMIO(0xd904)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/4 drm/i915/perf: Map OA buffer to user space for gen12 performance query
In reply to Umesh Nerlige RamappaFrom: Piotr Maciejewski <[email protected]>
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on triggered reports within oa buffer.
Triggering reports into the OA buffer is achieved by writing into a a trigger register. Optionally an unused counter/register is set with a marker value such that a triggered report can be identified in the OA buffer. Reports are usually triggered at the start and end of work that is measured.
Since OA buffer is large and queries can be frequent, an efficient way to look for triggered reports is required. By knowing the current head and tail offsets into the OA buffer, it is easier to determine the locality of the reports of interest.
Current perf OA interface does not expose head/tail information to the user and it filters out invalid reports before sending data to user. Also considering limited size of user buffer used during a query, creating a 1:1 copy of the OA buffer at the user space added undesired complexity.
The solution was to map the OA buffer to user space provided
(1) that it is accessed from a privileged user.
(2) OA report filtering is not used.
These 2 conditions would satisfy the safety criteria that the current perf interface addresses.
To enable the query:
- Add an ioctl to expose head and tail to the user
- Add an ioctl to return size and offset of the OA buffer
- Map the OA buffer to the user space
v2:
- Improve commit message (Chris)
- Do not mmap based on gem object filp. Instead, use perf_fd and support mmap syscall (Chris)
- Pass non-zero offset in mmap to enforce the right object is mapped (Chris)
- Do not expose gpu_address (Chris)
- Verify start and length of vma for page alignment (Lionel)
- Move SQNTL config out (Lionel)
--- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + drivers/gpu/drm/i915/i915_perf.c | 147 ++++++++++++++++++++++- drivers/gpu/drm/i915/i915_perf_types.h | 5 + include/uapi/drm/i915_drm.h | 32 +++++ 5 files changed, 186 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +1 -1
@@ -204,7 +204,7 @@ compute_partial_view(const struct drm_i915_gem_object *obj,return view; } -static vm_fault_t i915_error_to_vmf_fault (int err) +vm_fault_t i915_error_to_vmf_fault (int err) {switch (err) {default :
drivers/gpu/drm/i915/gem/i915_gem_mman.h +2 -0
@@ -29,4 +29,6 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);void i915_gem_object_release_mmap_offset (struct drm_i915_gem_object *obj); +vm_fault_t i915_error_to_vmf_fault (int err); +#endif
drivers/gpu/drm/i915/i915_perf.c +146 -1
218 lines not on this page · raw message
drivers/gpu/drm/i915/i915_perf_types.h +5 -0
@@ -377,6 +377,11 @@ struct i915_oa_ops {* generations. */ u32 (*oa_hw_tail_read)(struct i915_perf_stream *stream); + +/** +* @oa_hw_head_read: read the OA head pointer register +*/ +u32 (*oa_hw_head_read)(struct i915_perf_stream *stream); };struct i915_perf {
include/uapi/drm/i915_drm.h +32 -0
@@ -2048,6 +2048,38 @@ struct drm_i915_perf_open_param {*/ #define I915_PERF_IOCTL_CONFIG _IO('i', 0x2) +/** +* Returns OA buffer properties to be used with mmap. +* +* This ioctl is available in perf revision 8. +*/ +#define I915_PERF_IOCTL_GET_OA_BUFFER_INFO _IO('i', 0x3) + +/** +* OA buffer size and offset. +*/ +struct drm_i915_perf_oa_buffer_info { +__u32 size; +__u32 offset; +__u64 reserved[4 ]; +}; + +/** +* Returns current position of OA buffer head and tail. +* +* This ioctl is available in perf revision 8. +*/ +#define I915_PERF_IOCTL_GET_OA_BUFFER_HEAD_TAIL _IO('i', 0x4) + +/** +* OA buffer head and tail. +*/ +struct drm_i915_perf_oa_buffer_head_tail { +__u32 head; +__u32 tail; +__u64 reserved[4 ]; +}; +/** * Common to all i915 perf records */
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kernel test robot
build botRe: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query
Thank you for the patch! Perhaps something to improve:
Hi Umesh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip next-20200717] [cannot apply to linus/master v5.8-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Umesh-Nerlige-Ramappa/Allow-privileged-user-to-map-the-OA-buffer/20200718-080929 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-s002-20200717 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-49-g707c5017-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/i915_perf.c:3426:5: sparse: sparse: symbol 'i915_perf_mmap' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build bot[Intel-gfx] [RFC PATCH] drm/i915/perf: i915_perf_mmap() can be static
In reply to Umesh Nerlige RamappaSigned-off-by: kernel test robot <[email protected]>
--- i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_perf.c +1 -1
@@ -3423,7 +3423,7 @@ static const struct vm_operations_struct vm_ops_oa = { .fault = vm_fault_oa, }; -int i915_perf_mmap (struct file *file,struct vm_area_struct *vma) +static int i915_perf_mmap (struct file *file,struct vm_area_struct *vma) {struct i915_perf_stream *stream = file->private_data;int len;
Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query
In reply to Umesh Nerlige RamappaQuoting Umesh Nerlige Ramappa (2020-07-18 01:04:37)
Quoted 6 lines
drivers/gpu/drm/i915/i915_perf.c +6
-0+static vm_fault_t vm_fault_oa (struct vm_fault *vmf) +{ +struct vm_area_struct *vma = vmf->vma; +struct i915_perf_stream *stream = vma->vm_private_data; +struct drm_i915_gem_object *obj = stream->oa_buffer.vma->obj; +int err;
drivers/gpu/drm/i915/i915_perf.c static int i915_perf_release(struct inode *inode, struct file *file) · line 3416
Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +10
-0+ + err =i915_gem_object_pin_pages (obj); +if (err) + goto out; + + err =remap_io_sg (vma, + vma->vm_start, vma->vm_end - vma->vm_start, + obj->mm.pages->sgl,-1 ); + +i915_gem_object_unpin_pages (obj);
Ok, basics look good (will handle any vma for which we have valid DMA addresses, and since we control the construction of the vma we know we can limit it to objects that work via CPU PTE). There is just one small catch we have to be wary off -- the CPU pte are not holding a reference to the pages themselves, and so we need to refault if we have to evict.
However! The oa_buffer is perma-pinned so the pages cannot just disappear, but the mmap itself may outlive the perf-fd. So we need some way to determine that the vm_fault_oa() is called on an old stream (e..g if (stream->closed) return VM_FAULT_SIGBUS;), and during stream close to call unmap_mmaping_range(perf_file->f_mapping, 0, -1);
Since the mmap may live longer than expected, the vm_ops should on open() take a reference to the stream, and on close() release that reference.
Now would be a good time to mmap and close the perf-fd in an igt and verify the mmap is no longer accessible after the close. (To add complications, you can fork after opening the mmap(perf-fd).)
Quoted 8 lines
drivers/gpu/drm/i915/i915_perf.c +8
-0+out: +return i915_error_to_vmf_fault (err); +} + +static const struct vm_operations_struct vm_ops_oa = { + .fault = vm_fault_oa, +}; +
drivers/gpu/drm/i915/i915_perf.c static int i915_perf_release(struct inode *inode, struct file *file) · line 3435
Quoted 10 lines
drivers/gpu/drm/i915/i915_perf.c +10
-0+int i915_perf_mmap (struct file *file,struct vm_area_struct *vma) +{ +struct i915_perf_stream *stream = file->private_data; +int len; + +if (!IS_ALIGNED (vma->vm_start,PAGE_SIZE )) +return -EINVAL ; + +if (vma->vm_end < vma->vm_start) +return -EINVAL ;
These strike me as being redundant.
drivers/gpu/drm/i915/i915_perf.c static int i915_perf_release(struct inode *inode, struct file *file) · line 3445
Quoted 9 lines
drivers/gpu/drm/i915/i915_perf.c +9
-0+ len = vma->vm_end - vma->vm_start; +if (!IS_ALIGNED (len,PAGE_SIZE ) || len >OA_BUFFER_SIZE ) +return -EINVAL ; + +if (vma->vm_flags &VM_WRITE ) +return -EINVAL ; + +if (vma->vm_pgoff !=I915_PERF_OA_BUFFER_MMAP_OFFSET ) +return -EINVAL ;
I'd throw this is into a switch and do it earlier, so the len and writable checks can be based on the oa_vma. (Having a switch makes it clearer that this doesn't have to be a one-off.)
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Allow privileged user to map the OA buffer (rev2)
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: Allow privileged user to map the OA buffer (rev2)
URL : https://patchwork.freedesktop.org/series/79460/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 24740597e5f9 drm/i915/perf: Ensure observation logic is not clock gated 216ee54f6578 drm/i915/perf: Whitelist OA report trigger registers 829409416d4b drm/i915/perf: Whitelist OA counter and buffer registers dac9a1608e77 drm/i915/perf: Map OA buffer to user space for gen12 performance query -:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #47: - Pass non-zero offset in mmap to enforce the right object is mapped (Chris)
total: 0 errors, 1 warnings, 0 checks, 281 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Allow privileged user to map the OA buffer (rev2)
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: Allow privileged user to map the OA buffer (rev2)
URL : https://patchwork.freedesktop.org/series/79460/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for Allow privileged user to map the OA buffer (rev2)
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: Allow privileged user to map the OA buffer (rev2)
URL : https://patchwork.freedesktop.org/series/79460/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8761 -> Patchwork_18209
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18209 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18209, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18209:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@workarounds:
- fi-tgl-u2: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-u2/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-u2/igt@i915_selftest@[email protected]
- fi-skl-6700k2: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-skl-6700k2/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-skl-6700k2/igt@i915_selftest@[email protected]
- fi-cml-s: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-cml-s/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-cml-s/igt@i915_selftest@[email protected]
- fi-icl-y: [PASS][7] -> [DMESG-FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-icl-y/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-icl-y/igt@i915_selftest@[email protected]
- fi-kbl-x1275: [PASS][9] -> [DMESG-FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-x1275/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-x1275/igt@i915_selftest@[email protected]
- fi-cfl-guc: [PASS][11] -> [DMESG-FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-cfl-guc/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-cfl-guc/igt@i915_selftest@[email protected]
- fi-tgl-y: [PASS][13] -> [DMESG-FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-y/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-y/igt@i915_selftest@[email protected]
- fi-skl-guc: [PASS][15] -> [DMESG-FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-skl-guc/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-skl-guc/igt@i915_selftest@[email protected]
- fi-skl-6600u: [PASS][17] -> [DMESG-FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-skl-6600u/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-skl-6600u/igt@i915_selftest@[email protected]
- fi-kbl-8809g: [PASS][19] -> [DMESG-FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-8809g/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-8809g/igt@i915_selftest@[email protected]
- fi-cfl-8700k: [PASS][21] -> [DMESG-FAIL][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-cfl-8700k/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-cfl-8700k/igt@i915_selftest@[email protected]
- fi-kbl-r: [PASS][23] -> [DMESG-FAIL][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-r/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-r/igt@i915_selftest@[email protected]
- fi-icl-u2: [PASS][25] -> [DMESG-FAIL][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-icl-u2/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-icl-u2/igt@i915_selftest@[email protected]
- fi-cfl-8109u: [PASS][27] -> [DMESG-FAIL][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-cfl-8109u/igt@i915_selftest@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-cfl-8109u/igt@i915_selftest@[email protected]
- fi-skl-lmem: [PASS][29] -> [DMESG-FAIL][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-skl-lmem/igt@i915_selftest@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-skl-lmem/igt@i915_selftest@[email protected]
- fi-kbl-7500u: [PASS][31] -> [DMESG-FAIL][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-7500u/igt@i915_selftest@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-7500u/igt@i915_selftest@[email protected]
- fi-kbl-guc: [PASS][33] -> [DMESG-FAIL][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-guc/igt@i915_selftest@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-guc/igt@i915_selftest@[email protected]
- fi-kbl-soraka: [PASS][35] -> [DMESG-FAIL][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-soraka/igt@i915_selftest@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-soraka/igt@i915_selftest@[email protected]
- fi-cml-u2: [PASS][37] -> [DMESG-FAIL][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-cml-u2/igt@i915_selftest@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-cml-u2/igt@i915_selftest@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@workarounds:
- {fi-tgl-dsi}: [PASS][39] -> [DMESG-FAIL][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-dsi/igt@i915_selftest@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-dsi/igt@i915_selftest@[email protected]
- {fi-ehl-1}: [PASS][41] -> [DMESG-FAIL][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-ehl-1/igt@i915_selftest@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-ehl-1/igt@i915_selftest@[email protected]
- {fi-kbl-7560u}: [PASS][43] -> [DMESG-FAIL][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-7560u/igt@i915_selftest@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-7560u/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18209 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [PASS][45] -> [DMESG-WARN][46] ([i915#402])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-y/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-y/igt@[email protected]
* igt@i915_module_load@reload:
- fi-tgl-u2: [PASS][47] -> [DMESG-WARN][48] ([i915#402])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-u2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-u2/igt@[email protected]
- fi-bsw-n3050: [PASS][49] -> [DMESG-WARN][50] ([i915#1982])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-bsw-n3050/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-bsw-n3050/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- fi-tgl-u2: [PASS][51] -> [INCOMPLETE][52] ([i915#2045])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@workarounds:
- fi-apl-guc: [PASS][53] -> [DMESG-FAIL][54] ([i915#1635])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-apl-guc/igt@i915_selftest@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-apl-guc/igt@i915_selftest@[email protected]
- fi-bxt-dsi: [PASS][55] -> [DMESG-FAIL][56] ([i915#1635])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-bxt-dsi/igt@i915_selftest@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-bxt-dsi/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@flip:
- fi-tgl-y: [PASS][57] -> [DMESG-WARN][58] ([i915#1982])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-y/igt@kms_busy@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-y/igt@kms_busy@[email protected]
#### Possible fixes ####
* igt@gem_render_linear_blits@basic:
- fi-tgl-y: [DMESG-WARN][59] ([i915#402]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-y/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-y/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-bsw-kefka/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-bsw-kefka/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [FAIL][63] ([i915#138]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-guc/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-guc/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-cfl-8700k: [INCOMPLETE][65] ([i915#2089]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-cfl-8700k/igt@i915_selftest@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-cfl-8700k/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-icl-u2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-icl-u2/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [DMESG-WARN][69] ([i915#402]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-tgl-u2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-tgl-u2/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][71] ([i915#62] / [i915#92]) -> [DMESG-WARN][72] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-x1275/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][73] ([i915#62] / [i915#92]) -> [DMESG-WARN][74] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-x1275/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][75] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][76] ([i915#62] / [i915#92]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8761/fi-kbl-x1275/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#138]: https://gitlab.freedesktop.org/drm/intel/issues/138
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2045]: https://gitlab.freedesktop.org/drm/intel/issues/2045
[i915#2089]: https://gitlab.freedesktop.org/drm/intel/issues/2089
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (47 -> 40)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5739 -> IGTPW_4776
* Linux: CI_DRM_8761 -> Patchwork_18209
CI-20190529: 20190529
CI_DRM_8761: b665aabc40b8c7e86f10a74171d3d3fd71251781 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4776: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4776/index.html
IGT_5739: 9b964d7359db9799f2b5b905403dda668ae28c87 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18209: dac9a1608e77996c41690a5972dfc0b8122130e1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dac9a1608e77 drm/i915/perf: Map OA buffer to user space for gen12 performance query 829409416d4b drm/i915/perf: Whitelist OA counter and buffer registers 216ee54f6578 drm/i915/perf: Whitelist OA report trigger registers 24740597e5f9 drm/i915/perf: Ensure observation logic is not clock gated
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18209/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx