package/systemd: make a couple dependencies optional
PATCH v2 1/1 package/systemd: make a couple dependencies optional
Remove BR2_PACKAGE_UTIL_LINUX_BINARIES, as none
of the tools is necessary.
Remove BR2_PACKAGE_UTIL_LINUX_LIBBLKID, as this is optional. Aslong as MOUNT or FSCK are enabled, it will end up enabled anyway, but this seems more clear and correct.
Remove BR2_PACKAGE_UTIL_LINUX_NOLOGIN, if this option is not enabled then fall back to using /bin/false instead.
For importd, remove BR2_PACKAGE_BZIP2 and BR2_PACKAGE_LZ4, those arent dependencies.
---v1->v2:
- undo a copy-paste mistake in the repart section
- Drop some dependencies for importd aswell
--- package/systemd/Config.in | 5 ----- package/systemd/systemd.mk | 13 ++++++++++++- 2 files changed, 12 insertions(+), 6 deletions(-)
package/systemd/Config.in +0 -5
@@ -28,12 +28,9 @@ menuconfig BR2_PACKAGE_SYSTEMD select BR2_PACKAGE_DBUS # runtime dependency only select BR2_PACKAGE_LIBCAP select BR2_PACKAGE_UTIL_LINUX - select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT - select BR2_PACKAGE_UTIL_LINUX_BINARIES select BR2_PACKAGE_UTIL_LINUX_AGETTY select BR2_PACKAGE_UTIL_LINUX_MOUNT - select BR2_PACKAGE_UTIL_LINUX_NOLOGIN select BR2_PACKAGE_UTIL_LINUX_FSCK select BR2_PACKAGE_KMOD select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools
@@ -240,8 +237,6 @@ config BR2_PACKAGE_SYSTEMD_IMPORTD depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBGCRYPT - select BR2_PACKAGE_BZIP2 - select BR2_PACKAGE_LZ4 select BR2_PACKAGE_XZ select BR2_PACKAGE_ZLIB help
package/systemd/systemd.mk +12 -1
@@ -25,7 +25,6 @@ SYSTEMD_CONF_OPTS += \ -Dsysvinit-path= \ -Dsysvrcnd-path= \ -Dutmp=false \ - -Dblkid=true \ -Dman=false \ -Dima=false \ -Dldconfig=false \
@@ -205,6 +204,18 @@ else SYSTEMD_CONF_OPTS += -Dpcre2=false endif +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y) +SYSTEMD_CONF_OPTS += -Dblkid=true +else +SYSTEMD_CONF_OPTS += -Dblkid=false +endif + +ifeq ($(BR2_PACKAGE_UTIL_LINUX_NOLOGIN),y) +SYSTEMD_CONF_OPTS += -Dnologin-path=/usr/sbin/nologin +else +SYSTEMD_CONF_OPTS += -Dnologin-path=/bin/false +endif + ifeq ($(BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY),y) SYSTEMD_DEPENDENCIES += libmicrohttpd SYSTEMD_CONF_OPTS += -Dmicrohttpd=true
Signature · 1 line
2.27.0
PATCH v2 1/1 package/systemd: make a couple dependencies optional
Norbert, All,
On 2020-07-18 01:42 +0200, Norbert Lange spake thusly:
Quoted 7 lines
Remove
BR2_PACKAGE_UTIL_LINUX_BINARIES, as none
of the tools is necessary.Remove
BR2_PACKAGE_UTIL_LINUX_LIBBLKID, as this is optional. Aslong as MOUNT or FSCK are enabled, it will end up enabled anyway, but this seems more clear and correct.
Quoted 5 lines
Remove
BR2_PACKAGE_UTIL_LINUX_NOLOGIN, if this option is not enabled then fall back to using/bin/falseinstead.For importd, remove
BR2_PACKAGE_BZIP2andBR2_PACKAGE_LZ4, those arent dependencies.
This patch does too many things. It should be at least split into four patches:
- drop bzip2 and lz4 for importd
- drop util-linux' binaries
- make util-linux' nologin optional
- make util-linux' libblkid optional
Also, I would extra love that we add a runtime test for this stripped-down systemd settings, to check that a minimalist systemd still works as expected.
Not only will a runtime test help get confidence in this kind of patches, but will help notice any breakage when we later update systemd to a newer version.
If at least because of the first point, I've marked this patch as "changes requested" in patchwork.
Please, could you also mark any patch that is superseded in your original series, now:
https://patchwork.ozlabs.org/project/buildroot/list/?series=183318
Regards,
Yann E. MORIN.
Quoted 72 lines
Signed-off-by Norbert Lange <[email protected]>---
v1->v2:(quoted diff) +0
-2- undo a copy-paste mistake in the repart section - Drop some dependencies for importd aswellSigned-off-by Norbert Lange <[email protected]>--- package/systemd/Config.in | 5 ----- package/systemd/systemd.mk | 13 ++++++++++++- 2 files changed, 12 insertions(+), 6 deletions(-)package/systemd/Config.in +0
-5@@ -28,12 +28,9 @@ menuconfig BR2_PACKAGE_SYSTEMD select BR2_PACKAGE_DBUS # runtime dependency only select BR2_PACKAGE_LIBCAP select BR2_PACKAGE_UTIL_LINUX - select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT - select BR2_PACKAGE_UTIL_LINUX_BINARIES select BR2_PACKAGE_UTIL_LINUX_AGETTY select BR2_PACKAGE_UTIL_LINUX_MOUNT - select BR2_PACKAGE_UTIL_LINUX_NOLOGIN select BR2_PACKAGE_UTIL_LINUX_FSCK select BR2_PACKAGE_KMOD select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools@@ -240,8 +237,6 @@ config BR2_PACKAGE_SYSTEMD_IMPORTD depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBGCRYPT - select BR2_PACKAGE_BZIP2 - select BR2_PACKAGE_LZ4 select BR2_PACKAGE_XZ select BR2_PACKAGE_ZLIB helppackage/systemd/systemd.mk +12
-1@@ -25,7 +25,6 @@ SYSTEMD_CONF_OPTS += \ -Dsysvinit-path= \ -Dsysvrcnd-path= \ -Dutmp=false \ - -Dblkid=true \ -Dman=false \ -Dima=false \ -Dldconfig=false \@@ -205,6 +204,18 @@ else SYSTEMD_CONF_OPTS += -Dpcre2=false endif +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y) +SYSTEMD_CONF_OPTS += -Dblkid=true +else +SYSTEMD_CONF_OPTS += -Dblkid=false +endif + +ifeq ($(BR2_PACKAGE_UTIL_LINUX_NOLOGIN),y) +SYSTEMD_CONF_OPTS += -Dnologin-path=/usr/sbin/nologin +else +SYSTEMD_CONF_OPTS += -Dnologin-path=/bin/false +endif + ifeq ($(BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY),y) SYSTEMD_DEPENDENCIES += libmicrohttpd SYSTEMD_CONF_OPTS += -Dmicrohttpd=trueSignature · 1 line
2.27.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/systemd: make a couple dependencies optional
Am Sa., 18. Juli 2020 um 22:25 Uhr schrieb Yann E. MORIN <[email protected]>:
Quoted 17 lines
Norbert, All,
On 2020-07-18 01:42 +0200, Norbert Lange spake thusly:
Quoted 7 lines
Remove
BR2_PACKAGE_UTIL_LINUX_BINARIES, as none
of the tools is necessary.Remove
BR2_PACKAGE_UTIL_LINUX_LIBBLKID, as this is optional. Aslong as MOUNT or FSCK are enabled, it will end up enabled anyway, but this seems more clear and correct.Quoted 5 lines
Remove
BR2_PACKAGE_UTIL_LINUX_NOLOGIN, if this option is not enabled then fall back to using/bin/falseinstead.For importd, remove
BR2_PACKAGE_BZIP2andBR2_PACKAGE_LZ4, those arent dependencies.
Quoted 7 lines
This patch does too many things. It should be at least split into four patches:
- drop bzip2 and lz4 for importd
- drop util-linux' binaries
- make util-linux' nologin optional
- make util-linux' libblkid optional
Thats primary a matter of handling a set of patches and their rebases over quite some time.
Quoted 4 lines
Also, I would extra love that we add a runtime test for this stripped-down systemd settings, to check that a minimalist systemd still works as expected
Issue of time (lack thereof).
I can guarantee you that I run a pretty minimal configuration (removed dbus/dbus-broker aswell),
but I suspect that's not really tested upstream.
Some better definition of what to expect of a functional systemd would be nice tho.
Quoted 6 lines
Not only will a runtime test help get confidence in this kind of patches, but will help notice any breakage when we later update systemd to a newer version.
If at least because of the first point, I've marked this patch as "changes requested" in patchwork.
TBH I don't look at that, tried to wake up maintainers a few times by changing state did not seem to work either ;)
Quoted 4 lines
Please, could you also mark any patch that is superseded in your original series, now:
https://patchwork.ozlabs.org/project/buildroot/list/?series=183318
Done.
Quoted 79 lines
Regards,
Yann E. MORIN.Quoted 70 lines
Signed-off-by Norbert Lange <[email protected]>---
v1->v2:(quoted diff) +0
-2- undo a copy-paste mistake in the repart section - Drop some dependencies for importd aswellSigned-off-by Norbert Lange <[email protected]>--- package/systemd/Config.in | 5 ----- package/systemd/systemd.mk | 13 ++++++++++++- 2 files changed, 12 insertions(+), 6 deletions(-)package/systemd/Config.in +0
-5@@ -28,12 +28,9 @@ menuconfig BR2_PACKAGE_SYSTEMD select BR2_PACKAGE_DBUS # runtime dependency only select BR2_PACKAGE_LIBCAP select BR2_PACKAGE_UTIL_LINUX - select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT - select BR2_PACKAGE_UTIL_LINUX_BINARIES select BR2_PACKAGE_UTIL_LINUX_AGETTY select BR2_PACKAGE_UTIL_LINUX_MOUNT - select BR2_PACKAGE_UTIL_LINUX_NOLOGIN select BR2_PACKAGE_UTIL_LINUX_FSCK select BR2_PACKAGE_KMOD select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools@@ -240,8 +237,6 @@ config BR2_PACKAGE_SYSTEMD_IMPORTD depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBGCRYPT - select BR2_PACKAGE_BZIP2 - select BR2_PACKAGE_LZ4 select BR2_PACKAGE_XZ select BR2_PACKAGE_ZLIB helppackage/systemd/systemd.mk +12
-2@@ -25,7 +25,6 @@ SYSTEMD_CONF_OPTS += \ -Dsysvinit-path= \ -Dsysvrcnd-path= \ -Dutmp=false \ - -Dblkid=true \ -Dman=false \ -Dima=false \ -Dldconfig=false \@@ -205,6 +204,18 @@ else SYSTEMD_CONF_OPTS += -Dpcre2=false endif +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y) +SYSTEMD_CONF_OPTS += -Dblkid=true +else +SYSTEMD_CONF_OPTS += -Dblkid=false +endif + +ifeq ($(BR2_PACKAGE_UTIL_LINUX_NOLOGIN),y) +SYSTEMD_CONF_OPTS += -Dnologin-path=/usr/sbin/nologin +else +SYSTEMD_CONF_OPTS += -Dnologin-path=/bin/false +endif + ifeq ($(BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY),y) SYSTEMD_DEPENDENCIES += libmicrohttpd SYSTEMD_CONF_OPTS += -Dmicrohttpd=true --Quoted 2 lines
2.27.0
--
.-----------------.--------------------.------------------.--------------------.
Quoted 5 lines
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
Norbert
PATCH v2 1/1 package/systemd: make a couple dependencies optional
Romain had a serie enabling systemd's self-test, but I'm not sure what happened to it...
Le lun. 20 juil. 2020 ? 01:15, Norbert Lange <[email protected]> a ?crit :
Quoted 153 lines
Am Sa., 18. Juli 2020 um 22:25 Uhr schrieb Yann E. MORIN <[email protected]>:
Quoted 17 lines
Norbert, All,
On 2020-07-18 01:42 +0200, Norbert Lange spake thusly:
Quoted 7 lines
Remove
BR2_PACKAGE_UTIL_LINUX_BINARIES, as none
of the tools is necessary.Remove
BR2_PACKAGE_UTIL_LINUX_LIBBLKID, as this is optional. Aslong as MOUNT or FSCK are enabled, it will end up enabled anyway, but this seems more clear and correct.Quoted 5 lines
Remove
BR2_PACKAGE_UTIL_LINUX_NOLOGIN, if this option is not enabled then fall back to using/bin/falseinstead.For importd, remove
BR2_PACKAGE_BZIP2andBR2_PACKAGE_LZ4, those arent dependencies.Quoted 7 lines
This patch does too many things. It should be at least split into four patches:
- drop bzip2 and lz4 for importd
- drop util-linux' binaries
- make util-linux' nologin optional
- make util-linux' libblkid optionalThats primary a matter of handling a set of patches and their rebases over quite some time.
Quoted 4 lines
Also, I would extra love that we add a runtime test for this stripped-down systemd settings, to check that a minimalist systemd still works as expected
Issue of time (lack thereof).
I can guarantee you that I run a pretty minimal configuration (removed dbus/dbus-broker aswell),
but I suspect that's not really tested upstream.Some better definition of what to expect of a functional systemd would be nice tho.
Quoted 6 lines
Not only will a runtime test help get confidence in this kind of patches, but will help notice any breakage when we later update systemd to a newer version.
If at least because of the first point, I've marked this patch as "changes requested" in patchwork.
TBH I don't look at that, tried to wake up maintainers a few times by changing state did not seem to work either ;)
Quoted 4 lines
Please, could you also mark any patch that is superseded in your original series, now:
https://patchwork.ozlabs.org/project/buildroot/list/?series=183318Done.
Quoted 70 lines
Regards,
Yann E. MORIN.Quoted 66 lines
Signed-off-by Norbert Lange <[email protected]>---
v1->v2:(quoted diff) +0
-2- undo a copy-paste mistake in the repart section - Drop some dependencies for importd aswellSigned-off-by Norbert Lange <[email protected]>--- package/systemd/Config.in | 5 ----- package/systemd/systemd.mk | 13 ++++++++++++- 2 files changed, 12 insertions(+), 6 deletions(-)package/systemd/Config.in +0
-5@@ -28,12 +28,9 @@ menuconfig BR2_PACKAGE_SYSTEMD select BR2_PACKAGE_DBUS # runtime dependency only select BR2_PACKAGE_LIBCAP select BR2_PACKAGE_UTIL_LINUX - select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT - select BR2_PACKAGE_UTIL_LINUX_BINARIES select BR2_PACKAGE_UTIL_LINUX_AGETTY select BR2_PACKAGE_UTIL_LINUX_MOUNT - select BR2_PACKAGE_UTIL_LINUX_NOLOGIN select BR2_PACKAGE_UTIL_LINUX_FSCK select BR2_PACKAGE_KMOD select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # kmod-tools@@ -240,8 +237,6 @@ config BR2_PACKAGE_SYSTEMD_IMPORTD depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBGCRYPT - select BR2_PACKAGE_BZIP2 - select BR2_PACKAGE_LZ4 select BR2_PACKAGE_XZ select BR2_PACKAGE_ZLIB helppackage/systemd/systemd.mk +12
-1@@ -25,7 +25,6 @@ SYSTEMD_CONF_OPTS += \ -Dsysvinit-path= \ -Dsysvrcnd-path= \ -Dutmp=false \ - -Dblkid=true \ -Dman=false \ -Dima=false \ -Dldconfig=false \@@ -205,6 +204,18 @@ else SYSTEMD_CONF_OPTS += -Dpcre2=false endif +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y) +SYSTEMD_CONF_OPTS += -Dblkid=true +else +SYSTEMD_CONF_OPTS += -Dblkid=false +endif + +ifeq ($(BR2_PACKAGE_UTIL_LINUX_NOLOGIN),y) +SYSTEMD_CONF_OPTS += -Dnologin-path=/usr/sbin/nologin +else +SYSTEMD_CONF_OPTS += -Dnologin-path=/bin/false +endif +Quoted 9 lines
Quoted 6 lines
package/systemd/systemd.mk +0
-1ifeq ($(BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY),y) SYSTEMD_DEPENDENCIES += libmicrohttpd SYSTEMD_CONF_OPTS += -Dmicrohttpd=true --2.27.0
--
.-----------------.--------------------.------------------.--------------------.
Quoted 1 line
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
conspiracy: |
Quoted 1 line
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___
|Quoted 1 line
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There
is no |
Quoted 1 line
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v
conspiracy. |
Quoted 1 line
'------------------------------^-------^------------------^--------------------'
Norbert
Signature · 21 lines
[image: SMILE] <http://www.smile.eu/> 20 rue des Jardins 92600 Asni?res-sur-Seine *J?r?my ROSEN* Architecte technique [image: email] jeremy.rosen at smile.fr [image: phone] +33 6 88 25 87 42 [image: url] http://www.smile.eu [image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook] <https://www.facebook.com/smileopensource> [image: LinkedIn] <https://www.linkedin.com/company/smile> [image: Github] <https://github.com/Smile-SA> [image: D?couvrez l?univers Smile, rendez-vous sur smile.eu] <https://www.smile.eu/fr/publications/livres-blancs/yocto?utm_source=signature&utm_medium=email&utm_campaign=signature> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200720/82e98134/attachment.html>