Skip to contentSkip to conversation

package/jq: needs threads

PATCH New Fabrice Fontaine 3 participants 3 messages Jul 18, 2020 – Jul 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/jq: needs threads

threads is a strong requirement since
https://github.com/stedolan/jq/commit/cf4b48c7ba30cb30e116b523cff036ea481459f6

Fixes:
- http://autobuild.buildroot.org/results/b871cc175655c2d6aa5f184d891b994a0ebd9902

---
 package/jq/Config.in     | 4 ++++
 package/sysdig/Config.in | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
package/jq/Config.in +4 -0
index 321cbe8b51..5edb5d0989 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_JQ
 	bool "jq"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  jq is like sed for JSON data - you can use it to slice and
 	  filter and map and transform structured data with the same
 	  ease that sed, awk, grep and friends let you play with text.
 
 	  http://stedolan.github.io/jq/
+
+comment "jq needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/sysdig/Config.in +3 -1
index 0a1b3f8935..ee53b4fa20 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_SYSDIG
 	depends on BR2_INSTALL_LIBSTDCPP # libjson
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_TOOLCHAIN_HAS_THREADS # jq
 	depends on !BR2_STATIC_LIBS # luajit, elfutils
 	depends on BR2_USE_WCHAR # elfutils
 	depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils
@@ -25,8 +26,9 @@ config BR2_PACKAGE_SYSDIG
 
 	  https://github.com/draios/sysdig/wiki
 
-comment "sysdig needs a glibc or uclibc toolchain w/ C++, gcc >= 4.8, dynamic library and a Linux kernel to be built"
+comment "sysdig needs a glibc or uclibc toolchain w/ C++, threads, gcc >= 4.8, dynamic library and a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP \
+		|| !BR2_TOOLCHAIN_HAS_THREADS \
 		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS \
 		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/jq: needs threads

Fabrice, All,

On 2020-07-18 23:11 +0200, Fabrice Fontaine spake thusly:

Quoted 7 lines

threads is a strong requirement since
https://github.com/stedolan/jq/commit/cf4b48c7ba30cb30e116b523cff036ea481459f6

Fixes:
- http://autobuild.buildroot.org/results/b871cc175655c2d6aa5f184d891b994a0ebd9902

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 52 lines
---
 package/jq/Config.in     | 4 ++++
 package/sysdig/Config.in | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
package/jq/Config.in +4 -0
index 321cbe8b51..5edb5d0989 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_JQ
 	bool "jq"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  jq is like sed for JSON data - you can use it to slice and
 	  filter and map and transform structured data with the same
 	  ease that sed, awk, grep and friends let you play with text.
 
 	  http://stedolan.github.io/jq/
+
+comment "jq needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/sysdig/Config.in +3 -1
index 0a1b3f8935..ee53b4fa20 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_SYSDIG
 	depends on BR2_INSTALL_LIBSTDCPP # libjson
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_TOOLCHAIN_HAS_THREADS # jq
 	depends on !BR2_STATIC_LIBS # luajit, elfutils
 	depends on BR2_USE_WCHAR # elfutils
 	depends on BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC # elfutils
@@ -25,8 +26,9 @@ config BR2_PACKAGE_SYSDIG
 
 	  https://github.com/draios/sysdig/wiki
 
-comment "sysdig needs a glibc or uclibc toolchain w/ C++, gcc >= 4.8, dynamic library and a Linux kernel to be built"
+comment "sysdig needs a glibc or uclibc toolchain w/ C++, threads, gcc >= 4.8, dynamic library and a Linux kernel to be built"
 	depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP \
+		|| !BR2_TOOLCHAIN_HAS_THREADS \
 		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS \
 		|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
Signature · 6 lines
2.27.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/jq: needs threads

In reply to Fabrice Fontaine
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

threads is a strong requirement since
https://github.com/stedolan/jq/commit/cf4b48c7ba30cb30e116b523cff036ea481459f6

Fixes:
- http://autobuild.buildroot.org/results/b871cc175655c2d6aa5f184d891b994a0ebd9902

Committed to 2020.02.x and 2020.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard