Skip to contentSkip to conversation

staging: rtl8192e: Fixed the space and indentation coding styles

PATCH In review Darshan D V 2 participants 6 messages Jul 17, 2020 – Jul 19, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e: Fixed the space and indentation coding styles

rtllib_crypt_ccmp.c: Fixed the error - space required before the open parenthesis '(' on line #281.

rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for conditional statements on line #338

---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +2 -2
index 0cbf4a1a326b..b60e2a109ce4 100644
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		int aad_len, ret;
 
 		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
-		if(!req)
+		if (!req)
 			return -ENOMEM;
 
 		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 		}
 		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
 			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
-				return -1;
+			return -1;
 	} else if (len == 0) {
 		data->key_set = 0;
 	} else {
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 35 lines · Darshan D V

rtllib_crypt_ccmp.c: Fixed the error - space required before the open parenthesis '(' on line #281.

rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for conditional statements on line #338

---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +2 -2
index 0cbf4a1a326b..b60e2a109ce4 100644
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		int aad_len, ret;
 
 		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
-		if(!req)
+		if (!req)
 			return -ENOMEM;
 
 		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 		}
 		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
 			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
-				return -1;
+			return -1;
 	} else if (len == 0) {
 		data->key_set = 0;
 	} else {
Signature · 1 line
2.17.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#2 lore raw

PATCH 1/2 staging: rtl8192e: Fixed a coding style error

rtllib_crypt_ccmp.c: Fixed the error - space required before the open parenthesis '(' on line #281.

---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +1 -1
index 0cbf4a1a326b..b2af802b9451 100644
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		int aad_len, ret;
 
 		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
-		if(!req)
+		if (!req)
 			return -ENOMEM;
 
 		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
Signature · 1 line
2.17.1
#3 lore raw

PATCH 2/2 staging: rtl8192e: Fixed a coding style warning

rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for conditional statements on line #338

---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +1 -1
index b2af802b9451..b60e2a109ce4 100644
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 		}
 		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
 			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
-				return -1;
+			return -1;
 	} else if (len == 0) {
 		data->key_set = 0;
 	} else {
Signature · 1 line
2.17.1
maintainer
#4 lore raw

Re: [PATCH 2/2] staging: rtl8192e: Fixed a coding style warning

Quoted 2 lines · Darshan D V

rtllib_crypt_ccmp.c: Fixed the warning - suspect code indent for conditional statements on line #338

You can't send two patches that do two different things, yet have the same exact subject: line :(

maintainer
#5 lore raw

Re: [PATCH 1/2] staging: rtl8192e: Fixed a coding style error

In reply to Darshan D V
Quoted 2 lines · Darshan D V

rtllib_crypt_ccmp.c: Fixed the error - space required before the open parenthesis '(' on line #281.

What does this mean for a changelog text?

And why is it indented?

Did you read the section in the submitting patches document about how to write a changelog text? Perhaps you might want to re-read that :)

Quoted 1 line

Is this how you sign legal documents? If so, great, but I have to ask.

thanks,

greg k-h