Skip to contentSkip to conversation

staging: rtl8192e: add space before open parenthesis

PATCH In review Darshan D V 2 participants 3 messages Jul 19, 2020 – Jul 20, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 staging: rtl8192e: add space before open parenthesis

rtllib_crypt_ccmp.c:

Fix the coding style error by adding a space before open parenthesis '(' in a conditional statement.

---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +1 -1
index 0cbf4a1a326b..b2af802b9451 100644
@@ -278,7 +278,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		int aad_len, ret;
 
 		req = aead_request_alloc(key->tfm, GFP_ATOMIC);
-		if(!req)
+		if (!req)
 			return -ENOMEM;
 
 		aad_len = ccmp_init_iv_and_aad(hdr, pn, iv, aad);
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 staging: rtl8192e: add proper code indent

rtllib_crypt_ccmp.c:

As the code indent for a conditional statement is not according to the preferred coding style for the linux kernel, add code indent as necessary after a conditional statement.

---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +1 -1
index b2af802b9451..b60e2a109ce4 100644
@@ -337,7 +337,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 		}
 		if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) ||
 			crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN))
-				return -1;
+			return -1;
 	} else if (len == 0) {
 		data->key_set = 0;
 	} else {
Signature · 1 line
2.17.1
maintainer
#2 lore raw
In reply to Darshan D V
Quoted 1 line · Darshan D V

rtllib_crypt_ccmp.c:

Why is this listed here, with a trailing space? There's no real need for it, do you see other patches for this file/driver doing that? Try looking at those for examples of how to properly format changelog texts.

Same thing for your 2/2 patch.

thanks,

greg k-h