Skip to contentSkip to conversation

drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

PATCH In review Guido Günther 3 participants 5 messages Jul 18, 2020 – Jul 26, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.

This was prompted by Sam in
https://lore.kernel.org/dri-devel/[email protected]/

Guido Günther (1):
drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

 drivers/gpu/drm/bridge/nwl-dsi.c | 5 -----
 1 file changed, 5 deletions(-)
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.

---
 drivers/gpu/drm/bridge/nwl-dsi.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/bridge/nwl-dsi.c +0 -5
index 77a79af70914..ce94f797d090 100644
@@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
 	struct drm_panel *panel;
 	int ret;
 
-	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
-		DRM_ERROR("Fix bridge driver to make connector optional!");
-		return -EINVAL;
-	}
-
 	ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
 					  &panel_bridge);
 	if (ret)
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#2 lore raw

Hi Guido.

Quoted 4 lines · Guido Günther

We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.

Looks good and correct.

If there is no other feedback I will apply within a few days. Ping me if I forget it.

Sam

Quoted 27 lines
---
 drivers/gpu/drm/bridge/nwl-dsi.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/bridge/nwl-dsi.c +0 -5
index 77a79af70914..ce94f797d090 100644
@@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
 	struct drm_panel *panel;
 	int ret;
 
-	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
-		DRM_ERROR("Fix bridge driver to make connector optional!");
-		return -EINVAL;
-	}
-
 	ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
 					  &panel_bridge);
 	if (ret)
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

reviewer Reviewed-by on v1 1/1
#3 lore raw
In reply to Guido Günther

Hi Guido,

Thank you for the patch.

Quoted 4 lines · Guido Günther

We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.

Quoted 20 lines
---
 drivers/gpu/drm/bridge/nwl-dsi.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/bridge/nwl-dsi.c +0 -5
index 77a79af70914..ce94f797d090 100644
@@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,
 	struct drm_panel *panel;
 	int ret;
 
-	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
-		DRM_ERROR("Fix bridge driver to make connector optional!");
-		return -EINVAL;
-	}
-
 	ret = drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
 					  &panel_bridge);
 	if (ret)
Signature · 7 lines
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw
In reply to Guido Günther

Hi Guido.

Quoted 8 lines · Guido Günther

We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.

This was prompted by Sam in
https://lore.kernel.org/dri-devel/[email protected]/

Now applied to drm-misc-fixes.

Sam

Quoted 14 lines

Guido Günther (1):
drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

 drivers/gpu/drm/bridge/nwl-dsi.c | 5 -----
 1 file changed, 5 deletions(-)
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel