drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.
Subsystems (3)
cover drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.
We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.
This was prompted by Sam in
https://lore.kernel.org/dri-devel/[email protected]/
Guido Günther (1):
drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.
drivers/gpu/drm/bridge/nwl-dsi.c | 5 ----- 1 file changed, 5 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/1 drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.
We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.
--- drivers/gpu/drm/bridge/nwl-dsi.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/bridge/nwl-dsi.c +0 -5
@@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,struct drm_panel *panel;int ret; -if (flags &DRM_BRIDGE_ATTACH_NO_CONNECTOR ) { -DRM_ERROR ("Fix bridge driver to make connector optional!" ); -return -EINVAL ; - } - ret =drm_of_find_panel_or_bridge (dsi->dev->of_node,1 ,0 , &panel, &panel_bridge);if (ret)
Signature · 1 line
2.26.2
Hi Guido.
Quoted 4 lines · Guido Günther
We don't create a connector but let
panel_bridgehandle that so there's no point in rejectingDRM_BRIDGE_ATTACH_NO_CONNECTOR.Signed-off-by Guido Günther <[email protected]>
Looks good and correct.
If there is no other feedback I will apply within a few days. Ping me if I forget it.
Sam
Quoted 27 lines
--- drivers/gpu/drm/bridge/nwl-dsi.c | 5 ----- 1 file changed, 5 deletions(-)drivers/gpu/drm/bridge/nwl-dsi.c +0
-5@@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,struct drm_panel *panel;int ret; -if (flags &DRM_BRIDGE_ATTACH_NO_CONNECTOR ) { -DRM_ERROR ("Fix bridge driver to make connector optional!" ); -return -EINVAL ; - } - ret =drm_of_find_panel_or_bridge (dsi->dev->of_node,1 ,0 , &panel, &panel_bridge);if (ret)Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Guido,
Thank you for the patch.
Quoted 4 lines · Guido Günther
We don't create a connector but let
panel_bridgehandle that so there's no point in rejectingDRM_BRIDGE_ATTACH_NO_CONNECTOR.Signed-off-by Guido Günther <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/bridge/nwl-dsi.c | 5 ----- 1 file changed, 5 deletions(-)drivers/gpu/drm/bridge/nwl-dsi.c +0
-5@@ -918,11 +918,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge,struct drm_panel *panel;int ret; -if (flags &DRM_BRIDGE_ATTACH_NO_CONNECTOR ) { -DRM_ERROR ("Fix bridge driver to make connector optional!" ); -return -EINVAL ; - } - ret =drm_of_find_panel_or_bridge (dsi->dev->of_node,1 ,0 , &panel, &panel_bridge);if (ret)
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Guido.
Quoted 8 lines · Guido Günther
We don't create a connector but let
panel_bridgehandle that so there's no point in rejectingDRM_BRIDGE_ATTACH_NO_CONNECTOR.This was prompted by Sam in
https://lore.kernel.org/dri-devel/[email protected]/Signed-off-by Guido Günther <[email protected]>
Now applied to drm-misc-fixes.
Sam
Quoted 14 lines
Guido Günther (1):
drm/bridge: nwl-dsi: DropDRM_BRIDGE_ATTACH_NO_CONNECTORcheck.drivers/gpu/drm/bridge/nwl-dsi.c | 5 ----- 1 file changed, 5 deletions(-)Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel