package/exim: fix CC and LNCC initialization
PATCH 1/1 package/exim: fix CC and LNCC initialization
When using ccache to build the exim package, the HOSTCC value contains characters that are incorrectly interpreted by exim's Makefile, presumably spaces. This breaks the build with "unrecognized option" ccache errors.
Fix that by wrapping the HOSTCC variable in double quotes, as it is done for other variables that follow.
--- package/exim/exim.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/exim/exim.mk +2 -2
@@ -123,8 +123,8 @@ endif define EXIM_BUILD_CMDS $(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) makefile $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/build-br macro_predef \ - CC=$(HOSTCC) \ - LNCC=$(HOSTCC) \ + CC="$(HOSTCC)" \ + LNCC="$(HOSTCC)" \ CFLAGS="-std=c99 $(HOST_CFLAGS)" \ LFLAGS="-fPIC $(HOST_LDFLAGS)" $(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) $(EXIM_STATIC_FLAGS) \
Signature · 1 line
2.27.0
Yann E. MORIN
AppliedPATCH 1/1 package/exim: fix CC and LNCC initialization
Alejandro, All,
On 2020-07-19 12:29 +0200, Alejandro Gonz?lez spake thusly:
Quoted 9 lines
When using ccache to build the exim package, the HOSTCC value contains characters that are incorrectly interpreted by exim's
Makefile, presumably spaces. This breaks the build with "unrecognized option" ccache errors.Fix that by wrapping the HOSTCC variable in double quotes, as it is done for other variables that follow.
Signed-off-by Alejandro Gonz?lez <[email protected]>
Applied to master, after tweaking the commit log slightly. Thanks!
Regards,
Yann E. MORIN.
Quoted 26 lines
--- package/exim/exim.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)package/exim/exim.mk +2
-2@@ -123,8 +123,8 @@ endif define EXIM_BUILD_CMDS $(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) makefile $(HOST_MAKE_ENV) $(MAKE) -C $(@D)/build-br macro_predef \ - CC=$(HOSTCC) \ - LNCC=$(HOSTCC) \ + CC="$(HOSTCC)" \ + LNCC="$(HOSTCC)" \ CFLAGS="-std=c99 $(HOST_CFLAGS)" \ LFLAGS="-fPIC $(HOST_LDFLAGS)" $(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) $(EXIM_STATIC_FLAGS) \Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/exim: fix CC and LNCC initialization
In reply to Alejandro GonzálezQuoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Alejandro" == Alejandro Gonz?lez <[email protected]> writes:
When using ccache to build the exim package, the HOSTCC value contains characters that are incorrectly interpreted by exim's
Makefile, presumably spaces. This breaks the build with "unrecognized option" ccache errors.Fix that by wrapping the HOSTCC variable in double quotes, as it is done for other variables that follow.
Signed-off-by Alejandro Gonz?lez <[email protected]>
Committed to 2020.02.x and 2020.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard