package/cdrkit: fix build with GCC 10
PATCH 1/1 package/cdrkit: fix build with GCC 10
This patch adds a missing extern on the outfile
variable in genisoimage.h.
---
Note: I would like to see this applied to the LTS 2020.02 branch too, since it fixes building host-cdrkit for ISO9660 generation with a host GCC 10.
.../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patch
package/cdrkit/0003-genisoimage-outfile-extern.patch new file +13 -0
@@ -0,0 +1,13 @@ +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h +index bbedfb0..82c859b 100644 +--- a/genisoimage/genisoimage.h ++++ b/genisoimage/genisoimage.h +@@ -376,7 +376,7 @@ extern int use_fileversion; + extern int split_SL_component; + extern int split_SL_field; + extern char *trans_tbl; +-char *outfile; ++extern char *outfile; + + #define JMAX 64 /* maximum Joliet file name length (spec) */ + #define JLONGMAX 103 /* out of spec Joliet file name length */
Signature · 1 line
2.26.2
PATCH 1/1 package/cdrkit: fix build with GCC 10
Hi Urja,
Am Do., 25. Juni 2020 um 02:58 Uhr schrieb Urja Rannikko <[email protected]>:
Quoted 5 lines
This patch adds a missing extern on the outfile
variable ingenisoimage.h.Signed-off-by Urja Rannikko <[email protected]>
Quoted 35 lines
---
Note: I would like to see this applied to the LTS 2020.02 branch too, since it fixes building host-cdrkit for ISO9660 generation with a host GCC 10..../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patchpackage/cdrkit/0003-genisoimage-outfile-extern.patch new file +13
-1@@ -0,0 +1,13 @@ +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h +index bbedfb0..82c859b 100644 +--- a/genisoimage/genisoimage.h ++++ b/genisoimage/genisoimage.h +@@ -376,7 +376,7 @@ extern int use_fileversion; + extern int split_SL_component; + extern int split_SL_field; + extern char *trans_tbl; +-char *outfile; ++extern char *outfile; + + #define JMAX 64 /* maximum Joliet file name length (spec) */ + #define JLONGMAX 103 /* out of spec Joliet file name length */ --2.26.2
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 package/cdrkit: fix build with GCC 10
In reply to Urja RannikkoHello Urja,
Thanks for your contribution!
Quoted 19 lines · On Thu, 25 Jun 2020 03:58:36 +0300 Urja Rannikko <[email protected]> wrote:
This patch adds a missing extern on the outfile
variable ingenisoimage.h.Signed-off-by Urja Rannikko <[email protected]>---
Note: I would like to see this applied to the LTS 2020.02 branch too, since it fixes building host-cdrkit for ISO9660 generation with a host GCC 10..../cdrkit/0003-genisoimage-outfile-extern.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 package/cdrkit/0003-genisoimage-outfile-extern.patchpackage/cdrkit/0003-genisoimage-outfile-extern.patch new file +0
-0
package/cdrkit/0003-genisoimage-outfile-extern.patch line 4
Quoted 4 lines
package/cdrkit/0003-genisoimage-outfile-extern.patch new file +4
-0@@ -0,0 +1,13 @@ +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h +index bbedfb0..82c859b 100644 +--- a/genisoimage/genisoimage.h ++++ b/genisoimage/genisoimage.h
Thanks a lot for your patch! However, we need the cdrkit patch to have a proper commit title, commit description and Signed-off-by.
See
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for more details.
Could you adjust your patch accordingly ?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/cdrkit: fix build with GCC 10
In reply to Urja RannikkoThis patch adds a missing extern on the outfile
variable in genisoimage.h.
---
Note: I would like to see this applied to the LTS 2020.02 branch too, since it fixes building host-cdrkit for ISO9660 generation with a host GCC 10.
v2: Make the patch a fully fledged commit with a sign-off and way more description than is necessary for a single "extern".
...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch
package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch new file +30 -0
@@ -0,0 +1,30 @@ +From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001 +From: Urja Rannikko <[email protected]> +Date: Sun, 19 Jul 2020 20:28:27 +0300 +Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc + 10 + +Without this linking fails with a rather long spew of +"multiple definition of `outfile'". + +Signed-off-by: Urja Rannikko <[email protected]> +--- + genisoimage/genisoimage.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h +index bbedfb0..82c859b 100644 +--- a/genisoimage/genisoimage.h ++++ b/genisoimage/genisoimage.h +@@ -376,7 +376,7 @@ extern int use_fileversion; + extern int split_SL_component; + extern int split_SL_field; + extern char *trans_tbl; +-char *outfile; ++extern char *outfile; + + #define JMAX 64 /* maximum Joliet file name length (spec) */ + #define JLONGMAX 103 /* out of spec Joliet file name length */ +-- +2.27.0 +
Signature · 1 line
2.27.0
Yann E. MORIN
AppliedPATCH v2 1/1 package/cdrkit: fix build with GCC 10
Urja, All,
On 2020-07-19 20:42 +0300, Urja Rannikko spake thusly:
Quoted 4 lines
This patch adds a missing extern on the outfile
variable ingenisoimage.h.Signed-off-by Urja Rannikko <[email protected]>
Applied to master, thanks.
Quoted 4 lines
---
Note: I would like to see this applied to the LTS 2020.02 branch too, since it fixes building host-cdrkit for ISO9660 generation with a host GCC 10.
+Peter in cc.
Regards,
Yann E. MORIN.
Quoted 50 lines
v2: Make the patch a fully fledged commit with a sign-off and way more description than is necessary for a single "extern".
...ar-outfile-declaration-to-fix-build-.patch | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 package/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patchpackage/cdrkit/0003-Add-extern-to-char-outfile-declaration-to-fix-build-.patch new file +30
-0@@ -0,0 +1,30 @@ +From eabcc8a6e39dc3c28faee3e04aa56cc65a38d65a Mon Sep 17 00:00:00 2001 +From: Urja Rannikko <[email protected]> +Date: Sun, 19 Jul 2020 20:28:27 +0300 +Subject: [PATCH] Add extern to char* outfile declaration to fix build with gcc + 10 + +Without this linking fails with a rather long spew of +"multiple definition of `outfile'". + +Signed-off-by: Urja Rannikko <[email protected]> +--- + genisoimage/genisoimage.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/genisoimage/genisoimage.h b/genisoimage/genisoimage.h +index bbedfb0..82c859b 100644 +--- a/genisoimage/genisoimage.h ++++ b/genisoimage/genisoimage.h +@@ -376,7 +376,7 @@ extern int use_fileversion; + extern int split_SL_component; + extern int split_SL_field; + extern char *trans_tbl; +-char *outfile; ++extern char *outfile; + + #define JMAX 64 /* maximum Joliet file name length (spec) */ + #define JLONGMAX 103 /* out of spec Joliet file name length */ +-- +2.27.0 +Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/cdrkit: fix build with GCC 10
In reply to Urja RannikkoQuoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Urja" == Urja Rannikko <[email protected]> writes:
This patch adds a missing extern on the outfile
variable ingenisoimage.h.
Quoted 8 lines
Signed-off-by Urja Rannikko <[email protected]>---
Note: I would like to see this applied to the LTS 2020.02 branch too, since it fixes building host-cdrkit for ISO9660 generation with a host GCC 10.v2: Make the patch a fully fledged commit with a sign-off and way more description than is necessary for a single "extern".
Committed to 2020.02.x and 2020.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard