Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list
PATCH 1/1 Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list
These symbols were recently deprecated but the test still checks for them which fails for ARC.
Tested with arc-linux-gnuhf
-FAIL: elf/tst-libc_dlvsym
+PASS: elf/tst-libc_dlvsym
-FAIL: elf/tst-libc_dlvsym-static
+PASS: elf/tst-libc_dlvsym-static
| | $ cat elf/tst-libc_dlvsym-static.out | error: tst-libc_dlvsym.h:103: symbol _sys_errlist not found at any version |
caveats:
1. This does reduce test-coverage for existing ports with older versions of glibc where these symbols are valid, but reckon it is not an issue since the symbol is being deprecated anyways
2. IMHO, despite the ABI freeze it should be fine for 2.32 too since it doesn't modify glibc ABI/API in any way, only a test-header is.
--- elf/tst-libc_dlvsym.h | 2 -- 1 file changed, 2 deletions(-)
elf/tst-libc_dlvsym.h +0 -2
@@ -117,8 +117,6 @@ compare_vsyms (void)obtain an explicit handle for libc.so. */ void *libc_handle =xdlopen (LIBC_SO ,RTLD_LAZY |RTLD_NOLOAD ); -compare_vsyms_1 (libc_handle,"_sys_errlist" ); -compare_vsyms_1 (libc_handle,"_sys_siglist" );compare_vsyms_1 (libc_handle,"quick_exit" );xdlclose (libc_handle);
Signature · 7 lines
2.20.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
* Vineet Gupta via Libc-alpha:
elf/tst-libc_dlvsym.h compare_vsyms (void) · line 122
Quoted 13 lines
elf/tst-libc_dlvsym.h +0
-2@@ -117,8 +117,6 @@ compare_vsyms (void)obtain an explicit handle for libc.so. */ void *libc_handle =xdlopen (LIBC_SO ,RTLD_LAZY |RTLD_NOLOAD ); -compare_vsyms_1 (libc_handle,"_sys_errlist" ); -compare_vsyms_1 (libc_handle,"_sys_siglist" );compare_vsyms_1 (libc_handle,"quick_exit" );xdlclose (libc_handle);
Please use TEST_COMPAT, as in malloc/tst-mallocstate.c.
Thanks,
Florian
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc