Skip to contentSkip to conversation

drm/amdgpu: add printing after executing page reservation to eeprom

PATCH In review Guchun Chen 2 participants 2 messages Jul 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: add printing after executing page reservation to eeprom

This will tell users if the faulty page has been written to external eeprom device in dmesg log.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +4 -1
index 6f06e1214622..4a82a587de28 100644
@@ -1622,7 +1622,7 @@ static int amdgpu_ras_save_bad_pages(struct amdgpu_device *adev)
 	data = con->eh_data;
 	save_count = data->count - control->num_recs;
 	/* only new entries are saved */
-	if (save_count > 0)
+	if (save_count > 0) {
 		if (amdgpu_ras_eeprom_process_recods(control,
 							&data->bps[control->num_recs],
 							true,
@@ -1631,6 +1631,9 @@ static int amdgpu_ras_save_bad_pages(struct amdgpu_device *adev)
 			return -EIO;
 		}
 
+		dev_info(adev->dev, "Saved %d pages to EEPROM table.\n", save_count);
+	}
+
 	return 0;
 }
 
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

-----Original Message-----
From: Chen, Guchun <[email protected]>
Sent: Monday, July 20, 2020 11:16 AM
To: [email protected]; Zhang, Hawking <[email protected]>; Li, Dennis <[email protected]>; Yang, Stanley <[email protected]>; Zhou1, Tao <[email protected]>; Clements, John <[email protected]>
Cc: Chen, Guchun <[email protected]>
Subject: [PATCH] drm/amdgpu: add printing after executing page reservation to eeprom

This will tell users if the faulty page has been written to external eeprom device in dmesg log.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +4 -1
index 6f06e1214622..4a82a587de28 100644
@@ -1622,7 +1622,7 @@ static int amdgpu_ras_save_bad_pages(struct amdgpu_device *adev)
 data = con->eh_data;
 save_count = data->count - control->num_recs;
 /* only new entries are saved */
-if (save_count > 0)
+if (save_count > 0) {
 if (amdgpu_ras_eeprom_process_recods(control,
 &data->bps[control->num_recs],
 true,
@@ -1631,6 +1631,9 @@ static int amdgpu_ras_save_bad_pages(struct amdgpu_device *adev)
 return -EIO;
 }
 
+dev_info(adev->dev, "Saved %d pages to EEPROM table.\n", save_count);
+}
+
 return 0;
 }
 

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx