net/ice/base: free memory for GTP-U before return status
PATCH 1/1 net/ice/base: free memory for GTP-U before return status
Add memory space free logic for adding and removing GTP-U before return success status, to aviod memory leak issue.
--- drivers/net/ice/base/ice_flow.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/net/ice/base/ice_flow.c +8 -4
@@ -3586,8 +3586,10 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,/* don't do RSS for GTPU outer */ if (segs_cnt ==ICE_RSS_OUTER_HEADERS && - segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) -return ICE_SUCCESS ; + segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) { + status =ICE_SUCCESS ; + goto exit; + }/* Search for a flow profile that has matching headers, hash fields * and has the input VSI associated to it. If found, no further
@@ -3746,8 +3748,10 @@ ice_rem_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds, goto out;if (segs_cnt ==ICE_RSS_OUTER_HEADERS && - segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) -return ICE_SUCCESS ; + segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) { + status =ICE_SUCCESS ; + goto out; + } prof = ice_flow_find_prof_conds(hw, blk, ICE_FLOW_RX, segs, segs_cnt, vsi_handle,
Signature · 1 line
2.25.1
PATCH 1/1 net/ice/base: free memory for GTP-U before return status
Add memory space free logic for adding and removing GTP-U before return success status, to avoid memory leak issue.
v2:
- fix small typo in commit message.
--- drivers/net/ice/base/ice_flow.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/net/ice/base/ice_flow.c +8 -4
@@ -3586,8 +3586,10 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,/* don't do RSS for GTPU outer */ if (segs_cnt ==ICE_RSS_OUTER_HEADERS && - segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) -return ICE_SUCCESS ; + segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) { + status =ICE_SUCCESS ; + goto exit; + }/* Search for a flow profile that has matching headers, hash fields * and has the input VSI associated to it. If found, no further
@@ -3746,8 +3748,10 @@ ice_rem_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds, goto out;if (segs_cnt ==ICE_RSS_OUTER_HEADERS && - segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) -return ICE_SUCCESS ; + segs[segs_cnt -1 ].hdrs &ICE_FLOW_SEG_HDR_GTPU ) { + status =ICE_SUCCESS ; + goto out; + } prof = ice_flow_find_prof_conds(hw, blk, ICE_FLOW_RX, segs, segs_cnt, vsi_handle,
Signature · 1 line
2.25.1
Quoted 10 lines
-----Original Message-----
From: Guo, Junfeng <[email protected]>
Sent: Monday, July 20, 2020 3:10 PM
To: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Guo, Jia <[email protected]>; Guo, Junfeng <[email protected]>; Su, Simei <[email protected]>
Subject: [PATCH]net/ice/base: free memory for GTP-U before return status
Quoted 5 lines
Add memory space free logic for adding and removing GTP-U before return success status, to avoid memory leak issue.
v2:
- fix small typo in commit message.
Change log should be moved after '---"
Quoted 4 lines
Fixes bed9bb3139ef ("net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist")Signed-off-by Junfeng Guo <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi