net/ice: fix symmetric hash configuration
PATCH 1/1 net/ice: fix symmetric hash configuration
Some protocol don't support symmetric hash, need to handle these cases. When set an invalid symmetric hash rule, just return failed.
Fixes 7d0824387e63 ("net/ice: fix invalid RSS type")
Signed-off-by Jeff Guo <[email protected]>
--- drivers/net/ice/ice_hash.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/net/ice/ice_hash.c +12 -1
@@ -1026,6 +1026,7 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,const struct rte_flow_action *action;uint64_t rss_attr_src_dst;uint64_t rss_attr_l3_pre; +uint64_t rss_attr_symm;uint64_t rss_attr_all;uint64_t rss_type;uint16_t i;
@@ -1089,6 +1090,15 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,RTE_ETH_RSS_L3_PRE48 |RTE_ETH_RSS_L3_PRE64 ; + rss_attr_symm =ETH_RSS_IPV4 | +ETH_RSS_NONFRAG_IPV4_UDP | +ETH_RSS_NONFRAG_IPV4_TCP | +ETH_RSS_NONFRAG_IPV4_SCTP | +ETH_RSS_IPV6 | +ETH_RSS_NONFRAG_IPV6_UDP | +ETH_RSS_NONFRAG_IPV6_TCP | +ETH_RSS_NONFRAG_IPV6_SCTP ; + rss_attr_all = rss_attr_src_dst | rss_attr_l3_pre;/* Check if only SRC/DST_ONLY or ipv6 prefix exists. */
@@ -1103,7 +1113,8 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,*/ if (rss->func ==RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ ) { -if (rss_type & rss_attr_src_dst) +if (rss_type & (rss_attr_src_dst | + ~rss_attr_symm)) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,
Signature · 1 line
2.20.1
Quoted 9 lines
-----Original Message-----
From: Guo, Jia <[email protected]>
Sent: Monday, July 20, 2020 5:14 PM
To: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>
Cc: [email protected]; Su, Simei <[email protected]>; Guo, Jia <[email protected]>
Subject: [dpdk-dev v1] net/ice: fix symmetric hash configuration
Quoted 5 lines
Some protocol don't support symmetric hash, need to handle these cases. When set an invalid symmetric hash rule, just return failed.
Fixes 7d0824387e63 ("net/ice: fix invalid RSS type")Signed-off-by Jeff Guo <[email protected]>
Acked-by Qi Zhang <[email protected]>
Applied to dpdk-next-net-intel.
Thanks.
Qi