Skip to contentSkip to conversation

qdev: Document qdev_prop_set_drive_err() return value

PATCH In review Philippe Mathieu-Daudé 3 participants 3 messages Jul 20, 2020 – Jul 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qdev: Document qdev_prop_set_drive_err() return value

Since commit 73ac1aac39 qdev_prop_set_drive_err() returns a boolean value. Document it.

Fixes 73ac1aac39 "Make functions taking Error ** return bool, not void"
---
 include/hw/qdev-properties.h | 2 ++
 1 file changed, 2 insertions(+)
include/hw/qdev-properties.h +2 -0
index 587e5b7d31..3a64d5ab9a 100644
@@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
 
 /*
  * Set properties between creation and realization.
+ *
+ * Returns: %true on success, %false on error.
  */
 bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
                              BlockBackend *value, Error **errp);
Signature · 1 line
2.21.3
#1 lore raw
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base"

# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===

The full log is available at
http://patchew.org/logs/[email protected]/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]

Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 14 lines · Philippe Mathieu-Daudé

Since commit 73ac1aac39 qdev_prop_set_drive_err() returns a boolean value. Document it.

Fixes 73ac1aac39 "Make functions taking Error ** return bool, not void"
---
 include/hw/qdev-properties.h | 2 ++
 1 file changed, 2 insertions(+)
include/hw/qdev-properties.h +0 -0
index 587e5b7d31..3a64d5ab9a 100644

include/hw/qdev-properties.h extern const PropertyInfo qdev_prop_pcie_link_width; · line 245

Quoted 8 lines
include/hw/qdev-properties.h +2 -0
@@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
 
 /*
  * Set properties between creation and realization.
+ *
+ * Returns: %true on success, %false on error.
  */
 bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
                              BlockBackend *value, Error **errp);